Fix: Web-3042 Resolved crash observed in switching role from VNRT to Broadcaster in MWeb #3299
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygit
requested review from
raviteja83,
eswarclynn,
amar-1995 and
KaustubhKumar05
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raviteja83
reviewed
Oct 5, 2024
| @@ -450,7 +450,7 @@ export class DeviceManager implements HMSDeviceManager { | |||
| wired = device; | |||
| } else if (deviceCategory === 'bluetooth') { | |||
| bluetoothDevice = device; | |||
| } else if (deviceCategory === 'speakerhone') { | |||
| } else if (deviceCategory === 'earpiece') { | |||
There was a problem hiding this comment.
@eswarclynn could this typo have caused any issues?
There was a problem hiding this comment.
our earpiece selection logic will fail
There was a problem hiding this comment.
Could be remember copying this code, from AudioSinkManager
raviteja83
reviewed
Oct 5, 2024
packages/roomkit-react/src/Prebuilt/components/Header/common.jsx
Outdated
Show resolved
Hide resolved
raviteja83
reviewed
Oct 5, 2024
| export const getAudioDeviceCategory = (deviceLabel?: string) => { | ||
| if (!deviceLabel) { | ||
| HMSLogger.e('[DeviceManager]:', 'No device label provided'); | ||
| return 'speakerphone'; |
There was a problem hiding this comment.
when do we get into this scenario? when no publish permission is present like viewer roles?
There was a problem hiding this comment.
- In LiveStreaming Room, join as Broadcaster
- Switch role to VNRT
- Switch role back to Broadcaster, then the crash happens
raviteja83
reviewed
Oct 5, 2024
| const label = deviceLabel.toLowerCase(); | ||
| if (label.includes('speakerphone')) { | ||
| return 'speakerhone'; | ||
| return 'speakerphone'; |
There was a problem hiding this comment.
@eswarclynn enum could have prevented this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details(context, link the issue, how was the bug fixed, what does the new feature do)