Fix/web 3039 ios notification undefined #3301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdz-666
requested review from
raviteja83,
eswarclynn,
amar-1995 and
KaustubhKumar05
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raviteja83
reviewed
Oct 5, 2024
| @@ -38,7 +38,7 @@ class ClientAnalyticsTransport implements IAnalyticsTransportProvider { | |||
| private failedEvents = new LocalStorage<AnalyticsEvent[]>('client-events'); | |||
| isConnected = true; | |||
| private env: null | ENV = null; | |||
| private websocketURL = ''; | |||
| public websocketURL = ''; | |||
There was a problem hiding this comment.
@hdz-666 can we make sure we create branches from proper base branches. always create from dev instead of another branches
raviteja83
reviewed
Oct 5, 2024
| unsubscribe?.(); | ||
|
|
||
| try { | ||
| if (navigator.webdriver) { |
There was a problem hiding this comment.
let us combine the 3 if blocks
raviteja83
reviewed
Oct 5, 2024
| if (Notification?.permission === 'granted' || Notification?.permission === 'denied') { | ||
| return; | ||
| } | ||
| console.log('###### Requesting Notification Permission unsubscribe', Notification); |
There was a problem hiding this comment.
remove test log. check with yogesh and 16.5.1 in browserstack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details(context, link the issue, how was the bug fixed, what does the new feature do)
Implementation note, gotchas, related work and Future TODOs (optional)