New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper function for setting id and cpu simultaneously. #3733

Merged

ax3l merged 7 commits into AMReX-Codes:development from atmyers:idcpu_helper

Jan 31, 2024

Member

atmyers commented Jan 30, 2024 •

edited by ax3l

Loading

Also sneaking in a small ignore_unused fix.

Close #3731.

The proposed changes:

fix a bug or incorrect behavior in AMReX
add new capabilities to AMReX
changes answers in the test suite to more than roundoff level
are likely to significantly affect the results of downstream AMReX users
include documentation in the code and/or rst files, if appropriate


          Add helper function for setting id and cpu simultaneously.

atmyers requested a review from ax3l

January 30, 2024 23:05

ax3l self-assigned this

ax3l added the enhancement label

ax3l reviewed

View reviewed changes

Src/Particle/AMReX_Particle.H Outdated Show resolved Hide resolved

ax3l reviewed

View reviewed changes

Src/Particle/AMReX_Particle.H Outdated Show resolved Hide resolved

ax3l added 2 commits

January 30, 2024 15:27


          Add Doxygen String

8a44155


          Init Register Value

c7389b9

ax3l approved these changes

View reviewed changes

Member

ax3l left a comment

Thank you!

atmyers commented

View reviewed changes

Src/Particle/AMReX_Particle.H Outdated Show resolved Hide resolved

atmyers commented

View reviewed changes

Src/Particle/AMReX_Particle.H Outdated Show resolved Hide resolved


          Apply suggestions from code review

4d5b358

ax3l approved these changes

View reviewed changes

ax3l reviewed

View reviewed changes

Src/Particle/AMReX_Particle.H Outdated Show resolved Hide resolved


          leftover

154b55f

ax3l enabled auto-merge (squash)

January 30, 2024 23:39

atmyers commented

View reviewed changes

Src/Particle/AMReX_Particle.H Outdated Show resolved Hide resolved

atmyers added 2 commits

January 30, 2024 15:51


          Update Src/Particle/AMReX_Particle.H

81a3008


          host / device

71784c2

ax3l mentioned this pull request

Particle Container to Pure SoA Again ECP-WarpX/WarpX#4653

Merged

4 tasks

ax3l merged commit 09fc44a into AMReX-Codes:development

67 of 69 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels