Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

Update README.md #15

Open
wants to merge 1 commit into
base: release
Choose a base branch
from
Open

Update README.md #15

wants to merge 1 commit into from

Conversation

rinoc
Copy link

@rinoc rinoc commented May 11, 2022 •
edited
Loading

Updated to add instructions on how to build and use in app

@rinoc rinoc requested a review from brandonmowat as a code owner May 11, 2022 19:30
@rinoc rinoc requested review from lozog and allenbmw May 11, 2022 19:31
@rinoc rinoc mentioned this pull request May 11, 2022
Closed
@allenbmw allenbmw added the enhancement New feature or request label May 11, 2022
dandalf-the-engineer
dandalf-the-engineer reviewed May 13, 2022
View reviewed changes
README.md
## To Build

```
npm i
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this npm ci so it installs from the lock file versus the package.json file and will keep the dependencies consistent.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, any reason we're doing npm here and yarn down below?

dandalf-the-engineer
dandalf-the-engineer approved these changes May 13, 2022
View reviewed changes
Copy link

@dandalf-the-engineer dandalf-the-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵 Looks good. I added a few nits

allenbmw
allenbmw approved these changes May 13, 2022
View reviewed changes
Copy link

@allenbmw allenbmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had the time to walk through the steps, was waitin' to do that, but without walking through them 👍

@arsalasif arsalasif removed the request for review from brandonmowat July 14, 2022 19:04
@lozog lozog removed their request for review July 26, 2022 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@allenbmw allenbmw allenbmw approved these changes

@dandalf-the-engineer dandalf-the-engineer dandalf-the-engineer approved these changes

Assignees

@rinoc rinoc

Labels
enhancement New feature or request size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rinoc @allenbmw @dandalf-the-engineer