Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #257 #258

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fixed #257 #258

merged 1 commit into from
Sep 17, 2024

Conversation

cmendible
Copy link
Member

Description

Excel sheets and header rows are created even if scans are skipped to avoid issues with pbi.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #257

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

Copy link
Member Author

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmendible cmendible merged commit 2e18caa into main Sep 17, 2024
12 checks passed
@cmendible cmendible deleted the issue-257 branch September 17, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scanning with cost=false produces an xlsx not importable into pbit
1 participant