Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Upgrade wgpu to version 0.18 #528

Merged
merged 9 commits into from
Nov 27, 2023

Conversation

svermeulen
Copy link
Contributor

Checklist

  • CI Checked:
    • cargo fmt has been ran
    • cargo clippy reports no issues
    • cargo test succeeds
    • cargo rend3-doc has no warnings
    • cargo deny check issues have been fixed or added to deny.toml
  • Manually Checked:
    • relevant examples/test cases run
    • changes added to changelog
      • Add credit to yourself for each change: Added new functionality @githubname.

Related Issues

Description

I had to use "fragile-send-sync-non-atomic-wasm" feature in wgpu dependency sample to avoid a lot of issues related to the multithread support changes

Remaining issues

  • egui targets wgpu 0.18.0 on master but they haven't made a release yet so this may be a blocker for rend3-egui
  • imgui hasn't updated yet so may also present issues for rend3-imgui

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the kick start!

@cwfitzgerald cwfitzgerald merged commit f0df67c into BVE-Reborn:trunk Nov 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants