Remove the 'traits' entry from the 'properties' column in the node, lease, and offer lists #53
Conversation
There was a problem hiding this comment.
Okay, I apologize - I was very wrong. For some reason I thought that traits were smushed into properties in the CLI, but they're not. We don't want to change things this way; the code gets really convoluted and messy for not a lot of gain.
I guess we should remove it from esi-leap after all - specifically, these lines are affected: https://github.com/CCI-MOC/esi-leap/blob/master/esi_leap/resource_objects/ironic_node.py#L69-L71
We'll need an updated esi-leap anyway to deal with the node filtering task.
|
@tzumainn Based on our discussion, I've made the changes accordingly. However, given that we're removing it from esi-leap, I believe no further modifications are necessary in this repository. |
|
Yep - you can just close this PR |
No description provided.