-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sierra #4
Sierra #4
Commits on Jun 8, 2023
-
- The --version argument is now passed down to the "real" mpi wrapper, which is then passed on to the serial compiler. - The mpif77 and mpif90 wrappers are removed, and replaced with the mpifort wrapper. - mpiCC and mpic++ are installed as symlinks to mpicxx - mpif77 and mpif90 are installed as symlinks to mpifort
Configuration menu - View commit details
-
Copy full SHA for bf8e7f1 - Browse repository at this point
Copy the full SHA bf8e7f1View commit details -
Add some missing constants and functions.
- Add missing constant MPI_MAX_LIBRARY_VERSION_STRING - Add missing constant MPI_ERRCODES_IGNORE - Add missing function MPI_Comm_spawn
Configuration menu - View commit details
-
Copy full SHA for f577749 - Browse repository at this point
Copy the full SHA f577749View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7acfc8 - Browse repository at this point
Copy the full SHA e7acfc8View commit details -
Make YogiMPI version discoverable at compile time
- Added "YogiMPI_VERSION_STR" to yogimpi.h and mpif.h, which should be set to the version of YogiMPI used at compile time. - Added "make dist" target, which will create a yogimpi-<VERSION>.tar.gz file, where <VERSION> is determined by $(git describe --tags).
Configuration menu - View commit details
-
Copy full SHA for 9afbddb - Browse repository at this point
Copy the full SHA 9afbddbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01531a3 - Browse repository at this point
Copy the full SHA 01531a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ee4a3f - Browse repository at this point
Copy the full SHA 3ee4a3fView commit details -
Add some const-correctness stuff.
By inspection, there is more to do here.
Configuration menu - View commit details
-
Copy full SHA for eb44d80 - Browse repository at this point
Copy the full SHA eb44d80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a716a8 - Browse repository at this point
Copy the full SHA 0a716a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f64944a - Browse repository at this point
Copy the full SHA f64944aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2049028 - Browse repository at this point
Copy the full SHA 2049028View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c7d92e - Browse repository at this point
Copy the full SHA 9c7d92eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d914ee - Browse repository at this point
Copy the full SHA 8d914eeView commit details -
Wrap some function pointers passed to MPI
Before this commit, when client code would pass a copy or delete callback to MPI_Comm_create_keyval, if the callbacks had any MPI calls inside them then the code would segfault. The segfault was due to the native MPI passing in the native MPI_Comm to the callback, and then YogiMPI would segfault when tyring to covert the comm to a MPI_Comm because Yogi did not know the comm was already converted. This change captures the callback functions and wraps them in lambdas that un-converts the comm back to a YogiMPI_Comm so it is safe for the callbacks to contain MPI calls. There are likely other failure modes associated with user-supplied callbacks to MPI routines. Hopefully this will be a good pattern to repeat if we find similar issues with other callbacks.
Configuration menu - View commit details
-
Copy full SHA for a9bf7ae - Browse repository at this point
Copy the full SHA a9bf7aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f0ea28 - Browse repository at this point
Copy the full SHA 1f0ea28View commit details -
Configuration menu - View commit details
-
Copy full SHA for b585f85 - Browse repository at this point
Copy the full SHA b585f85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3780738 - Browse repository at this point
Copy the full SHA 3780738View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb6a955 - Browse repository at this point
Copy the full SHA cb6a955View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4901ece - Browse repository at this point
Copy the full SHA 4901eceView commit details
Commits on Jun 16, 2023
-
Add a callDepth tracking mechanism.
This commit wraps almost every single native MPI call with a callDepth increment/decrement. Currently this is only used for indenting calls in the yogimpi.log.* files. There are a certain class of problems that are hard to diagnose, and the commonality is that YogiMPI has called the native MPI and then that MPI has called a callback that was wrapped by YogiMPI. Adding this callDepth and indenting the log file based on callDepth makes it much easier to diagnose the problem.
Configuration menu - View commit details
-
Copy full SHA for 50e943d - Browse repository at this point
Copy the full SHA 50e943dView commit details -
Wrap MPI_User_functions passed to MPI.
This commit wraps MPI_User_functions in lambdas, so we can revert the MPI_Datatype back to a YogiMPI_Datatype before passing it to the callback so that the callback can be called from the native MPI routines (e.g. MPI_Reduce, MPI_Scan, etc.).
Configuration menu - View commit details
-
Copy full SHA for de7576f - Browse repository at this point
Copy the full SHA de7576fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4d3dba - Browse repository at this point
Copy the full SHA c4d3dbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b92964 - Browse repository at this point
Copy the full SHA 6b92964View commit details
Commits on Jun 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7e995f3 - Browse repository at this point
Copy the full SHA 7e995f3View commit details
Commits on Sep 15, 2023
-
Revert "Wrap MPI_User_functions passed to MPI."
This reverts commit de7576f.
Configuration menu - View commit details
-
Copy full SHA for 53c3c0c - Browse repository at this point
Copy the full SHA 53c3c0cView commit details -
Revert "Wrap some function pointers passed to MPI"
This reverts commit a9bf7ae.
Configuration menu - View commit details
-
Copy full SHA for cc8ec8d - Browse repository at this point
Copy the full SHA cc8ec8dView commit details
Commits on Dec 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5cb3f28 - Browse repository at this point
Copy the full SHA 5cb3f28View commit details
Commits on Dec 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 10b4690 - Browse repository at this point
Copy the full SHA 10b4690View commit details -
Configuration menu - View commit details
-
Copy full SHA for c467791 - Browse repository at this point
Copy the full SHA c467791View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6556240 - Browse repository at this point
Copy the full SHA 6556240View commit details -
Configuration menu - View commit details
-
Copy full SHA for 375c775 - Browse repository at this point
Copy the full SHA 375c775View commit details
Commits on Dec 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 53d24ee - Browse repository at this point
Copy the full SHA 53d24eeView commit details
Commits on Feb 22, 2024
-
Revert "Revert "Wrap some function pointers passed to MPI""
This reverts commit cc8ec8d.
Configuration menu - View commit details
-
Copy full SHA for b8a83c5 - Browse repository at this point
Copy the full SHA b8a83c5View commit details -
Revert "Revert "Wrap MPI_User_functions passed to MPI.""
This reverts commit 53c3c0c.
Configuration menu - View commit details
-
Copy full SHA for dc58318 - Browse repository at this point
Copy the full SHA dc58318View commit details
Commits on Feb 25, 2024
-
WIP ... Attempt to fix performance problem.
Still have more testing to do and a bit more cleanup, but I need to move my exploration to another machine.
Configuration menu - View commit details
-
Copy full SHA for 17bef3b - Browse repository at this point
Copy the full SHA 17bef3bView commit details
Commits on Mar 8, 2024
-
Switch most calls back to insertIntoPool
Now only datatypes are using the new insertIntoPoolIfNotExists call. When using the new call for comms and requests things stop working for some reason I don't yet understand, so I'm only using the new call for the datatype which was causing the most issues (I think ...).
Configuration menu - View commit details
-
Copy full SHA for 9755159 - Browse repository at this point
Copy the full SHA 9755159View commit details
Commits on Mar 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c98a691 - Browse repository at this point
Copy the full SHA c98a691View commit details