Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 remove recent bill #22

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

K1ethoang
Copy link
Member

No description provided.

Copy link

netlify bot commented Feb 1, 2024

👷 Deploy request for billsplit-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ddb858f

@K1ethoang K1ethoang marked this pull request as ready for review February 1, 2024 20:23
Copy link
Member

@Balastrong Balastrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good!

Just one thing, I see an check is failing because the files are not formatted. Can you please format them? Either manually or with npm run format

Thank you!

@K1ethoang
Copy link
Member Author

The code looks good!

Just one thing, I see an check is failing because the files are not formatted. Can you please format them? Either manually or with npm run format

Thank you!

Wheb I run that command, about 50 files are changed and ready to add 50 files to push?

@Balastrong
Copy link
Member

50 files are definitely too many, can you format for now only the two that you modified?

Copy link
Member

@Balastrong Balastrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Balastrong Balastrong merged commit 9cd9b33 into DevLeonardoCommunity:main Feb 3, 2024
3 checks passed
@Balastrong
Copy link
Member

@all-contributors please add @K1ethoang for code

Copy link
Contributor

@Balastrong

I've put up a pull request to add @K1ethoang! 🎉

@K1ethoang K1ethoang deleted the remove-bill-recent branch February 3, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants