Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fixed icon for DevToys preview and Stable in MSIX #1328

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Conversation

veler
Copy link
Collaborator

@veler veler commented Jul 20, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #1311

What is the new behavior?

After battling for hours with it, I found out that MSIX / Windows is unhappy with me editing the icon manually to use the scaled up icon that has the "PRE" indication. So instead, I generated the Visual Assets (through Visual Studio) using various SVG of various scale, one per scale of icon. That's enough to solve the problem. I'm puzzled at why though.

image

image

image

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler linked an issue Jul 20, 2024 that may be closed by this pull request
@veler veler merged commit 6cc4201 into main Jul 20, 2024
2 of 3 checks passed
@veler veler deleted the fix1311 branch July 20, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New MS store icon looks off
1 participant