Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced animations #1350

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Reduced animations #1350

merged 1 commit into from
Aug 7, 2024

Conversation

veler
Copy link
Collaborator

@veler veler commented Jul 29, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

It seems like WebKit is less good at animation than Chromium-based browser. MacOS and Linux are suffering of lagging animations.

Issue Number: #1269

What is the new behavior?

On Mac and Linux, we reduced some animations, such as the NavBar ones.
On Windows, we now also respect the Animation Effect user option. When user disable this option, DevToys does less animations.

image

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler veler linked an issue Jul 29, 2024 that may be closed by this pull request
@veler veler merged commit 96f76d9 into main Aug 7, 2024
2 of 3 checks passed
@veler veler deleted the fix1269 branch August 7, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lag When Expanding/Collapsing Sidebar on macOS
1 participant