Fix default initialization of runtime attributes.

Examples/Tests/ionization/analysis_ionization.py

@@ -93,5 +93,13 @@
 
 assert( error_rel < tolerance_rel )
 
+# Check that the user runtime component (if it exists) worked as expected
+try:
+    orig_z = ad['electrons', 'particle_orig_z'].v
+    assert np.all( (orig_z > 0) & (orig_z < 1.5e-5) )
+    print('particle_orig_z has reasonable values')
+except yt.utilities.exceptions.YTFieldNotFound:
+    pass # Some of the tested script to not have the quantity orig_z
+
 test_name = os.path.split(os.getcwd())[1]
 checksumAPI.evaluate_checksum(test_name, filename)

Examples/Tests/ionization/inputs_2d_rt

@@ -36,6 +36,8 @@ ions.physical_element = N
 electrons.mass = m_e
 electrons.charge = -q_e
 electrons.injection_style = none
+electrons.addRealAttributes = orig_z
+electrons.attribute.orig_z(x,y,z,ux,uy,uz,t) = z
 
 lasers.names        = laser1
 laser1.profile      = Gaussian

Regression/Checksum/benchmarks_json/ionization_lab.json

@@ -3,6 +3,7 @@
     "particle_momentum_x": 4.407898469197755e-18,
     "particle_momentum_y": 0.0,
     "particle_momentum_z": 2.642991174223682e-18,
+    "particle_orig_z": 0.43016526372226926,
     "particle_position_x": 0.1095015206652257,
     "particle_position_y": 0.6413864600981052,
     "particle_weight": 3.443203125e-10

Source/Particles/Collision/BackgroundMCC/BackgroundMCCCollision.cpp

@@ -501,7 +501,7 @@ void BackgroundMCCCollision::doBackgroundIonization
                                                        m_mass1, sqrt_kb_m, m_background_temperature_func, t
                                                        );
 
-        const auto num_added = filterCopyTransformParticles<1>(
+        const auto num_added = filterCopyTransformParticles<1>(species1, species2,
                                                                elec_tile, ion_tile, elec_tile, np_elec, np_ion,
                                                                Filter, CopyElec, CopyIon, Transform
                                                                );

Source/Particles/Collision/BinaryCollision/BinaryCollision.H

@@ -173,7 +173,7 @@ public:
 
         amrex::LayoutData<amrex::Real>* cost = WarpX::getCosts(lev);
 
-            // Loop over all grids/tiles at this level
+        // Loop over all grids/tiles at this level
 #ifdef AMREX_USE_OMP
             info.SetDynamic(true);
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
@@ -367,7 +367,9 @@ public:
             // Create the new product particles and define their initial values
             // num_added: how many particles of each product species have been created
             const amrex::Vector<int> num_added = m_copy_transform_functor(n_total_pairs,
-                                                    soa_1, soa_1, tile_products_data,
+                                                    soa_1, soa_1,
+                                                    product_species_vector,
+                                                    tile_products_data,
                                                     particle_ptr_1, particle_ptr_1, m1, m1,
                                                     products_mass, p_mask, products_np,
                                                     copy_species1, copy_species2,
@@ -528,7 +530,9 @@ public:
             // Create the new product particles and define their initial values
             // num_added: how many particles of each product species have been created
             const amrex::Vector<int> num_added = m_copy_transform_functor(n_total_pairs,
-                                                    soa_1, soa_2, tile_products_data,
+                                                    soa_1, soa_2,
+                                                    product_species_vector,
+                                                    tile_products_data,
                                                     particle_ptr_1, particle_ptr_2, m1, m2,
                                                     products_mass, p_mask, products_np,
                                                     copy_species1, copy_species2,

Source/Particles/Collision/BinaryCollision/ParticleCreationFunc.H

@@ -100,6 +100,7 @@ public:
     amrex::Vector<int> operator() (
                     const index_type& n_total_pairs,
                     const SoaData_type& soa_1, const SoaData_type& soa_2,
+                    const amrex::Vector<WarpXParticleContainer*>& pc_products,
                     ParticleTileType** AMREX_RESTRICT tile_products,
                     ParticleType* particle_ptr_1, ParticleType*  particle_ptr_2,
                     const amrex::ParticleReal& m1, const amrex::ParticleReal& m2,
@@ -251,6 +252,27 @@ public:
             }
         });
 
+        // Initialize the user runtime components
+        for (int i = 0; i < m_num_product_species; i++)
+        {
+            int start_index = int(products_np[i]);
+            int stop_index  = int(products_np[i] + num_added_vec[i]);
+            ParticleCreation::DefaultInitializeRuntimeAttributes(*tile_products[i],
+                                       0, 0,
+                                       pc_products[i]->getUserRealAttribs(), pc_products[i]->getUserIntAttribs(),
+                                       pc_products[i]->getParticleComps(), pc_products[i]->getParticleiComps(),
+                                       pc_products[i]->getUserRealAttribParser(),
+                                       pc_products[i]->getUserIntAttribParser(),
+#ifdef WARPX_QED
+                                       false, // do not initialize QED quantities, since they were initialized
+                                              // when calling the SmartCopy functors
+                                       pc_products[i]->get_breit_wheeler_engine_ptr(),
+                                       pc_products[i]->get_quantum_sync_engine_ptr(),
+#endif
+                                       pc_products[i]->getIonizationInitialLevel(),
+                                       start_index, stop_index);
+        }
+
         amrex::Gpu::synchronize();
 
         return num_added_vec;
@@ -289,6 +311,7 @@ public:
     amrex::Vector<int> operator() (
                     const index_type& /*n_total_pairs*/,
                     const SoaData_type& /*soa_1*/, const SoaData_type& /*soa_2*/,
+                    amrex::Vector<WarpXParticleContainer*>& /*pc_products*/,
                     ParticleTileType** /*tile_products*/,
                     ParticleType* /*particle_ptr_1*/, ParticleType* /*particle_ptr_2*/,
                     const amrex::ParticleReal& /*m1*/, const amrex::ParticleReal& /*m2*/,

Source/Particles/LaserParticleContainer.H

@@ -58,8 +58,7 @@ public:
                         amrex::ParticleTile<amrex::Particle<NStructReal, NStructInt>,
                                             NArrayReal, NArrayInt, amrex::PinnedArenaAllocator>& /*pinned_tile*/,
                         const int /*n_external_attr_real*/,
-                        const int /*n_external_attr_int*/,
-                        const amrex::RandomEngine& /*engine*/) final {}
+                        const int /*n_external_attr_int*/) final {}
 
     void ReadHeader (std::istream& is) final;
 

Source/Particles/MultiParticleContainer.cpp

@@ -899,7 +899,7 @@ MultiParticleContainer::doFieldIonization (int lev,
                                                          Bx[pti], By[pti], Bz[pti]);
 
             const auto np_dst = dst_tile.numParticles();
-            const auto num_added = filterCopyTransformParticles<1>(dst_tile, src_tile, np_dst,
+            const auto num_added = filterCopyTransformParticles<1>(*pc_product, dst_tile, src_tile, np_dst,
                                                                    Filter, Copy, Transform);
 
             setNewParticleIDs(dst_tile, np_dst, num_added);
@@ -1383,7 +1383,7 @@ MultiParticleContainer::doQEDSchwinger ()
 
         const auto Transform = SchwingerTransformFunc{m_qed_schwinger_y_size, PIdx::w};
 
-        const auto num_added = filterCreateTransformFromFAB<1>( dst_ele_tile,
+        const auto num_added = filterCreateTransformFromFAB<1>( *pc_product_ele, *pc_product_pos, dst_ele_tile,
                                dst_pos_tile, box, fieldsEB, np_ele_dst,
                                np_pos_dst,Filter, CreateEle, CreatePos,
                                Transform);
@@ -1536,7 +1536,7 @@ void MultiParticleContainer::doQedBreitWheeler (int lev,
 
             const auto np_dst_ele = dst_ele_tile.numParticles();
             const auto np_dst_pos = dst_pos_tile.numParticles();
-            const auto num_added = filterCopyTransformParticles<1>(
+            const auto num_added = filterCopyTransformParticles<1>(*pc_product_ele, *pc_product_pos,
                                                       dst_ele_tile, dst_pos_tile,
                                                       src_tile, np_dst_ele, np_dst_pos,
                                                       Filter, CopyEle, CopyPos, Transform);
@@ -1616,7 +1616,7 @@ void MultiParticleContainer::doQedQuantumSync (int lev,
             const auto np_dst = dst_tile.numParticles();
 
             const auto num_added =
-                filterCopyTransformParticles<1>(dst_tile, src_tile, np_dst,
+                filterCopyTransformParticles<1>(*pc_product_phot, dst_tile, src_tile, np_dst,
                                                 Filter, CopyPhot, Transform);
 
             setNewParticleIDs(dst_tile, np_dst, num_added);