Reduce tolerance for DSMC CI test #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgrote
reviewed
Jan 5, 2024
| @@ -57,4 +55,4 @@ | |||
|
|
|||
| density_data = np.load( 'ion_density_case_1.npy' ) | |||
| print(repr(density_data)) | |||
| assert np.allclose(density_data, ref_density, rtol=0.01) | |||
| assert np.allclose(density_data, ref_density, rtol=1e-3) | |||
There was a problem hiding this comment.
How small can rtol be? The density should be exactly reproducible.
There was a problem hiding this comment.
I'll leave it to the default (1e-5) and we can see if it that causes any issues.
roelof-groenewald
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #4572 updated the DSMC test to have a fixed random seed we can reduce the tolerance of that CI test so that it is more sensitive to breaking changes.