Always write the particles' positions #4855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
commented
Apr 12, 2024
RemiLehe
commented
Apr 12, 2024
| // to be consistent with always writing out r and z. | ||
| // TODO: openPMD does a reconstruction to Cartesian, so we can now skip force-writing this | ||
| m_plot_flags[pc->getParticleComps().at("theta")] = 1; | ||
| #endif |
There was a problem hiding this comment.
My impression is that theta is not useful, since the particles are dumped in Cartesian coordinates anyway. In fact, I think that this flag is not doing anything, since theta is actually not written anymore as of:
#4686
There was a problem hiding this comment.
Hm, it seems that this is still needed when writing plotfiles.
RemiLehe
commented
Apr 13, 2024
| @@ -49,6 +49,15 @@ ParticleDiag::ParticleDiag( | |||
| m_plot_flags[existing_variable_names.at(var)] = 1; | |||
| } | |||
| } | |||
| // Always write the position | |||
| // Note: for WARPX_DIM_RZ, no need to set the flag y: it is always written | |||
There was a problem hiding this comment.
In RZ, I observed empirically that:
- I need to set
m_plot_flags[pc->getParticleComps().at("x")] = 1;(otherwise the Cartesianxposition is not written correctly with openPMD) - I cannot set
m_plot_flags[pc->getParticleComps().at("y")] = 1;(otherwise I get an error inat, saying that this property does not exist), but the Cartesianyis automatically reconstructed and written anyway.
@ax3l Do you understand why y is automatically written, but not x? (i.e. why do I need to set the flag for x, but not for y)
|
Replaced by #4914 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our restructuring from AoS positions to SoA (#4653), it seems that the particles' positions are not written out by default anymore. (But they probably should, since, in my understanding, the particles' positions and ID are required attributes in the openPMD standard.)
This PR writes out the particle positions by default.
Fixes #4841