General parser function for external fields #5349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kli-jfp
force-pushed
the
general_field_parser_function
branch
from
d3ad8be
to
ff36f1b
Compare
There was a problem hiding this comment.
Thanks a lot for this PR! It will help to make things more maintainable when all grid parsing is done through the same function.
One question I have, do you think it would be possible to reduce the amount of code duplication in the two overloads of ComputeExternalFieldOnGridUsingParser? One suggestion would be to make the edge_lengths and face_areas arguments std::optional with default values of std::nullopt. That way if they are not given the lx, Sx, ... variables could just remain uninitialized and things like if(lx && ...) would return false.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kli-jfp
force-pushed
the
general_field_parser_function
branch
from
64dbd99
to
9981ec7
Compare
kli-jfp
changed the title
kli-jfp
changed the title
|
I'm struggling to get clang-tidy build to compile. Working on it. |
kli-jfp
changed the title
roelof-groenewald
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature replaces the InitializeExternalFieldsOnGridUsingParser with a more general function ComputeExternalFieldOnGridUsingParser. The new function takes parsed functions with four dimensions (x,y,z,t), so that it can be used to evaluate functions throughout the simulation, for example time-dependent external fields.
The function ComputeExternalFieldOnGridUsingParser has optional edge length and face areas.