-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp in rpointer name #1147
base: cam_development
Are you sure you want to change the base?
Timestamp in rpointer name #1147
Conversation
Merge pull request ESCOMP#1084 from brian-eaton/cosp-cwat2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments and a question
src/control/cam_initfiles.F90
Outdated
write(iulog, "Warning : rpointer file "//trim(rest_pfile)//" not found.") | ||
rest_pfile = "rpointer.cam"//trim(inst_suffix) | ||
inquire(file=trim(rest_pfile),exist=found) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write(iulog, "Warning : rpointer file "//trim(rest_pfile)//" not found.") | |
rest_pfile = "rpointer.cam"//trim(inst_suffix) | |
inquire(file=trim(rest_pfile),exist=found) | |
write(iulog, "INFO : rpointer file "//trim(rest_pfile)//" not found.") | |
rest_pfile = "rpointer.cam"//trim(inst_suffix) | |
write(iulog, " Try looking for "//trim(rest_pfile)//" ...") | |
inquire(file=trim(rest_pfile),exist=found) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/control/runtime_opts.F90
Outdated
@@ -109,7 +109,6 @@ subroutine read_namelist(nlfilename, single_column, scmlat, scmlon) | |||
logical, intent(in) :: single_column | |||
real(r8), intent(in) :: scmlat | |||
real(r8), intent(in) :: scmlon | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a whitespace change. This file should be reverted to original.
restart_pfile = interpret_filename_spec('rpointer.cpl.%y-%m-%d-%s',& | ||
yr_spec=yr_spec, mon_spec=mon_spec, day_spec=day_spec, sec_spec= sec_spec ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restart_pfile
is set but not used. Is this for a future need when the coupler external is updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out this bug, it should replace 'rpointer.cpl' below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good now
Add a timestamp in the rpointer name.
This is a backward compatible change in that rpointer.cam will still work
but new files will include a timestamp.
Fixes #1146