Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrixcnOn testmod shouldn't include default testmod #2814

Open
samsrabin opened this issue Oct 7, 2024 · 0 comments · May be fixed by #2815
Open

matrixcnOn testmod shouldn't include default testmod #2814

samsrabin opened this issue Oct 7, 2024 · 0 comments · May be fixed by #2815
Assignees
@samsrabin
Labels
bug something is working incorrectly non-bfb Changes answers (incl. adding tests) test: aux_clm Pass aux_clm suite before merging testing additions or changes to tests

Comments

@samsrabin
Copy link
Collaborator

samsrabin commented Oct 7, 2024 •
edited
Loading

Brief summary of bug

It looks like the matrixcnOn (and thus also matrixcnOn_ignore_warnings) test have ../default in their include_user_mods. This makes it so that there is WAY too much output being saved. Most of the tests with those testmods are meant to have monthly output, but instead they're getting files saved daily or more frequently.

This is probably causing the "job exceeded walltime" error for test ERS_Ly5_P128x1.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput--clm-matrixcnOn_ignore_warnings.

General bug information

CTSM version you are using: ctsm5.3.002

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: Any tests with the matrixcnOn (and thus also matrixcnOn_ignore_warnings) testmods.

Details of bug

I'm going to fix this by deleting cime_config/testdefs/testmods_dirs/clm/matrixcnOn/include_user_mods. That will cause a number of tests to change answers, so this will seemingly be a non-b4b change.
@samsrabin samsrabin added bug something is working incorrectly testing additions or changes to tests non-bfb Changes answers (incl. adding tests) test: aux_clm Pass aux_clm suite before merging labels Oct 7, 2024
@samsrabin samsrabin self-assigned this Oct 7, 2024
samsrabin added a commit to samsrabin/CTSM that referenced this issue Oct 7, 2024
@samsrabin
Bump up wallclock time for one test.
3f5aa0f 
ERS_Ly5_P128x1.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput--clm-matrixcnOn_ignore_warnings
See ESCOMP#2814 (ESCOMP#2814)
samsrabin added a commit to samsrabin/CTSM that referenced this issue Oct 7, 2024
@samsrabin
Remove include_user_mods from matrixcnOn testmod.
3ec9215 
Should avoid unnecessary levels of history writing.
Resolves ESCOMP#2814.
@samsrabin samsrabin linked a pull request Oct 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samsrabin samsrabin

Labels
bug something is working incorrectly non-bfb Changes answers (incl. adding tests) test: aux_clm Pass aux_clm suite before merging testing additions or changes to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove include_user_mods from matrixcnOn testmod samsrabin/CTSM
1 participant
@samsrabin