Remove include_user_mods from matrixcnOn testmod #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should avoid unnecessary levels of history writing. Resolves ESCOMP#2814.
samsrabin
added
bug
samsrabin
commented
Oct 8, 2024
| @@ -1333,7 +1333,7 @@ | |||
| <machine name="derecho" compiler="intel" category="aux_clm"/> | |||
| </machines> | |||
| <options> | |||
| <option name="wallclock">01:40:00</option> | |||
| <option name="wallclock">01:40:01</option> | |||
There was a problem hiding this comment.
In the likely case this comes in after the b4b-dev merge changing this test to 2:30:00, this change will cause a merge conflict, at which point I'll be able to ensure it gets set to 1:40:00.
samsrabin
added
the
next
samsrabin
commented
Oct 8, 2024
| @@ -3332,7 +3332,7 @@ | |||
| <option name="tput_tolerance">0.1</option> | |||
| </options> | |||
| </test> | |||
| <test name="PFS_Ld10_PS" grid="f19_g17" compset="I2000Clm50BgcCrop" testmods="clm/matrixcnOn"> | |||
| <test name="PFS_Ld10_PS" grid="f19_g17" compset="I2000Clm50BgcCrop" testmods="clm/default--clm/matrixcnOn"> | |||
There was a problem hiding this comment.
This was the only test with matrixcnOn* that didn't have another testmod as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should avoid unnecessary levels of history writing.
Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? Only for our tests.
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: None yet.