Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add surface water outflow parameter #2581

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

swensosc
Copy link
Contributor

@swensosc swensosc commented Jun 5, 2024

Description of changes

change hard coded constant to a parameter on the parameter file

Specific notes

netcdf file was modified by adding the following:
h2osfc_outflow_scalar = 0.002
double h2osfc_outflow_scalar ;
h2osfc_outflow_scalar:long_name = "h2osfc outflow scalar" ;
h2osfc_outflow_scalar:units = "unitless"
Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?
when use_hillslope = .true. surface water outflow will change. The original constant was 1e-4, the new parameter value is currently 2e-3
Any User Interface Changes (namelist or namelist defaults changes)?

Does this create a need to change or add documentation? Did you do so?

Testing performed, if any:

@ekluzek ekluzek added next this should get some attention in the next week or two. Normally each Thursday SE meeting. tag: simple labels Jun 5, 2024
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Always better to have parameters on the parameter file rather than hardcoded in.

I asked for a commented out line to be deleted. And we'll need to have a new parameter file to point to for this in bld/namelist_files/namelist_defaults_ctsm.xml. So that's required.

The other suggestion I have though is that we rebase this to b4b-dev rather than master and bring it in with a parameter file with the same value. Then as an answer changing tag we'll update the parameter file as a separate thing. One reason to do that is that it's easier to bring something in on b4b-dev, and we could do that right away, whereas master is frozen right now until cesm3_0_beta01 is done, and that will be near the end of the month. How does that sound?

@swensosc
Copy link
Contributor Author

swensosc commented Jun 5, 2024 via email

@ekluzek ekluzek removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jun 6, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Jun 6, 2024

@samsrabin volunteered for this since it's hillslope. He'd like to bring it in as it's own answer changing tag, since it's tiny. So he'll just make it it's own tag on master. So we won't do the b4b-dev thing I suggested above.

@samsrabin samsrabin added this to the CESM3 Answer changing freeze milestone Jun 6, 2024
@samsrabin samsrabin added good first issue simple; good for first-time contributors and removed simple labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue simple; good for first-time contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants