Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the choice of pressure in CLMU building energy model (BEM) #2758

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cathyxinchangli
Copy link
Contributor

Description of changes

In the CLMU BEM, the choice of pressure for calculating indoor air density is changed from standard pressure to bottom layer of atmosphere pressure of the corresponding grid cell.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #): #2755

Are answers expected to change (and if so in what way)?
Yes, some urban variables such as urban 2m air temperature, 2m relative humidity, urban air-conditioning and heating energy fluxes will change slightly. See #2755 for details.

Any User Interface Changes (namelist or namelist defaults changes)? No.

Does this create a need to change or add documentation? Did you do so?
I have updated the inline documentation in the code where it's needed. I personally don't think it requires changing or adding documentation elsewhere, but if so, I would be happy to help.

Testing performed, if any:
The original code change was done based on ctsm5.2.001, with which I performed one land-only simulation for the year 2000 under DEBUG mode, and the simulation ran as expected. Details are available in #2755. I did not run additional tests after syncing the branch to the latest CTSM main.

Change pressure used in air density calculation in the BEM from standard pressure to bottom layer of atmosphere pressure
@olyson olyson self-requested a review September 12, 2024 19:55
@olyson olyson added the bug something is working incorrectly label Sep 12, 2024
@olyson olyson added this to the ctsm6.1.0 milestone Sep 12, 2024
@cathyxinchangli
Copy link
Contributor Author

Thank you for the suggestions, @olyson! I have updated the code. Please let me know if you would like me to run additional tests or help with anything else!

Copy link
Contributor

@olyson olyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is working incorrectly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants