Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Clm51 references throughout or change to Clm60 #2808

Open
wants to merge 8 commits into
base: cesm3_0_beta04_changes
Choose a base branch
from

Conversation

slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Oct 2, 2024

Description of changes

TODO list appears in the corresponding issue #2379.

Specific notes

Contributors other than yourself, if any:
@ekluzek

CTSM Issues Fixed (include github issue #):
Fixes #2379.

Are answers expected to change (and if so in what way)?
No.

Any User Interface Changes (namelist or namelist defaults changes)?
Removing Clm51 references throughout.

Does this create a need to change or add documentation? Did you do so?
Yes.

Testing performed, if any:
On derecho:

  • PASS make black and make lint
  • PASS ./run_ctsm_py_tests -s and ./run_ctsm_py_tests -u
  • PASS ./build-namelist_test.pl
  • OK aux_clm without mods to the submodules, yet

@slevis-lmwg slevis-lmwg self-assigned this Oct 2, 2024
@slevis-lmwg slevis-lmwg added the bfb bit-for-bit label Oct 2, 2024
@slevis-lmwg slevis-lmwg changed the base branch from master to cesm3_0_beta04_changes October 7, 2024 21:00
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Oct 7, 2024

OK aux_clm on derecho before rebasing from master to the cesm3_0_beta04_changes branch.

After rebasing to the cesm3_0_beta04_changes branch:
OK aux_clm on derecho
OK aux_clm on izumi
PASS make black and make lint
PASS ./run_ctsm_py_tests -u and ./run_ctsm_py_tests -s
PASS ./build-namelist_test.pl (still running, but I expect this to pass)

This PR is ready to merge. I need to wait for @ekluzek's review and approval, especially due to the potential for conflicts as mentioned in this post.

@slevis-lmwg slevis-lmwg marked this pull request as ready for review October 8, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate clm5_1 physics with ctsm5.2.0
1 participant