Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public Config.update_from_dirs() method #2538

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Oct 2, 2024

Description

While working on making ESMValTool with the new configuration (#2448) I noticed that we are missing a simple public function to update the configuration from one or more directories.

This PR adds that.

Related to #2371

Link to documentation: https://esmvaltool--2538.org.readthedocs.build/projects/ESMValCore/en/2538/api/esmvalcore.config.html#esmvalcore.config.Config.update_from_dirs


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the config label Oct 2, 2024
@schlunma schlunma added this to the v2.12.0 milestone Oct 2, 2024
@schlunma schlunma self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (5b28372) to head (3dcd2d5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2538      +/-   ##
==========================================
+ Coverage   94.90%   94.91%   +0.01%     
==========================================
  Files         251      251              
  Lines       14295    14301       +6     
==========================================
+ Hits        13566    13574       +8     
+ Misses        729      727       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noicee! Just one (possible offbeat) comment from me, can merge right after Manu bothers giving me an answer to that 🍺

esmvalcore/config/_config_object.py Show resolved Hide resolved
@valeriupredoi valeriupredoi merged commit 99c6a7b into main Oct 8, 2024
7 checks passed
@valeriupredoi valeriupredoi deleted the update_config_method branch October 8, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants