-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from web-platform-tests:master #42
base: master
Are you sure you want to change the base?
Commits on Sep 18, 2024
-
[@container] Move parsing support helpers to cq-testcommon.js
Functions were duplicated across test files. Change-Id: I61d7d03fb57547e8f0b52bc4d27e1efc4504280d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5869120 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1356983}
Configuration menu - View commit details
-
Copy full SHA for 01ec151 - Browse repository at this point
Copy the full SHA 01ec151View commit details -
Add WPT: scaleResolutionDownTo maintains aspect ratio.
Test that if the frame is 120x60 and restrictions are max 60x60 then the result is 60x30 as to maintain the original aspect ratio. Bug: chromium:363544347, webrtc:366067962 Change-Id: Ic6665871d6d9efde4726dd8a41631eca5ed8a7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5853944 Commit-Queue: Henrik Boström <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1356990}
Configuration menu - View commit details
-
Copy full SHA for efafea1 - Browse repository at this point
Copy the full SHA efafea1View commit details -
Slit up Curve448 and Curve25519 import tests (#48206)
The Curve448 algorithms are not implemented in any of the major browsers, so it's better to define its import/export tests in separate files to avoid unnecessary noise on the tests for the Curve25519 algorithms.
Configuration menu - View commit details
-
Copy full SHA for 575f88f - Browse repository at this point
Copy the full SHA 575f88fView commit details -
WebHID: Add support for dedicated workers
This CL exposes the WebHID API to dedicated workers behind the blink runtime feature WebHIDOnDedicatedWorkers. Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/y__BOYfZWzI Spec PR: WICG/webhid#121 Spec issue: WICG/webhid#120 Demo: https://webhid-worker.glitch.me/ Change-Id: If145f34faf9211a54c8b4a15fbe7e903411b8d1d Bug: 365932453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5841991 Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Yoav Weiss (@Shopify) <[email protected]> Reviewed-by: Matt Reynolds <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357046}
Configuration menu - View commit details
-
Copy full SHA for f3a05bb - Browse repository at this point
Copy the full SHA f3a05bbView commit details -
Split Ed448 and Ed25519 sign / verify algorithms (#48207)
The Ed448 algorithm is not implemented in any of the major browsers, so it's better to define its sign / verify tests in a separate file to avoid unnecessary noise on the tests for the Ed25519 algorithm.
Configuration menu - View commit details
-
Copy full SHA for 4d67f35 - Browse repository at this point
Copy the full SHA 4d67f35View commit details -
Fix WPT for cross-partition blob URL navigation
When `window.open` is performed with 'noopener' a null handle is returned regardless of whether the navigation succeeded. Bug: 359245744 Change-Id: I027e218b42936bdad5c0f4272f6a613978dc79de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5871987 Reviewed-by: Andrew Williams <[email protected]> Commit-Queue: Kyra Seevers <[email protected]> Reviewed-by: Kyra Seevers <[email protected]> Auto-Submit: Janice Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357219}
Configuration menu - View commit details
-
Copy full SHA for f389d33 - Browse repository at this point
Copy the full SHA f389d33View commit details -
Remove inconsistent subtests from color-valid-relative-color.html
These two cases expect relative colors to be resolved at parse time when it's possible to do so. However, the rest of the cases in this test have been updated per w3c/csswg-drafts#10328 to expect declared values of relative colors to preserve their original forms. The cases tested that both rgb and color(srgb both result in color(srgb, but this is not valid any more for specified colors. We already have coverage of the same scenario for computed colors in color-computed-relative-color.html, so these subtests can be removed.
Configuration menu - View commit details
-
Copy full SHA for 61f0971 - Browse repository at this point
Copy the full SHA 61f0971View commit details -
Fix explanation for edge case in FederatedAuthRequestImpl
This CL updates the explanation for the edge case in FederatedAuthRequestImpl::CancelTokenRequest() and adds test which executes the edge case. BUG=40940748 Change-Id: I800959c721f13364801110eb20b1e1dff0b45059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5871992 Commit-Queue: Peter Kotwicz <[email protected]> Reviewed-by: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357306}
Configuration menu - View commit details
-
Copy full SHA for 55756e1 - Browse repository at this point
Copy the full SHA 55756e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for efc196a - Browse repository at this point
Copy the full SHA efc196aView commit details
Commits on Sep 19, 2024
-
WebNN: Implement scatterND in DirectML backend
This CL also adds WPT and fixes a mojo comment format issue for scatterND. Bug: 363761938 Change-Id: Icaa6ba11943f7e89796f13b70e637c7ec496dd75 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5862351 Reviewed-by: Alex Gough <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Commit-Queue: ningxin hu <[email protected]> Reviewed-by: Rafael Cintron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357392}
Configuration menu - View commit details
-
Copy full SHA for 406412f - Browse repository at this point
Copy the full SHA 406412fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f2593c - Browse repository at this point
Copy the full SHA 0f2593cView commit details -
Don't pass --enable-xss-auditor to webkitgtk_minibrowser
This option was deprecated and has now been removed from recent versions of webkitgtk_minibrowser (which will cause the browser to not start if the option is given.)
Configuration menu - View commit details
-
Copy full SHA for f7d4a7f - Browse repository at this point
Copy the full SHA f7d4a7fView commit details -
Correct a mistake in 62fb506. The leading 0x00 bytes are wrong.
Configuration menu - View commit details
-
Copy full SHA for 06682bd - Browse repository at this point
Copy the full SHA 06682bdView commit details -
[@container] Add parsing tests for scroll-state(overflowing)
Bug: 367764865 Change-Id: I6bb49467bd273aa25fd9332a9e5e5d868bd86bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872842 Commit-Queue: Rune Lillesveen <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357517}
Configuration menu - View commit details
-
Copy full SHA for 65e6522 - Browse repository at this point
Copy the full SHA 65e6522View commit details -
[WebDriver BiDi]
browsingContext.traverseHistory
only for top-level…… navigables (#48260) Align with spec changes introduced in w3c/webdriver-bidi#770
Configuration menu - View commit details
-
Copy full SHA for eb15769 - Browse repository at this point
Copy the full SHA eb15769View commit details -
layout: Ensure that
<caption>
's supportposition: relative
This change adds support for `position: relative` to table `<caption>`. In addition to adjusting their position according to inset values, table captions must also establish containing blocks for descendants that are absolutely positioned. Co-authored-by: Oriol Brufau <[email protected]> Signed-off-by: Martin Robinson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7b75c97 - Browse repository at this point
Copy the full SHA 7b75c97View commit details -
Move tests for transferable WebRTC data channel to main spec directory (
#47707) preparing for w3c/webrtc-extensions#214 ServiceWorker tests remain in webrtc-extensions for now
Configuration menu - View commit details
-
Copy full SHA for 6753496 - Browse repository at this point
Copy the full SHA 6753496View commit details -
Fix bugs in digital-credential WPT tests
BUG=368070320 Change-Id: I4372915e9d661cd4c9905c020acc96d9f4cab975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873851 Reviewed-by: Nina Satragno <[email protected]> Commit-Queue: Peter Kotwicz <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357604}
Configuration menu - View commit details
-
Copy full SHA for 5be647d - Browse repository at this point
Copy the full SHA 5be647dView commit details -
Split up X25519 and X448 tests (#48195)
The X448 algorithm is not implemented in any of the major browsers, so it's better to define its deriveBits / deriveKey tests in a separate file to avoid unnecessary noise on the tests for the X25519 algorithm.
Configuration menu - View commit details
-
Copy full SHA for 203d2ac - Browse repository at this point
Copy the full SHA 203d2acView commit details -
Sync interfaces/ with @webref/idl 3.54.0 (#48261)
Co-authored-by: wpt-pr-bot <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 309f303 - Browse repository at this point
Copy the full SHA 309f303View commit details -
FLEDGE: WPT test some of the B&A message and checking.
... with focus on single-party auctions. Change-Id: Ifb65d0b67ebf4293224bd8a12e9fa724b2320de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5866311 Reviewed-by: Russ Hamilton <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357738}
Configuration menu - View commit details
-
Copy full SHA for 28c8706 - Browse repository at this point
Copy the full SHA 28c8706View commit details -
[wptrunner] Guard against no browser during
TestRunnerManager
clean…Configuration menu - View commit details
-
Copy full SHA for b23d75f - Browse repository at this point
Copy the full SHA b23d75fView commit details -
webnn: add IDL and mojo definition of
gatherND
This CL also implements validation tests in WPT and corresponding `opSupportLimits`. webmachinelearning/webnn#375 (comment) Bug: 40206287 Change-Id: Ic184f2f45a9e201f12fd072675077511bfaec797 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5823074 Commit-Queue: Koji Ishii <[email protected]> Reviewed-by: Alex Gough <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Auto-Submit: Shiyi Zou <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357776}
Configuration menu - View commit details
-
Copy full SHA for 1fb2637 - Browse repository at this point
Copy the full SHA 1fb2637View commit details -
Configuration menu - View commit details
-
Copy full SHA for a154a3a - Browse repository at this point
Copy the full SHA a154a3aView commit details -
Reject opus decoding without description when there's more than 2 cha…
…nnels. Differential Revision: https://phabricator.services.mozilla.com/D220431 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1915143 gecko-commit: 5e3767e9fcca6448d4c1161db2623405369f7f7f gecko-reviewers: chunmin
Configuration menu - View commit details
-
Copy full SHA for a13b4c6 - Browse repository at this point
Copy the full SHA a13b4c6View commit details -
Update WPT MediaStreamTrack-getSettings.https.html to verify deviceId…
… & groupId of initial gUM call. Differential Revision: https://phabricator.services.mozilla.com/D220945 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876636 gecko-commit: e85bbde80dd818783d861032877d45b5c59333a4 gecko-reviewers: karlt
Configuration menu - View commit details
-
Copy full SHA for 7e5dfb8 - Browse repository at this point
Copy the full SHA 7e5dfb8View commit details -
Part 1 - Apply min & max constraints only if block-size is definite i…
…n ComputeBSizeValueAsPercentageBasis(). That is, a definite max block-size and an auto block-size should not compute a definite percentage basis in the block axis. Note that we accidentally pass `testing/web-platform/tests/css/css-sizing/intrinsic-percent-replaced-017.html`. After applying this patch, the test starts to fail, but it will be fixed in the next part. Differential Revision: https://phabricator.services.mozilla.com/D222230 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918576 gecko-commit: e8d914658c039950185a63ec36d5f270c4986008 gecko-reviewers: dholbert
Configuration menu - View commit details
-
Copy full SHA for 36cb3f3 - Browse repository at this point
Copy the full SHA 36cb3f3View commit details -
Part 2 - Mark a flex item's intrinsic inline size dirty if we overrid…
…e its block size. In a column-oriented flex container, if a flex item's intrinsic inline size or its descendants' inline size contributions depend on the item's block size, `NS_FRAME_DESCENDANT_INTRINSIC_ISIZE_DEPENDS_ON_BSIZE` will be set. In this case, when determining the flex item's cross-size, we need to mark the flex item's intrinsic inline size as dirty such that its (auto) inline size is recomputed when constructing its `ReflowInput`. `testing/web-platform/tests/css/css-sizing/intrinsic-percent-replaced-017.html` is the test coverage for this patch. Differential Revision: https://phabricator.services.mozilla.com/D222231 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918576 gecko-commit: 51fd81b5ced0f6cec53b3b475fa50a9a48010848 gecko-reviewers: dholbert
Configuration menu - View commit details
-
Copy full SHA for 07506cf - Browse repository at this point
Copy the full SHA 07506cfView commit details -
change <to-javascript-parent-initiated-parent-csp.html> to create sec…
…uritypolicyviolation event on javascript URL execution. Previously, the securitypolicyviolation was created because an inline event handler was attempted to be executed. The inline event handler's code didn't matter. Differential Revision: https://phabricator.services.mozilla.com/D222424 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919229 gecko-commit: 4349180baf89c9539fb7b7d77ab1be3a4feb2353 gecko-reviewers: tschuster
Configuration menu - View commit details
-
Copy full SHA for e872f92 - Browse repository at this point
Copy the full SHA e872f92View commit details -
Differential Revision: https://phabricator.services.mozilla.com/D221655 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917579 gecko-commit: 8a55e8eb5a286c5961ffdb347bc633fbc0e4964b gecko-reviewers: chunmin
Configuration menu - View commit details
-
Copy full SHA for 3416ef9 - Browse repository at this point
Copy the full SHA 3416ef9View commit details -
Floor right/bottom values of inset()/rect() to make sure that width a…
…nd height of the rectangle are valid. Per spec of `rect()`, the second (right) and third (bottom) values are floored by the fourth (left) and second (top) values, respectively. This is to avoid that they don't cross over the other edge. In our implementation, we just clamp width and height to make sure they are not negative. The both ways should be identical. Note that the spec also mentions another way to handle the similar case in `inset()`, which would like to apply the algorithm mentioned in "CSS Backgrounds 3 § 4.5 Overlapping Curves rules" to proportionally reduce the inset effect to 100%. This may cause a different result from flooring the values. I suspect this is a spec issue: w3c/csswg-drafts#10870. Differential Revision: https://phabricator.services.mozilla.com/D222536 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1916646 gecko-commit: 3c43f092dbbf3d5cab1e39e2b450fee1751407e9 gecko-reviewers: dshin
Configuration menu - View commit details
-
Copy full SHA for 8169e18 - Browse repository at this point
Copy the full SHA 8169e18View commit details -
Add more tests about h264 codec strings.
Differential Revision: https://phabricator.services.mozilla.com/D221050 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1916508 gecko-commit: 12b22d6a5e24b656422b71ffe4f0a8ff8dc54a7b gecko-reviewers: media-playback-reviewers, alwu
Configuration menu - View commit details
-
Copy full SHA for 3939cbf - Browse repository at this point
Copy the full SHA 3939cbfView commit details -
Make CSS zoom apply to themed widgets properly.
Differential Revision: https://phabricator.services.mozilla.com/D222320 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918838 gecko-commit: 4b595e1843aa64b05f111f363838f3adea239f3a gecko-reviewers: dshin
Configuration menu - View commit details
-
Copy full SHA for c6483ac - Browse repository at this point
Copy the full SHA c6483acView commit details -
Make sure visited style computation color-scheme matches unvisited st…
…yle. Plumb it via the StyleBuilder like we do for the writing_mode for the same reasons. Differential Revision: https://phabricator.services.mozilla.com/D222328 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917703 gecko-commit: 67633c2f0a9c228f5c93b815a753fdc45d3024f0 gecko-reviewers: dshin
Configuration menu - View commit details
-
Copy full SHA for 0a477cb - Browse repository at this point
Copy the full SHA 0a477cbView commit details
Commits on Sep 20, 2024
-
[wptrunner] Generalize WebDriver-based print-reftest implementation (#…
…48238) Most of the implementation is lifted verbatim from an existing `chromedriver` one, except the nonstandard CDP call in `render_as_pdf()` is replaced by an equivalent one to WebDriver's "print page" [0]. `shrinkToFit` is actually a WebDriver parameter, not a CDP one, so this PR also fixes some incorrectly scaled screenshots [1]. [0]: https://www.w3.org/TR/webdriver/#print-page [1]: https://crbug.com/366293137
Configuration menu - View commit details
-
Copy full SHA for f9e28d7 - Browse repository at this point
Copy the full SHA f9e28d7View commit details -
Pass percentage basis when computing intrinsic contribution for butto…
…n control's inner frame. Differential Revision: https://phabricator.services.mozilla.com/D222563 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919220 gecko-commit: 98ea87fd51e1ccc38c9a41d67c039a71df085cd0 gecko-reviewers: layout-reviewers, jfkthame
Configuration menu - View commit details
-
Copy full SHA for 148f239 - Browse repository at this point
Copy the full SHA 148f239View commit details -
patch 2 - Also pass percentage basis when computing intrinsic contrib…
…ution for fieldset contents. Differential Revision: https://phabricator.services.mozilla.com/D222591 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919220 gecko-commit: b51d80a6a0c4c1064f62a9e39c9752b58aec2131 gecko-reviewers: dshin
Configuration menu - View commit details
-
Copy full SHA for 2574834 - Browse repository at this point
Copy the full SHA 2574834View commit details -
[wdspec] Update several network bidi tests to assert timings
Depends on D221033 Differential Revision: https://phabricator.services.mozilla.com/D221034 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1916685 gecko-commit: e1aade50c0eb0a2bf43c77266ebf7cc15afbab77 gecko-reviewers: webdriver-reviewers, whimboo
Configuration menu - View commit details
-
Copy full SHA for 4877111 - Browse repository at this point
Copy the full SHA 4877111View commit details -
Assert relative changes in
history.length
insame-url.html
All browsers except Firefox spuriously fail the precondition in `onload` [0] because their history includes `about:blank` (initially loaded by WebDriver [1, 2]), followed by `same-url.html`. Avoid encoding this implementation detail in the test. Also, add the current state to each assertion to make failure more informative. [0]: https://wpt.fyi/results/html/browsers/browsing-the-web/history-traversal/same-url.html?run_id=5145442707046400&run_id=5078811356168192&run_id=5154571592925184&run_id=6326848455966720 [1]: https://www.w3.org/TR/webdriver/#new-window [2]: https://github.com/web-platform-tests/wpt/blob/3939cbfd/tools/wptrunner/wptrunner/executors/executorwebdriver.py#L811-L818
Configuration menu - View commit details
-
Copy full SHA for 707a73f - Browse repository at this point
Copy the full SHA 707a73fView commit details -
webnn: Implement buildGraphAndCompute and add two operators' tests
This cl updates the buildGraphAndCompute method to support subgraphs with multiple operators. The output precision for such subgraphs is the sum of the individual operators’ precisions. Basic tests for both operators have been added. Bug: 333756077 Change-Id: I959d307127503e3a81c82aba91351e97d2edd8dd Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5799843 Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Austin Sullivan <[email protected]> Reviewed-by: David Baron <[email protected]> Commit-Queue: Shanxing Mei <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357962}
Configuration menu - View commit details
-
Copy full SHA for 1c057b9 - Browse repository at this point
Copy the full SHA 1c057b9View commit details -
webnn: implement
gatherND
for DirectML backendThis CL also adds some WPT conformance tests to verify the implementation. webmachinelearning/webnn#375 (comment) Bug: 40206287 Change-Id: I269b8f07647a3ab40fd896d909c5cc060c0f4386 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836729 Reviewed-by: ningxin hu <[email protected]> Auto-Submit: Shiyi Zou <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Commit-Queue: Shiyi Zou <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357985}
Configuration menu - View commit details
-
Copy full SHA for d2a48b9 - Browse repository at this point
Copy the full SHA d2a48b9View commit details -
[line-clamp] Refactor
line-clamp: auto
The current way `line-clamp: auto` works is by checking at every line and after every (line) box whether the box has reached the clamp point's BFC offset, and place an ellipsis or hide the box depending on it. For line boxes, this comparison requires computing the BFC offset at which the line will finish, before it is computed naturally as part of the inline layout algorithm. And if no box ends right at the clamp offset, which is almost every time, the layout has to be redone. An alternative way of doing this work would be by always doing a relayout: the first pass computes which line number to clamp at, and the second pass can behave the same as `line-clamp: 3`. A complication is that with `line-clamp: auto`, unlike with `line-clamp: 3`, it is possible to break between two lineless boxes. To account for this, we store both a number of lines until clamp, as well as a number of remaining boxes between the last line and the clamp point. We pack the lines and the remaining boxes into a `LineClampData::UntilClamp` struct. Since the previous implementation ellipsized lines based on whether they end at the clamp point, it means that a line could have an ellipsis even when it was followed by a zero-height block. It also meant that if a line inside a block with a set `height` might not have an ellipsis even if it was the last line before clamp, because it did not end at the clamp point. This patch fixes those bugs, and adds (or in the case of `line-clamp-auto-032.tentative.html`, fixes) tests for them. In cases where the last line before clamp is followed by an abspos, however, it seems like it would be unexpected for the line to not have the ellipsis. This remains to be discussed with the CSS Working Group (see w3c/csswg-drafts#10868), but since there are previously written tests that rely on this behavior, we have chosen to special case abspos so such a line is ellipsized. Bug: 40336192, 367892771 Change-Id: I45881ce76b7b23de731ae69ef5c947957cc7cf93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5868971 Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Andreu Botella <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358023}
Configuration menu - View commit details
-
Copy full SHA for 865ba12 - Browse repository at this point
Copy the full SHA 865ba12View commit details -
The Request object should expose "duplex"[1], given our support for streaming requests. Since it doesn't, requests with a body currently cannot be used to construct other requests. This CL fixes that by exposing a fixed-value duplex of "half" (as specified). PSA: https://groups.google.com/a/chromium.org/g/blink-dev/c/HPhATidOhuw [1] https://fetch.spec.whatwg.org/#dom-request-duplex Bug: 40237822 Change-Id: I1fedecf912a8f327da6c63bcb0801796e3961640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872928 Commit-Queue: Yoav Weiss (@Shopify) <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358031}
Configuration menu - View commit details
-
Copy full SHA for 9a5664c - Browse repository at this point
Copy the full SHA 9a5664cView commit details -
Sync interfaces/ with @webref/idl 3.55.0 (#48285)
Co-authored-by: wpt-pr-bot <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ce68659 - Browse repository at this point
Copy the full SHA ce68659View commit details -
Adds a simple Navigational Tracking Mitigations test. (#47856)
* Add Navigation Tracking Mitigations test * remove file * Address comments * clean up * address comments * no op --------- Co-authored-by: Giovanni Ortuño Urquidi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f7a3977 - Browse repository at this point
Copy the full SHA f7a3977View commit details -
Update test_driver.click() documentation to specify "mouse" click.
#48158 Change-Id: Ic3c18dd7ae76077fa2303018918777dc04d82022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861351 Commit-Queue: Robert Flack <[email protected]> Auto-Submit: Mustaq Ahmed <[email protected]> Reviewed-by: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358149}
Configuration menu - View commit details
-
Copy full SHA for 783e382 - Browse repository at this point
Copy the full SHA 783e382View commit details -
FLEDGE: WPT verification of B&A component auctions...
...and also various bid fields that are observable from them at top-level auction level. Change-Id: I5ad605a8c9c21563f97dbb8155d9805205f73f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872540 Reviewed-by: Russ Hamilton <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358208}
Configuration menu - View commit details
-
Copy full SHA for 44e0827 - Browse repository at this point
Copy the full SHA 44e0827View commit details -
Implement the nested declarations rule.
I didn't put this behind a pref because it was a bit annoying to do with the parser changes while keeping it fast, and because, at least nesting wise, this is unlikely to cause compat issues. There are some complexities for @scope, which I think I got right. Fixed the tests not to depend on @scope necessarily per the discussion in web-platform-tests/interop#697. Differential Revision: https://phabricator.services.mozilla.com/D222817 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918408 gecko-commit: 0aa1570bfecae9690855f6d6594e79f59593e36c gecko-reviewers: dshin, webidl, smaug
Configuration menu - View commit details
-
Copy full SHA for 449c2d3 - Browse repository at this point
Copy the full SHA 449c2d3View commit details -
Reorganize CSS cascading for higher shadow DOM scopes.
This reorganizes the CSS cascading for shadow DOM scopes above the element's scope so that we do everything one scope at a time, rather than dealing separately with UA shadow pseudo element styles and ::part() styles. I'm only aware of one case where this changes currently-exposed behavior (the cascading of :host::part() selectors relative to other selectors in the same scope), but it also changes the implementation to be closer to the way the specifications describe cascading so that it will extend better to additional features in the future. This changes the bucketing approach in RuleSet for a shadow pseudo-element after ::part() by using the bucket for the innermost pseudo-element rather than the part bucket. (We should perhaps have similar changes for ::slotted() as well, but this does not make those.) These changes are behind the (status:stable) CSSCascadeCorrectScope flag, in case we need to disable them. Supporting this flag involves a bit of code duplication: while MatchHigherScopeRules and MatchPseudoPartRules probably could have been the same function, the number and complexity of flag conditions probably would have made them unreadable, so it seemed better to separate them. This also fixes (without a flag) an interaction in ::slotted()::picker(select) by checking FollowsSlotted as for other pseudo-elements. (::picker(select) has not yet shipped.) However, this doesn't actually fix a test of this interaction, https://crbug.com/366415131 is to follow up on this. This also (again, without a flag) makes two changes to the bucketing optimizations in RuleSet for unshipped features: * bucket ::details-content, which was not previously done * don't skip bucketing for ::picker(X) where X is not select; instead rely on matching to fail later Fixed: 1479329 Bug: 1469418, 356158098, 366415131 Change-Id: I148f8240dbaa20e33bb455c8b65732881767ca3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5851273 Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Auto-Submit: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358283}
Configuration menu - View commit details
-
Copy full SHA for 9310d59 - Browse repository at this point
Copy the full SHA 9310d59View commit details -
FSA: Add cleanup for WPT directory_tests
Currently, directory_tests cleanup before hand to be resilient against other tests not cleaning up properly. But to be more courteous to other tests, this CL adds cleanup for after the test as well. Bug: 346991169 Change-Id: Iff4938926e31691aa3417177fe058a64e46eec0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5871483 Reviewed-by: Christine Hollingsworth <[email protected]> Commit-Queue: Nathan Memmott <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358394}
Configuration menu - View commit details
-
Copy full SHA for 7e330ae - Browse repository at this point
Copy the full SHA 7e330aeView commit details -
Convert compute_pressure_basic web tests to test_driver
The purpose of this change is start using WebDriver. WebDriver commands for Compute Pressure are defined in https://www.w3.org/TR/compute-pressure/#automation Dedicated workers need to manipulate virtual pressure sources, but testdriver calls can only be made in the embedded window, so the existing solution of having '.any.js' files with `META: global=window,dedicatedworker` does not work anymore. The solution is to use message passing so that workers make the embedder window invoke the virtual pressure source calls and use WPT's variants concept to run the same test under multiple configurations. Due to this limitation '.any.js' files needs to be converted to '.window.js'. README.md has been updated to include a detailed guide for creating tests. WebDriver endpoints and virtual pressure sources work in Window and Dedicated Worker scopes, but not shared worker ones: we store virtual pressure source information in WebContentsUserData, which does not integrate well with shared workers. Bug: 347031400 Change-Id: I3cb482c0a689e84012735acd6bc9d33981a7d2f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873130 Reviewed-by: Raphael Kubo Da Costa <[email protected]> Commit-Queue: Raphael Kubo Da Costa <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Auto-Submit: Juha J Vainio <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358424}
Configuration menu - View commit details
-
Copy full SHA for 5a2cfec - Browse repository at this point
Copy the full SHA 5a2cfecView commit details
Commits on Sep 21, 2024
-
Encoding: impact of GB18030-2022 on GBK
See whatwg/encoding#336 for details.
Configuration menu - View commit details
-
Copy full SHA for 1ac8dee - Browse repository at this point
Copy the full SHA 1ac8deeView commit details -
[ReferenceTarget] Ensure setting property does invalidation, add tests
Add tree dump tests for ARIA attributes affected by reference target that can't yet be tested in WPT. Add WPT validating that ARIA label updates upon DOM mutations and reference target changes. Note that aria-owns coverage is omitted since we plan to exclude it from reference target. AX-Relnotes: n/a. Bug: 346835896,353748711 Change-Id: I89f9e0c81d808ac9f1d20035660963d1d09a00aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5739315 Commit-Queue: Dan Clark <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Reviewed-by: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358498}
Configuration menu - View commit details
-
Copy full SHA for 486ed4d - Browse repository at this point
Copy the full SHA 486ed4dView commit details -
webnn: Build infrastructure to support float16 data type
Original design is to serialize all operand to TFLite tensor in a loop before serializing operations, but this approach is not suitable for float16 model because some operations (concat, cast and reshape) support float16 input data type, other operations don't support float16, the operation kind isn't known when serializing operand. The current design is to serialize the input and output operand of operation while serializing the operation at the same time. For input operand, insert a TFLite dequantize operator to convert fp16 to fp32 for graph input, constant and intermediate operand if the current operation doesn't support float16 inference. For output operand, insert a TFLite cast operator to convert fp32 to fp16 if the operand is graph output and the current operation doesn't support float16 inference. Bug: 339654398 Change-Id: Icd03e7a94874bbb1bf915a7485509badf2e59026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5807389 Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Commit-Queue: Junwei Fu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358484}
Configuration menu - View commit details
-
Copy full SHA for 1eb6355 - Browse repository at this point
Copy the full SHA 1eb6355View commit details -
Update/add parsing tests for text-emphasis-position:auto value.
Differential Revision: https://phabricator.services.mozilla.com/D222957 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919658 gecko-commit: 90acfa4e2255174cca231aa5a9cb8349f3fd447d gecko-reviewers: layout-reviewers, emilio
Configuration menu - View commit details
-
Copy full SHA for 8bfa2c6 - Browse repository at this point
Copy the full SHA 8bfa2c6View commit details -
Add a WPT reftest for text-emphasis-position:auto behavior.
Differential Revision: https://phabricator.services.mozilla.com/D222958 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919658 gecko-commit: 94601aa58c87e2b2df729f135fddcdcff7973ac2 gecko-reviewers: layout-reviewers, emilio
Configuration menu - View commit details
-
Copy full SHA for 84ed120 - Browse repository at this point
Copy the full SHA 84ed120View commit details -
Update the MOZ_ASSERT in nsFrameLoader::GetBrowsingContext
With the change in bug 1882670, nsFrameLoader::GetBrowsingContext could be called when we've destroyed the nsFrameLoader. Differential Revision: https://phabricator.services.mozilla.com/D222153 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918505 gecko-commit: 29d6035fe8eee3eb31f4d79f06a1394e1aafe094 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for aebd0be - Browse repository at this point
Copy the full SHA aebd0beView commit details -
View transitions layered capture
Instead of baking tree-effects into view transition snapshots, render the snapshot without these effects and add them as CSS to the ::view-transition-group pseudo-element. This is done by changing the effect order in PaintPropertyTreeBuilder, so that these effects are ancestors of the capture effect. In that way the effects are not applied inside the capture. Also had to modify draw_property_utils, to ensure some of the surface computations don't assume that the view-transition capture would later be painted into an effect surface. See design document with detailed conversation and alternatives: https://docs.google.com/document/d/1jSkIqqlrI4rzZ34cTWC-6TB81cspvHxTcpBD6nDCbE4/edit?tab=t.0#heading=h.tf5nf0fynnc2 Impacted CSS properties: - opacity - mask - clip-path - filter The following properties are also affected, will need a follow-up patch to finish this: - clip - border-radius (when clipping overflow). This is not entirely set up yet, and will follow up. Bug: 347947051 Change-Id: I8f24adf0c2be89ff673f111f099eac065fd4bf7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5789282 Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358591}
Configuration menu - View commit details
-
Copy full SHA for 8e164c2 - Browse repository at this point
Copy the full SHA 8e164c2View commit details
Commits on Sep 23, 2024
-
scaleResolutionDownTo WPTs: Add simulcast and invalid resolution tests.
Simulcast was the last major piece of testing missing. With this CL we should be good to go for shipping this API in a separate CL. In addition to the new tests, this CL also tweaks some resolutions used by other tests to avoid odd resolutions. Some encoder implementations have resolutions alignments (e.g. 15p would become 16p). While not a problem on Chrome which uses VP8 + libvpx by default, I predict this would become a problem when the WPTs run on Safari having H264 by default which would likely trigger resolution alignments so it's best to use even resolutions when we have no reason not to. Bug: chromium:363544347 Change-Id: Id1dba2968f3a0ad3e3206d15b117fdd18643ff41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878075 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358709}
Configuration menu - View commit details
-
Copy full SHA for ce1c71e - Browse repository at this point
Copy the full SHA ce1c71eView commit details -
Make attr() taint stick through registered custom properties.
Change-Id: I1ce0317df871090b28230eb8f83eaf8306210c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5852603 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Steinar H Gunderson <[email protected]> Commit-Queue: Steinar H Gunderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358725}
Configuration menu - View commit details
-
Copy full SHA for 9bbc366 - Browse repository at this point
Copy the full SHA 9bbc366View commit details -
[wdspec] Add cached stylesheet network tests @import and duplicated s…
…tylesheets The initial Firefox support for network events for cached stylesheets fails in 2 known cases: - when the stylesheet is loaded via @import (no event emitted) - when the stylesheet is duplicated in several link tags (too many events emitted) New tests are added to cover those use cases, which should all be fixed by Bug 1916960 on Firefox side. All the added tests already pass on Chrome canary. Differential Revision: https://phabricator.services.mozilla.com/D221685 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917805 gecko-commit: 26bbaffc60227b5aa78392429c957e8598aaf582 gecko-reviewers: webdriver-reviewers, arai, whimboo
Configuration menu - View commit details
-
Copy full SHA for 208ae71 - Browse repository at this point
Copy the full SHA 208ae71View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbf917c - Browse repository at this point
Copy the full SHA cbf917cView commit details -
Vertical Mongolian text takes underline on the right, like Japanese &…
… Korean. Differential Revision: https://phabricator.services.mozilla.com/D222809 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919812 gecko-commit: 3acdba1ef9f0314ae7a2f52985dd2f6c61a5bab8 gecko-reviewers: layout-reviewers, emilio
Configuration menu - View commit details
-
Copy full SHA for 49a18f3 - Browse repository at this point
Copy the full SHA 49a18f3View commit details -
[anchor] Implement tree-scoped 'all' for anchor-scope
This introduces tree-scoped keywords (not custom idents) for the first time. To not waste memory, we keep CSSIdentifierValue as a tree-scope- agnostic value, and instead use the new CSSScopedKeywordValue whenever a tree-scoped keyword is needed. Fixed: 368034380 Change-Id: Ib64d1acaf660e2ce6a1357be3cbe8a62e3655978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872877 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358734}
Configuration menu - View commit details
-
Copy full SHA for 711b84c - Browse repository at this point
Copy the full SHA 711b84cView commit details -
Back out changeset 6ff3f1fba36f because it is incorrect per spec.
This is unfortunately incorrect, it means that: > AudioDecoder.isConfigSupport({codec: "flac", numberOfChannels: 1, sampleRate: 48000}); resolves to a promise that says that it isn't supported (and it should say yes). Unfortunately, audioDecoder-codec-specific.https.any.js lacked tests for those two codecs, and the tests added are incorrect. The spec for this is: https://w3c.github.io/webcodecs/#check-configuration-support, and the check is intentionally not very thorough: this method is meant to know if this implementation generally supports a codec, not to check if configure(...) will success with very specific parameters. In general, isConfigSupported is done ahead of downloading any media content, so we don't have a description here. Differential Revision: https://phabricator.services.mozilla.com/D221510 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917629 gecko-commit: 6d6a00c29a87857dee38383c3ea44df6840de1ba gecko-reviewers: chunmin
Configuration menu - View commit details
-
Copy full SHA for a7e8867 - Browse repository at this point
Copy the full SHA a7e8867View commit details -
Properly check for description presence for flac and vorbis.
Configure need to error out if there's no description, but isConfigSupported should say true. Differential Revision: https://phabricator.services.mozilla.com/D221656 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917629 gecko-commit: a6af9793cee645db3af42b0078b73082b64cac17 gecko-reviewers: chunmin
Configuration menu - View commit details
-
Copy full SHA for b4bd6bc - Browse repository at this point
Copy the full SHA b4bd6bcView commit details -
Use marionette new window command to open wptrunner windows
Differential Revision: https://phabricator.services.mozilla.com/D23972 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1522790 gecko-commit: ed9818780499bbba8c5b606bd2632985ee3e5991 gecko-reviewers: jgraham
Configuration menu - View commit details
-
Copy full SHA for d2cb1d4 - Browse repository at this point
Copy the full SHA d2cb1d4View commit details -
[wpt] Fix intermittent test failures for short timer.
Depends on D23972 Differential Revision: https://phabricator.services.mozilla.com/D204234 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1522790 gecko-commit: d099e86e9a3f35890fbec91fef48fc0115f03480 gecko-reviewers: whimboo
Configuration menu - View commit details
-
Copy full SHA for f161ff1 - Browse repository at this point
Copy the full SHA f161ff1View commit details -
[wptrunner] Fix MarionetteWindowProtocolPart.set_rect() for optional …
…arguments. Depends on D206622 Differential Revision: https://phabricator.services.mozilla.com/D206623 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1522790 gecko-commit: 91d70d27459b254b2b9d8cf4b610c09e593ef369 gecko-reviewers: jgraham
Configuration menu - View commit details
-
Copy full SHA for 108fe0e - Browse repository at this point
Copy the full SHA 108fe0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1700d34 - Browse repository at this point
Copy the full SHA 1700d34View commit details -
[wdspec] Updated tests for perform actions to check for "move target …
…out of bounds" errors. Differential Revision: https://phabricator.services.mozilla.com/D220937 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1904665 gecko-commit: ec79322c670d30da20483ab27eea6820a944ec1b gecko-reviewers: webdriver-reviewers, jdescottes
Configuration menu - View commit details
-
Copy full SHA for 18a64e2 - Browse repository at this point
Copy the full SHA 18a64e2View commit details -
Backed out 5 changesets (bug 1915798, bug 1904665) for causing wpt fa…
…ilures related to ValueError: Selector. CLOSED TREE Backed out changeset d0e02650c62f (bug 1915798) Backed out changeset f971ce67915c (bug 1915798) Backed out changeset d20f091c1aab (bug 1904665) Backed out changeset ec79322c670d (bug 1904665) Backed out changeset 046e38921371 (bug 1904665) gecko-commit: c6d992bc9d9c44e1933570703c8ca8f0b7ef39a8
Configuration menu - View commit details
-
Copy full SHA for d1a5cfc - Browse repository at this point
Copy the full SHA d1a5cfcView commit details -
[wdspec] Updated tests for perform actions to check for "move target …
…out of bounds" errors. Differential Revision: https://phabricator.services.mozilla.com/D220937 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1904665 gecko-commit: 56bcb0cc0d7f3bc2fd59229da70adff02fa403f8 gecko-reviewers: webdriver-reviewers, jdescottes
Configuration menu - View commit details
-
Copy full SHA for 11b560c - Browse repository at this point
Copy the full SHA 11b560cView commit details -
Test reference target usage via the options argument of attachShadow() (
#47914) * Test reference target usage via the options argument of attachShadow() * Code review * Lint * Code review * lint * Uncomment tests
Configuration menu - View commit details
-
Copy full SHA for 3f9ec61 - Browse repository at this point
Copy the full SHA 3f9ec61View commit details -
FLEDGE: WPT test beacon reporting and component loading
Change-Id: I0e58a853ae14c684083709a0207cce2e4b75fc03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5877773 Commit-Queue: Maks Orlovich <[email protected]> Reviewed-by: Russ Hamilton <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358814}
Configuration menu - View commit details
-
Copy full SHA for 754fa51 - Browse repository at this point
Copy the full SHA 754fa51View commit details -
[Interop] Deflake pointerevent_click_during_capture.html
The test has been flaking for the auxclick action where the middle-click drag is probably causing autoscroll in some platforms. This CL changes the action to use the right mouse button instead, after suppressing any context menu invocation. Bug: 40851596 Change-Id: I4e36b3aceb75d5edcbd0c9599ada9f7af9ef7b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873347 Commit-Queue: Mustaq Ahmed <[email protected]> Reviewed-by: Kevin Ellis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1358971}
Configuration menu - View commit details
-
Copy full SHA for 64995b3 - Browse repository at this point
Copy the full SHA 64995b3View commit details -
Speculativly test :has-slotted() (#47587)
* Speculativly test :has-slotted(), see: w3c/csswg-drafts#10586 * Speculatively test :has-slotted() flattened through multiple slot elements * Lint
Configuration menu - View commit details
-
Copy full SHA for 43f3ba0 - Browse repository at this point
Copy the full SHA 43f3ba0View commit details -
[wpt] Refactor test "event-handler-onmove-02.tentative.html" and upda…
…te expectation for Android. Differential Revision: https://phabricator.services.mozilla.com/D223085 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920301 gecko-commit: 84ea7ef6f9b052ffa607bac7a02f6d709eba8972 gecko-reviewers: jgraham
Configuration menu - View commit details
-
Copy full SHA for 36b962f - Browse repository at this point
Copy the full SHA 36b962fView commit details -
Part 6 - Adjust test expectations for
anchor-size
.1. WPT tests now accept `anchor-size()` property for sizing, inset, and margin properties [1]. 2. Adjust test expectations for `anchor-size()` fallbacks containing `anchor-size()` - This will need to be followed up once [2] is resolved. 3. Adjust expectations for devtools' auto-completion related mochitests. 4. We don't yet handle `anchor-size()` in `calc()`. [1] w3c/csswg-drafts#9827 [2] w3c/csswg-drafts#10831 Differential Revision: https://phabricator.services.mozilla.com/D222535 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1900232 gecko-commit: a0bc0fe119dd86f4c51d31d2aadfa20133e0f595 gecko-reviewers: firefox-style-system-reviewers, devtools-reviewers, nchevobbe, emilio
Configuration menu - View commit details
-
Copy full SHA for 888dcb0 - Browse repository at this point
Copy the full SHA 888dcb0View commit details -
Implement failure tests cases for the EC import operation (#48243)
This PR implements new tests for the import operation of the ECDH and ECDSA algorithms, defining failure test cases. Additionally, it applies some refactoring to the code already used for OKP keys.
Configuration menu - View commit details
-
Copy full SHA for 4f0be15 - Browse repository at this point
Copy the full SHA 4f0be15View commit details
Commits on Sep 24, 2024
-
DOM: Implement abortable async iterable Observables
The IteratorRecord#return() function exists as an optional method that sync and async iterator records can supply [1] [2]. They allow for the language, or any consumer of an iterable, to signal to the iterable that the consumer will stop consuming values prematurely (i.e., before exhaustion). This method must be invoked when the consumer aborts its subscription to an Observable that was derived from an iterable. The abort reason is supplied to the `return()` iterator function for completeness. This CL: 1. Adds tests for sync & async iterables 2. Implements this for async iterables A follow-up CL will implement this for sync iterables. The semantics are specified in WICG/observable#160. [1]: https://tc39.es/ecma262/#table-iterator-interface-optional-properties [2]: https://tc39.es/ecma262/#table-async-iterator-optional Bug: 40282760 Change-Id: Ie1091b24b233afecdec572feadc129bcc8a2d4d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5854985 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359083}
Configuration menu - View commit details
-
Copy full SHA for 83154d0 - Browse repository at this point
Copy the full SHA 83154d0View commit details -
Refactor selectlist tests [1/4]
This is a set of refactors that: 1. re-points existing WPTs and web_tests from <selectlist> to <select style="appearance:base". 2. renames tests from `-selectlist-` to `-select-` These are done in batches, to make the review task easier. One CL will re-point tests (without renaming them) and the next will do the rename. These are all in service of removing the <selectlist> prototype. Bug: 335458492 Change-Id: Ie8dfdc37f1c3a6323d526ca1979d315c111d93f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5857249 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359127}
Configuration menu - View commit details
-
Copy full SHA for 5657c2c - Browse repository at this point
Copy the full SHA 5657c2cView commit details -
Refactor selectlist tests [3/4]
This is a set of refactors that: 1. re-points existing WPTs and web_tests from <selectlist> to <select style="appearance:base". 2. renames tests from `-selectlist-` to `-select-` These are done in batches, to make the review task easier. One CL will re-point tests (without renaming them) and the next will do the rename. These are all in service of removing the <selectlist> prototype. Bug: 335458492 Change-Id: Iac8e531e0c3354e2637350218e6e4e43002f6747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5857251 Commit-Queue: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359131}
Configuration menu - View commit details
-
Copy full SHA for b95e357 - Browse repository at this point
Copy the full SHA b95e357View commit details -
WebNN: implement cumulativeSum for DirectML backend
This CL implements cumulativeSum for DirectML backend. This CL also adds some WPT conformance tests [1] to verify the implementation. [1]: https://learn.microsoft.com/en-us/windows/win32/api/directml/ns-directml-dml_cumulative_summation_operator_desc#examples Bug: 40206287 Change-Id: Id49674a854ee37240a593a4882893e75b0950a8f Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5850648 Commit-Queue: Bin Miao <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359137}
Configuration menu - View commit details
-
Copy full SHA for 14652f1 - Browse repository at this point
Copy the full SHA 14652f1View commit details -
Dispatch CookieChangeEvent asynchronously
Differential Revision: https://phabricator.services.mozilla.com/D223140 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920101 gecko-commit: 956e3824f9bc74fa76077d01fd870eb275f1ea13 gecko-reviewers: edgul
Configuration menu - View commit details
-
Copy full SHA for acec99e - Browse repository at this point
Copy the full SHA acec99eView commit details -
Improve WPT test coverage for CookieStore API
Differential Revision: https://phabricator.services.mozilla.com/D222963 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920104 gecko-commit: df1fc10f7b4d25524907e6682d39b1e0a7b7c8d5 gecko-reviewers: edgul, smaug
Configuration menu - View commit details
-
Copy full SHA for 266b949 - Browse repository at this point
Copy the full SHA 266b949View commit details -
[css-nesting] Keep parsing after {}-block for rules with invalid sele…
…ctor When encountering a rule with an invalid selector, we currently recover by consuming until the next semicolon, which isn't correct. Instead, we should simply do nothing, and keep parsing right after the {}-block. The spec used to be less clear about this, but at least at the time of writing, nothing invokes the skip-until-semicolon behavior except for rule preludes that look like custom properties. This CL fixes this issue by adding a `invalid_rule_error` out-param to ConsumeStyleRule. There are two other things that are worth noting: - The "consume a qualified rule" algorithm in the spec mentions a `nested` flag which modifies its behavior. This flag is actually equivalent to `semicolon_aborts_nested_selector` in our parser, so I've renamed this. - During handling of `custom_property_ambiguity`, nested=false case, we're supposed to consume a block, and do nothing. This can't be tested using CSSParserImpl's public API, since failing to consume a block there would just cause the next attempt at parsing a rule to consume an empty prelude (then the block). But I don't think we should rely on that, hence I'm using unit tests to cover that line. [1] https://drafts.csswg.org/css-syntax/#consume-qualified-rule Test: external/wpt/css/css-syntax/custom-property-rule-ambiguity.html Change-Id: I04dc0c3745be5eafe792fd6c40971545274d9794 Fixed: 343979378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5881815 Commit-Queue: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Steinar H Gunderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359288}
Configuration menu - View commit details
-
Copy full SHA for 8ae822f - Browse repository at this point
Copy the full SHA 8ae822fView commit details -
FSA: Remove all file entry removing cleanup in directory tests
Now that directory tests have a cleanup function builtin to clear up any files left behind, remove all the previous cleanup code that added this. Mostly a mechanical change of removing the test argument from these functions: - createEmptyFile - createDirectory - createFileWithContents - create_file_system_handles Verified that all these functions appear in directory_test. Bug: 346991169 Change-Id: I751cd6c3eb5292ac791de872a89abe195490c7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878964 Reviewed-by: Christine Hollingsworth <[email protected]> Commit-Queue: Nathan Memmott <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359545}
Configuration menu - View commit details
-
Copy full SHA for 4a381c7 - Browse repository at this point
Copy the full SHA 4a381c7View commit details -
[Digital credentials WPT] Fix non-fully-active test
This CL switches the test to use navigator.credentials instead of navigator.identity. navigator.credentials handles ScriptState::ContextIsValid() == false BUG=343991289 Change-Id: If04237247ada802b6cd2447bc6336422658a94c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5882341 Commit-Queue: Peter Kotwicz <[email protected]> Reviewed-by: Ken Buchanan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359564}
Configuration menu - View commit details
-
Copy full SHA for 2684c09 - Browse repository at this point
Copy the full SHA 2684c09View commit details -
[wpt] Ignore testdriver messages in
sandboxed_iframe.https.window.js
Fix two issues causing the test to fail spuriously upstream when run with WebDriver [0]: a. testdriver.js uses regular `postMessage()`/`onmessage` to communicate testdriver commands between the parent and child frames. Unfortunately, until [1] is resolved, tests that use `onmessage` need to be aware of this implementation detail and ignore the internal messages. b. The parent needs `testdriver(-vendor).js` too so that testdriver commands from the child frame are correctly pumped out [2] to the harness, which will send the WebDriver command. Content shell currently passes the test because its testdriver is backed by internal JS bindings that directly hook into the browser. [0]: https://wpt.fyi/results/serial/requestPort/sandboxed_iframe.https.window.html?run_id=5088854063448064 [1]: #48326 [2]: https://github.com/web-platform-tests/wpt/blob/8ae822f0/tools/wptrunner/wptrunner/testdriver-extra.js#L22 Bug: None Change-Id: Iddb130f92c1877e389a46cb89a35c21bbfd1b625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5888384 Reviewed-by: Jack Hsieh <[email protected]> Commit-Queue: Jonathan Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359563}
Configuration menu - View commit details
-
Copy full SHA for 50433bc - Browse repository at this point
Copy the full SHA 50433bcView commit details -
Fix <label>s for base-select custom <button>
This patch makes clicking on a label pointing to a base-select with an author provided <button> focus the <button>, just like it focuses the <select> element itself when there is no author provided <button>. Change-Id: I12355e223de996138b64d9d9b17b8226eea6e06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5879535 Reviewed-by: Traian Captan <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359568}
Configuration menu - View commit details
-
Copy full SHA for 47999dc - Browse repository at this point
Copy the full SHA 47999dcView commit details
Commits on Sep 25, 2024
-
[wpt] Fix
payment-extension-allowed-...
when run with WebDriverWhen the browsing context that loads testharness.js is cross-origin with the one that uses testdriver.js, a. Both must include `testdriver(-vendor).js`. b. Before using `test_driver`, the non-testharness context should `set_test_context()` so that actions are sent to the right window [0]. The actions are currently dropped, causing a timeout [1]. Content shell happened to pass this test anyway because its testdriver implementation hooks directly into the browser via internal JS bindings. [0]: https://web-platform-tests.org/writing-tests/testdriver.html#using-test-driver-in-other-browsing-contexts [1]: https://wpt.fyi/results/permissions-policy/payment-extension-allowed-by-permissions-policy-attribute.https.sub.html?run_id=5121684256587776&run_id=5170329056182272&run_id=5162177208254464&run_id=5118180100145152 Bug: None Change-Id: I38b7f97507e02f2c16769f7e8e66f83c9f8953f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5888751 Reviewed-by: Ari Chivukula <[email protected]> Commit-Queue: Jonathan Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359666}
Configuration menu - View commit details
-
Copy full SHA for f1e021e - Browse repository at this point
Copy the full SHA f1e021eView commit details -
Resolve relative colors for canvas 2d
In https://crrev.com/c/5825542 we deferred resolution of all relative colors until after parse time for compatibility with expectations on serialized values. Canvas 2d was still expecting these colors to be resolved at parse time. The fix is to adjust the code to expect and handle unresolved color functions. Bug: 368562233 Change-Id: Iaafcab7cd45c0222317fe84343e3139a76fb1315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5883454 Commit-Queue: Kevin Babbitt <[email protected]> Reviewed-by: Aaron Krajeski <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359669}
Configuration menu - View commit details
-
Copy full SHA for e3af2c7 - Browse repository at this point
Copy the full SHA e3af2c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a687e33 - Browse repository at this point
Copy the full SHA a687e33View commit details -
[wpt] Wait for
hit-test-transformed-inline.html
to load Ahem fontOn systems without preinstalled Ahem, the tests may run with the wrong font because `test()` immediately executes its function synchronously [0]. Wait for `ahem.css` to load the font (`promise_test()` waits for `promise_setup()` to resolve). [0]: https://web-platform-tests.org/writing-tests/testharness-api.html#test Fixed: 356714709 Cq-Include-Trybots: luci.chromium.try:mac13-wpt-chromium-rel Change-Id: I44a5444a64ba12e4dc67831bcce188d1e78751e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5889804 Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Morten Stenshorne <[email protected]> Auto-Submit: Jonathan Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359769}
Configuration menu - View commit details
-
Copy full SHA for 09d9132 - Browse repository at this point
Copy the full SHA 09d9132View commit details -
[anchor] Add tests for anchor-scope and :host/::slotted.
Fixed: 368982570 Change-Id: I4bec062e0ffa0fb2fc3385c3551c29fbeeb5b746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5886350 Commit-Queue: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359776}
Configuration menu - View commit details
-
Copy full SHA for 81aee9c - Browse repository at this point
Copy the full SHA 81aee9cView commit details -
Mark universal rules as covered by the universal bucket.
We earlier concluded marking universal rules automatically as covered wasn't worth it, but for the universal bucket, it makes more sense; it doesn't cost much (because we put fewer rules in the universal bucket), and it makes more selectors be considered easy. Especially the case “.foo *” is moderately common. This is generally imperceptible in our benchmarks, so it is mostly because it feels sane. It is, however, measurable in how many selectors in the style perftest go through the different paths: Entirely covered by bucketing: 20.5% → 22.2% Easy selectors: 34.7% → 34.8% Full selector checking: 44.7% → 43.0% This uncovered a bug where easy selector checking (and bucket trusting) would be inadvertently activated for the shadow host, even though it does not understand that it should be featureless. Properly disable it in those cases. Change-Id: Ieb09dd42c4594110d92a4eccb262302e8c0116c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5876029 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Steinar H Gunderson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359864}
Configuration menu - View commit details
-
Copy full SHA for 143c6c4 - Browse repository at this point
Copy the full SHA 143c6c4View commit details -
Support SVG resource documents for additional properties
Enables loading of SVG resource documents for the following properties: * clip-path, * fill, * marker-end, * marker-mid, * marker-start and * stroke Guarded by the SvgExternalResources flag. Bug: 40134477 Change-Id: I424ae27cfc84351e4e7c80dd14236b8c76e74e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490225 Commit-Queue: Fredrik Söderquist <[email protected]> Reviewed-by: Philip Rogers <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359887}
Configuration menu - View commit details
-
Copy full SHA for ab136b5 - Browse repository at this point
Copy the full SHA ab136b5View commit details -
[container-queries] Enforce independent formatting context for subgrid.
As part of crbug.com/355215704 we've weakened for containment requirements for container queries. We should however still enforce an independent formatting context for subgrid, as grid will pierce into subgrids, and can't support changing their style. Fixed: 369331413 Change-Id: I875f4095116f18f923a0c50c4bf1887c05cea4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5890347 Commit-Queue: Ian Kilpatrick <[email protected]> Reviewed-by: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359893}
Configuration menu - View commit details
-
Copy full SHA for 0c2d6e1 - Browse repository at this point
Copy the full SHA 0c2d6e1View commit details -
extend keepalive.any.js for workers.
Differential Revision: https://phabricator.services.mozilla.com/D220017 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1901761 gecko-commit: 252d40232d9bf901366531c24c8a8674d2adb81b gecko-reviewers: edenchuang
Configuration menu - View commit details
-
Copy full SHA for ffcb5e5 - Browse repository at this point
Copy the full SHA ffcb5e5View commit details -
[wpt] Fix
web-share/disabled...cross-origin...
when run with WebDriverSame fix as https://crrev.com/c/5888751: * The testharness.js context should also load `testdriver(-vendor).js`. * The child iframe should `set_test_context(parent)` to send its testdriver actions to the testharness context [0]. [0]: https://web-platform-tests.org/writing-tests/testdriver.html#using-test-driver-in-other-browsing-contexts Bug: None Change-Id: I34b159d13990c48ab9232267ae5e153e2a01187a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5889244 Auto-Submit: Jonathan Lee <[email protected]> Reviewed-by: Finnur Thorarinsson <[email protected]> Commit-Queue: Jonathan Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1359968}
Configuration menu - View commit details
-
Copy full SHA for a19eaaf - Browse repository at this point
Copy the full SHA a19eaafView commit details -
DOM: Support atomic moves across shadow boundary
Per discussion with DOM editors, we've resolved to enable this functionality. [email protected] Bug: 40150299 Change-Id: I9bdb577c7538ca9cfe7af95b6c66159ade8e0c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5891771 Reviewed-by: Noam Rosenthal <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1360104}
Configuration menu - View commit details
-
Copy full SHA for 093603b - Browse repository at this point
Copy the full SHA 093603bView commit details -
The <embed> element does not have to enforce layout when the type att…
…ribute is set to image According to the spec[1], the `<embed>` element represents nothing in those conditions: > The element has neither a src attribute nor a type attribute. > The element has a media element ancestor. > The element has an ancestor object element that is not showing > its fallback content. There is no requirement for `ImageType` to enforce layout in the spec. So removed the logic of forcing layout when `type` is set to `image`. This patch also moves "embed-represent-nothing-04.html" to "embed-in-object-fallback-image.html". And "embed-represent-nothing-04.html is failing in all browsers. According to the spec[2]: > If the data attribute is present and its value is not the empty > string, then: ... > Fallback: The object element represents the element's children. > This is the element's fallback content. If the `object` element does not have a `data` attribute, its children should be used as fallback content. The test case in "embed-represent-nothing-04.html", `object` does not have a `data` attribute, so it should fallback, show it's children. [1]: https://html.spec.whatwg.org/multipage/#the-embed-element [2]: https://html.spec.whatwg.org/multipage/#the-object-element Bug: 40780999 Change-Id: I86bcd3cfe68c3cbe882c02008770bd3330a56026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5877938 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Peng Zhou <[email protected]> Cr-Commit-Position: refs/heads/main@{#1360197}
Configuration menu - View commit details
-
Copy full SHA for 4ab2137 - Browse repository at this point
Copy the full SHA 4ab2137View commit details
Commits on Sep 26, 2024
-
Add a WPT testcase that triggers the crash here.
Differential Revision: https://phabricator.services.mozilla.com/D223577 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1885702 gecko-commit: 59ea08f1b99de38821e4cc52f10d0a3077a06988 gecko-reviewers: dholbert
Configuration menu - View commit details
-
Copy full SHA for 60a8f61 - Browse repository at this point
Copy the full SHA 60a8f61View commit details -
Fix marker-text-combine-upright.html.
This test was failing because Firefox sets white-space:pre on ::marker, but the reference wasn't taking it into account. So this patch just uses all:unset to undo whatever random things browsers may decide to set on ::marker. The case with a symbolic marker wasn't working either but I guess it's fine because browsers are allowed to paint an image of their choice so the interaction with text-combine-upright seems hard to tell. So I'm just removing that case. Differential Revision: https://phabricator.services.mozilla.com/D223646 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921113 gecko-commit: 12bf64fef14a73d5df0de2ba5876f3eeb28ec339 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for a9a398c - Browse repository at this point
Copy the full SHA a9a398cView commit details -
We need to create a deep clone of CountersAttachmentContext for each page, since we may have to discard the page layout in some cases and retry. Which means that we also need to roll back what was done to the counters. Page counters are rather special, when reset, they will obscure any counters in the document (rather than establishing a new scope). This even happens when incrementing page counters in some cases. Update CountersAttachmentContext to handle this. And, as always for block fragmentation, the out-of-flow layout code needs a little special-treatment. If out-of-flow elements causes additional pages to be created, we need to go back and reprocess all page counters. Bug: 40529222 Change-Id: I7c9c80114191ae760eab662ea7fd345237498945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887168 Reviewed-by: Daniil Sakhapov <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/main@{#1360458}
Configuration menu - View commit details
-
Copy full SHA for 6daf2c3 - Browse repository at this point
Copy the full SHA 6daf2c3View commit details -
Invalidate SVG resources after container query style recalc
Fixed: 367752728 Change-Id: Icc1c5cd150b405427198f5b049f227d9a7c44829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5889826 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Fredrik Söderquist <[email protected]> Cr-Commit-Position: refs/heads/main@{#1360503}
Configuration menu - View commit details
-
Copy full SHA for acde52a - Browse repository at this point
Copy the full SHA acde52aView commit details -
[css-scroll-snap-2] Make scroll-start-target single-param
Per the spec[1], this patch makes the scroll-start-target property take a single argument, and makes it no longer a shorthand. The syntax used to be: scroll-start-target: <block> <inline> where <block> and <inline> could be "auto" or "none", but it should now be: scroll-start-target: [auto|none] Follow-up work: Now that the property no longer differentiates the axes, each scroll-start-target is to be scrolled to in both axes. The CSSWG has resolved[2] to handle competing scroll-start-targets by scrolling to each one in reverse-DOM-order. This patch only handles the change in parsing, a follow-up patch will handle the resolution of competing targets. [1] https://drafts.csswg.org/css-scroll-snap-2/#scroll-start-target [2] w3c/csswg-drafts#10774 (comment) Bug: 40909052, 368038561 Change-Id: I2a773dd8d4291602c6b69f47e0e648fd8a28e1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5881188 Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1360557}
Configuration menu - View commit details
-
Copy full SHA for e2853e8 - Browse repository at this point
Copy the full SHA e2853e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed11dbe - Browse repository at this point
Copy the full SHA ed11dbeView commit details -
Add a crashtest for bug 1906727
Differential Revision: https://phabricator.services.mozilla.com/D223269 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920613 gecko-commit: f6b8445b91f54decc503f93c06aefd98e8193483 gecko-reviewers: peterv
Configuration menu - View commit details
-
Copy full SHA for f668923 - Browse repository at this point
Copy the full SHA f668923View commit details -
[webtransport] Suppress benign error from
StreamWriter.close()
(#48351Configuration menu - View commit details
-
Copy full SHA for 3429377 - Browse repository at this point
Copy the full SHA 3429377View commit details -
Refactor selectlist tests [4/4]
This is a set of refactors that: 1. re-points existing WPTs and web_tests from <selectlist> to <select style="appearance:base". 2. renames tests from `-selectlist-` to `-select-` These are done in batches, to make the review task easier. One CL will re-point tests (without renaming them) and the next will do the rename. These are all in service of removing the <selectlist> prototype. Fixed: 335458492 Change-Id: I7eb34f254d713fd3e9a0123812f831df832a45fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5857252 Commit-Queue: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1360756}
Configuration menu - View commit details
-
Copy full SHA for b1c4aff - Browse repository at this point
Copy the full SHA b1c4affView commit details -
Web platform tests for Fledge Deal support.
This tests that all of the following receive the expected reporting ids in every major scenario possible involving the `selectableBuyerAndSellerReportingIds`. These do not test anything with k-anon enforcement on, but a TODO was added for that. Bug: 356654297 Change-Id: Iaec6d54141abb33b0a43382736dc5d197d66f60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5868409 Reviewed-by: Orr Bernstein <[email protected]> Commit-Queue: Youssef Bourouphael <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/main@{#1360755}
Configuration menu - View commit details
-
Copy full SHA for 8d500ad - Browse repository at this point
Copy the full SHA 8d500adView commit details -
Implement toggle events for dialog elements
This patch implements beforetoggle and toggle events for dialog elements. See spec issue: whatwg/html#9733 Bug: 1521813 Change-Id: I56e38230663990c8f1ed8ecd9307a6a881372605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5238172 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Keith Cirkel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1360795}
Configuration menu - View commit details
-
Copy full SHA for 30fc634 - Browse repository at this point
Copy the full SHA 30fc634View commit details
Commits on Sep 27, 2024
-
[text-box-trim] Fix
text-box-trim-initial-letter-start-001-ref
This patch fixes the test to be interoperable. It turned out that the font size of raised initial letters is undefined[1], and implementations have different issues especially when using Ahem as a web font. To make this test focus on if the `text-box-trim` property trims the raised part, this patch fixes the ref file to compute the position dynamically. Locally tested on Blink and WebKit TP with `-webkit-` prefix added to the `initial-letter` property. [1] https://drafts.csswg.org/css-inline-3/#sizing-initial-letter Bug: 367766472, 40254880 Change-Id: Ia9a1aae881762f390967fc3b29b9ca33515e4d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5892982 Auto-Submit: Koji Ishii <[email protected]> Reviewed-by: Lingqi Chi <[email protected]> Commit-Queue: Lingqi Chi <[email protected]> Cr-Commit-Position: refs/heads/main@{#1360862}
Configuration menu - View commit details
-
Copy full SHA for 1dcbbf5 - Browse repository at this point
Copy the full SHA 1dcbbf5View commit details -
Scoped Custom Element Registry Define, Get, Etc (#46728)
* Scoped Custom Element Registry Define, Get, Etc Co-Authored-By: Keith Cirkel <[email protected]> * Scoped CE tests: use rAF instead of setTimeout to appease linter --------- Co-authored-by: Keith Cirkel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 51a20f3 - Browse repository at this point
Copy the full SHA 51a20f3View commit details -
Add test for a random floating-point number to make sure we create th…
…e transition for the custom properties. Differential Revision: https://phabricator.services.mozilla.com/D223629 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917331 gecko-commit: c969e2c6952e6bd4b9f7f1295f130d45d1377a61 gecko-reviewers: layout-reviewers, firefox-style-system-reviewers, emilio
Configuration menu - View commit details
-
Copy full SHA for 7961e6a - Browse repository at this point
Copy the full SHA 7961e6aView commit details -
Raise an exception in Canvas WPT generator for invalid uses of expected
The 'expected' param is currently only supported for non-grid testharness tests. This parameter adds an image to testharness test pages that can be used to visually compare the test results with the expectation. This image however isn't used by the test runner to automatically validate the test result. As such, its value is quite limited. Support for this parameter was therefore not extended to newer features like reference tests and variant tests. Bug: 364549423 Change-Id: I30a33dd3634cf0d4cd98cc71b224bcdd1b5de3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839991 Commit-Queue: Jean-Philippe Gravel <[email protected]> Reviewed-by: Andres Ricardo Perez <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361218}
Configuration menu - View commit details
-
Copy full SHA for 26851e3 - Browse repository at this point
Copy the full SHA 26851e3View commit details -
Add missing composite op in test 2d.layer.globalCompositeOperation
Bug: 40249439 Change-Id: I4227510647b9baf7471c4ccbb6116f1b6354a75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836573 Reviewed-by: Andres Ricardo Perez <[email protected]> Commit-Queue: Jean-Philippe Gravel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361229}
Configuration menu - View commit details
-
Copy full SHA for fdd3587 - Browse repository at this point
Copy the full SHA fdd3587View commit details -
Make ComputedValuesExt expose keywords for the sizing properties
This will allow callers to start obeying `min-content`, `max-content`, `fit-content` and `stretch` in follow-up patches. The old functionality is kept as deprecated methods that we should eventually remove. This patch has very little impact on the existing behavior, just some very minimal implementation of the keywords for css tables. This also overhauls fixed-layout-2.html since: - It had code that wasn't doing anything - It had wrong expecations in prose - The logic seemed broken in general - All browsers were failing one testcase Signed-off-by: Oriol Brufau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fd25aeb - Browse repository at this point
Copy the full SHA fd25aebView commit details -
DOM: Do not hide element nonce on atomic move
See https://docs.google.com/document/d/1qfYyvdK4zhzloABKeh0K1lHPm-SpnEcsWEE9UdDuoMk/edit for the list of insertion/removing hooks that are getting modified to support state preservation during a DOM move. Bug: 40150299 Change-Id: I6354f744169946caef2f7047190982e919d7af87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5891943 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361368}
Configuration menu - View commit details
-
Copy full SHA for a550d3f - Browse repository at this point
Copy the full SHA a550d3fView commit details -
move big endian 32-bit integer helper to MediaSourceUtil
Differential Revision: https://phabricator.services.mozilla.com/D223691 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919683 gecko-commit: 9b9da983e745350b06e9d8f08e8de6879d4f3f97 gecko-reviewers: media-playback-reviewers, padenot
Configuration menu - View commit details
-
Copy full SHA for 3c7a1ed - Browse repository at this point
Copy the full SHA 3c7a1edView commit details -
add a description to an optional assert
Differential Revision: https://phabricator.services.mozilla.com/D223692 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919683 gecko-commit: ae4b8df5ca2891f00d34bfb589ac07204421b687 gecko-reviewers: media-playback-reviewers, padenot
Configuration menu - View commit details
-
Copy full SHA for c4e6754 - Browse repository at this point
Copy the full SHA c4e6754View commit details -
keep the most recent video frame for presentation at video end or pause
ClearFutureFrames() is not required in MaybeResolveEndPromise() when the VideoQueue() is empty, because the queue is now not emptied until end of playback. An empty queue before end of playback means no frames have been set in the VideoFrameContainer. Differential Revision: https://phabricator.services.mozilla.com/D223694 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919683 gecko-commit: 899312c8f8609f09dc132d7d4695ff7f95aa38ad gecko-reviewers: media-playback-reviewers, padenot
Configuration menu - View commit details
-
Copy full SHA for 28c8249 - Browse repository at this point
Copy the full SHA 28c8249View commit details -
Do not dispatch a CookieChangeEvent for an already expired unknown co…
…okie Differential Revision: https://phabricator.services.mozilla.com/D223712 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920996 gecko-commit: cce647667216960dc6e6752acd863c53cb632ed6 gecko-reviewers: cookie-reviewers, valentin
Configuration menu - View commit details
-
Copy full SHA for 1e9ff2b - Browse repository at this point
Copy the full SHA 1e9ff2bView commit details -
Fix Selection-getComposedRanges.html error logs
There were a few error logs added by mistake: https://crrev.com/c/5744732 Removing them in this patch. Change-Id: Iaa44c35902cd6c23f7a50bbf1eef22ec6aa74bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5894158 Reviewed-by: Siye Liu <[email protected]> Commit-Queue: Siye Liu <[email protected]> Auto-Submit: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361373}
Configuration menu - View commit details
-
Copy full SHA for cf4c126 - Browse repository at this point
Copy the full SHA cf4c126View commit details -
Allow semicolons in pycairo snippets in the canvas WPT generator
Semicolons are actually allowed in Python, they are used to separate multiple statements specified on the same line: https://docs.python.org/3/reference/compound_stmts.html Bug: 364549423 Change-Id: I790a6275777fd83c0048ddeb3fe39854d576c1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5891425 Commit-Queue: Jean-Philippe Gravel <[email protected]> Reviewed-by: Andres Ricardo Perez <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361379}
Configuration menu - View commit details
-
Copy full SHA for a6337a9 - Browse repository at this point
Copy the full SHA a6337a9View commit details -
Add WPTs that RTCStats.timestamp is expressed in "Performance time".
For w3c/webrtc-pc#3005 Sadly Date.now() and performance.timeOrigin + performance.now() only diverge in edge cases (e.g. laptop going to sleep or wall clock changing while web page is still open?) so these WPTs may give false positives to Wall Clock implementations, but they will at least fail if clock is completely off and document correct behavior. The current implementation is wrong, but we still pass the test because of no divergence here. We need to exclude Windows at the moment though because some of its clocks has precision limitations (example: [1]) and there seems to be some mismatch between WebRTC's current clock impl and Performance that becomes visible in this WPT (just a few ms delta). [1] https://source.chromium.org/chromium/chromium/src/+/main:base/time/time.h;l=1180;drc=1a6106ec2fc932237359fe1f54334a66bc4886f1 Bug: chromium:369369568 Change-Id: Iad452519800aa4c41427317d29e4fb11235b2f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5887191 Commit-Queue: Henrik Boström <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361140}
Configuration menu - View commit details
-
Copy full SHA for e093609 - Browse repository at this point
Copy the full SHA e093609View commit details -
[wpt] Don't check resource timing for
testharness*.js
If the renderer process running `status-codes-create-entry.html` ran another testharness.js test before, the testharness scripts may be cached [0] and spuriously fail the assertion that their resource timing entries have positive duration. Ignore these scripts, since the `status-code.py?status=200` case provides the same coverage. [0]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc;l=1410;drc=87d2282f6ad2ab805f80761d08fc5cb1e129789d;bpv=0;bpt=0 Bug: None Change-Id: I3a37c69f7511727be9c9be2f943f090264736d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5893318 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Noam Rosenthal <[email protected]> Commit-Queue: Jonathan Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361388}
Configuration menu - View commit details
-
Copy full SHA for dbf4b1c - Browse repository at this point
Copy the full SHA dbf4b1cView commit details
Commits on Sep 28, 2024
-
Move code writing pycairo images to a global function
This will allow follow-up CLs to reuse this code for generating other images using pycairo. Bug: 364549423 Change-Id: I340bea1153a82145f06c859e44fc4828d9a38d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5891403 Reviewed-by: Andres Ricardo Perez <[email protected]> Commit-Queue: Jean-Philippe Gravel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361438}
Configuration menu - View commit details
-
Copy full SHA for 04fb624 - Browse repository at this point
Copy the full SHA 04fb624View commit details -
[ios] Fix users cannot select folder in document picker
Allow users to select folder in document picker when developers call `window.showDirectoryPicker()` from JavaScript side Bug: 1411704 Change-Id: I63ae14a7f233a7083d91b4e5b77e1808ac620f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5891832 Reviewed-by: Dave Tapuska <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Commit-Queue: Xiaobin Cui <[email protected]> Reviewed-by: Julie Jeongeun Kim <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361497}
Configuration menu - View commit details
-
Copy full SHA for 1359c8c - Browse repository at this point
Copy the full SHA 1359c8cView commit details -
Simplify the computation of CAPMIN
CAPMIN is the largest min-content contribution of the table captions. In Servo, the standard way to compute min/max-content contributions is `outer_inline_content_sizes()`, so just use that instead of reinventing the wheel. This also fixes cyclic percentages to resolve consistently with normal block boxes. Signed-off-by: Oriol Brufau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7943e5e - Browse repository at this point
Copy the full SHA 7943e5eView commit details
Commits on Sep 29, 2024
-
Allow setting selectorText to a relative selector, if nested.
Differential Revision: https://phabricator.services.mozilla.com/D223988 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921505 gecko-commit: 346c031436f9234bd6b2be889c856ba41483ad97 gecko-reviewers: dshin
Configuration menu - View commit details
-
Copy full SHA for 16d1706 - Browse repository at this point
Copy the full SHA 16d1706View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03c258e - Browse repository at this point
Copy the full SHA 03c258eView commit details
Commits on Sep 30, 2024
-
Fix some subtests in pseudo-classes-after-part.html.
Differential Revision: https://phabricator.services.mozilla.com/D224029 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921575 gecko-commit: 2fd253587d932b2b8d389b43b73d17374cd8a330 gecko-reviewers: dbaron, firefox-style-system-reviewers, zrhoffman
Configuration menu - View commit details
-
Copy full SHA for 6b7b634 - Browse repository at this point
Copy the full SHA 6b7b634View commit details -
Fix :granted selector never changing to false
Permission element now has the right style when the permission is revoked Bug: 347250842 Change-Id: I590ca83d8a244a27c153f3974b3c0230170fb09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5851072 Auto-Submit: Ravjit Uppal <[email protected]> Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Ravjit Uppal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361720}
Configuration menu - View commit details
-
Copy full SHA for 1ff0d85 - Browse repository at this point
Copy the full SHA 1ff0d85View commit details -
Cover changing content targetting :has-slotted and :has-slotted(...) (#…
…48317) * Cover changing content targetting :has-slotted and :has-slotted(...) * Diversify DOM interactions * Lint * Make test file "tentative" * Include missing `.shadowRoot`s * Split out functional :has-slotted() from non-functional :has-slotted * Correc titles and :has-slotted(div + div) test
Configuration menu - View commit details
-
Copy full SHA for d3ec111 - Browse repository at this point
Copy the full SHA d3ec111View commit details -
[line-clamp] [text-box-trim] Make
text-box-trim
work with `line-cla……mp: auto` When `text-box-trim: trim-end` is applied to an element with `line-clamp`, it should trim the last line before clamp. This was previously implemented when clamping by a determined number of lines, but not when clamping by a height. Since the trimming affects the height of the content, this should be taken into account when clamping. Therefore, in the initial layout pass that determines the number of lines that fit in that height, if `text-box-trim: trim-end` is set, then every line is trimmed as if it were the last line before clamp. However, since this might not be the actual last line before clamp, after laying out the line we make sure to increase the inflow position's logical block offset so that any further lines and boxes after it are set at the correct position. Bug: 40336192, 40254880 Change-Id: I7cb19ca7ebadcf60dec587b3f6cbbf7363f7e64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5893918 Commit-Queue: Andreu Botella <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361770}
Configuration menu - View commit details
-
Copy full SHA for 4800822 - Browse repository at this point
Copy the full SHA 4800822View commit details -
Make the "size" parameter a tuple in the canvas WPT generator config
This makes the size property hashable, which makes it possible to do `self._unique_param('size')` to get the size of the canvases in a variant grid and make sure all variant uses the same canvas size. YAML doesn't support tuple natively, so the property needs to be manually converted to a tuple. Bug: 364549423 Change-Id: I55540ff39807b6af851d629008a50f257eeda645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5894511 Reviewed-by: Andres Ricardo Perez <[email protected]> Commit-Queue: Jean-Philippe Gravel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361792}
Configuration menu - View commit details
-
Copy full SHA for 8642514 - Browse repository at this point
Copy the full SHA 8642514View commit details -
Add WPT for cross-partition Dedicated Worker/Shared Worker creation
Bug: 364318223 Change-Id: Ia4c068b1c635b9a146c38d2c5b4335f60f4d29c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5891937 Auto-Submit: Janice Liu <[email protected]> Commit-Queue: Janice Liu <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Reviewed-by: Andrew Williams <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361818}
Configuration menu - View commit details
-
Copy full SHA for 8b5024d - Browse repository at this point
Copy the full SHA 8b5024dView commit details -
network.https.window.html?11-15 failed due to harness error
Error message: Tried to run in a non-testharness window without a call to set_test_context setCookie uses a test driver call to delete the cookies. Set test context fixed the issue. Bug: 338066470 Change-Id: I334c3f422127b689434c117a8f949d3b80b6a402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5895659 Reviewed-by: Russ Hamilton <[email protected]> Commit-Queue: Weizhong Xia <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361833}
Configuration menu - View commit details
-
Copy full SHA for 4c897e8 - Browse repository at this point
Copy the full SHA 4c897e8View commit details -
Revise the behavior of wpt-tests when the embed element is not displayed
According to the spec[1], the `<embed>` element is said to be potentially active when is being rendered. > The element is being rendered, or was being rendered the last time > the event loop reached step 1. To ensure that the `<embed>` element does not fetch request when it is not displayed, include the embed-represent-nothing-04.html test case. According to the spec[2], the `<object>` element that is not rendered will not fetch request. > if the element is not being rendered, then jump to the step below > labeled fallback. > Fallback: The object element represents the element's children. In the `embed-in-object-fallback-2.html` test case, the `<object>` and `<embed>` element are not displayed, so no elements should be loaded. Remove `display: none` in this test case to test the `<embed>` element nesting inside the `<object>` element. `window.onload` is triggered until the embed object is finished loading. `embed-document-under-content-visibility-*` not determine whether the `<embed>` element is loaded. [1]: https://html.spec.whatwg.org/multipage/#the-embed-element [2]: https://html.spec.whatwg.org/multipage/#the-object-element Bug: 5877938 Change-Id: I722f86098aef108e39637da4ba79d7588c56b7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5898095 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Traian Captan <[email protected]> Commit-Queue: Peng Zhou <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361889}
Configuration menu - View commit details
-
Copy full SHA for 03e9fae - Browse repository at this point
Copy the full SHA 03e9faeView commit details -
[shared storage] Validate context (frame attached) for createWorklet()
Problem: `CheckBrowsingContextIsValid()` is done in all places except within createWorklet(). This could cause nullptr dereference error when attempting to GetSharedStorageDocumentService(). This CL adds/moves the check to AddModuleHelper() to cover createWorklet(). Bug: 368139440 Change-Id: Ied6fdbc0011f156229c3dc02a5e6bde244d508f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5893856 Commit-Queue: Yao Xiao <[email protected]> Reviewed-by: Cammie Smith Barnes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361896}
Configuration menu - View commit details
-
Copy full SHA for 7a36770 - Browse repository at this point
Copy the full SHA 7a36770View commit details -
createImageBitmap: Respect colorSpaceConversion for video
Plumb the parameter to reinterpret the video as being in sRGB from - blink::ImageBitmap::ImageBitmap (read from options) - blink::HTMLVideoElement::CreateStaticBitmapImage - blink::CreateImageFromVideoFrame - media::PaintCanvasVideoRenderer::Paint (via new parameter) Add a WPT test for this. For the WPT test, add a Display P3 mp4 and webm test video. (There exists a Rec2020 test video, but it is 10-bit, which has bugs on some platforms, and uses the Rec709 transfer function, which has different interpretations on all browsers). Bug: 362431889 Change-Id: I3c12eb720b927a8e6466ab35ae29a044342df123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878044 Reviewed-by: Dale Curtis <[email protected]> Reviewed-by: Fernando Serboncini <[email protected]> Commit-Queue: ccameron chromium <[email protected]> Cr-Commit-Position: refs/heads/main@{#1361907}
Configuration menu - View commit details
-
Copy full SHA for 8f6b76e - Browse repository at this point
Copy the full SHA 8f6b76eView commit details -
Hide the text fragment from Navigation and Resource Timing API.
Differential Revision: https://phabricator.services.mozilla.com/D222941 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919565 gecko-commit: 9b99c2cfd2dc055ddfdd2de8722b54e7158a5823 gecko-reviewers: dom-core, sefeng
Configuration menu - View commit details
-
Copy full SHA for 1abe296 - Browse repository at this point
Copy the full SHA 1abe296View commit details -
Position mprescripts at per MathML Core.
From [1]: > Place the mmultiscripts base and <mprescripts> boxes at inline offsets inline-offset and with their alphabetic baselines aligned with the alphabetic baseline. Also tweak subsup-6.html to compute bounding box of the <mprescripts> element at the time a test is run. Otherwise reflow due to resize of the `<div id="log">` element can make the test fail. [1] https://w3c.github.io/mathml-core/#base-with-prescripts-and-postscripts Differential Revision: https://phabricator.services.mozilla.com/D222614 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1909417 gecko-commit: fabc61dc18efed097d9d499406d12c2094b75772 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 87eb4ef - Browse repository at this point
Copy the full SHA 87eb4efView commit details
Commits on Oct 1, 2024
-
Update SW static routing API resource timing with worker prefix
This CL updates ServiceWorker static routing API resource timing information to add the `worker` prefix to the fields. Explainer: https://github.com/WICG/service-worker-static-routing-api/blob/main/resource-timing-api.md Bug: 41496865 Change-Id: I6f96b5aca0fdd389a04eb32bb77c39f010078109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5898207 Reviewed-by: Shunya Shishido <[email protected]> Reviewed-by: Takashi Toyoshima <[email protected]> Reviewed-by: Yoshisato Yanagisawa <[email protected]> Commit-Queue: Keita Suzuki <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362186}
Configuration menu - View commit details
-
Copy full SHA for bf3c9f7 - Browse repository at this point
Copy the full SHA bf3c9f7View commit details -
Support CSS width/height properties on MathML elements. (#48375)
This patch implements support for the width/height properties on MathML elements [1]. The general algorithm from the spec is as follows: (1) The outcome of the math layout is a "math content box". (2) The content box sets its size from computed width/height values. If auto, it's the one of the "math content box". This patch ignores percentage values for now [2] [3]. (3) math content box is shifted so that its inline-start and top edges aligns with the ones of the content box. There are exceptions elements like mfrac and munder/mover/munderover which instead horizontally center the math content box within the content box. For baseline adjustment, we follow what Chromium does, see [4]. (4) Padding+border are added around the content box. Note that we ignore the box-sizing property for now [5]. The patch essentially tweaks the various MathML layout algorithms to perform steps (3) and (4) before the calls to GetBorderPaddingForPlace and InflateReflowAndBoundingMetrics. [1] https://w3c.github.io/mathml-core/#layout-algorithms [2] w3c/mathml-core#76 [3] w3c/mathml-core#77 [4] w3c/mathml-core#259 [5] w3c/mathml-core#257 Below is more information about test coverage: - width-height-001: Verify that width, height, inline-size and block-size properties sets the size of the content box. This test used to verify they are ignored, this patch fixes the `<meta name="assert">` tag. It also adds a test for the case the specified size is smaller than the content (we force non empty descendants to make sure this content is large enough) and to verify the width is used for the preferred width. - width-height-002, width-height-003: These are reftests visually checking offsets of the math content box within a larger content box (specified by width/height) for the mtext, mrow, mpadded, mfrac, msqrt, mroot, in LTR/RTL modes. In particular they allow to verify some painted elements like fraction bar and radical symbols. - width-height-004: This test more directly checks that the math content box is horizontally centered within a larger content box for munder, mover, munderover and mfrac. This patch extends the test to cover the case when the math content box is wider (i.e. overflowing outside the content box) and removes unnecessary specified height. - width-height-005: New test for other layout algorithm that don't center the math content box, checking inline-start edges of children when a width is specified. We check both LTR/RTL modes and wider/narrower content boxes. - width-height-006: Same but checking the top edges for larger/smaller height and verifying that baseline is perserved. Differential Revision: https://phabricator.services.mozilla.com/D221436 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1916988 gecko-commit: dc848382811227e2f040f438794da638b8792f5b gecko-reviewers: emilio Co-authored-by: Frédéric Wang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ee06b94 - Browse repository at this point
Copy the full SHA ee06b94View commit details -
Update fetchStart in resource timing when cache is used
This CL updates fetchStart in resource timing when ServiceWorker static routing API resource timing is used with cache as the actual source type. This is to be compatible with other fields. Explainer: https://github.com/WICG/service-worker-static-routing-api/blob/main/resource-timing-api.md Bug: 41496865 Change-Id: I7c9b90f8be8cd7bef5d62edafb32b9f41448f18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900017 Reviewed-by: Takashi Toyoshima <[email protected]> Reviewed-by: Yoshisato Yanagisawa <[email protected]> Reviewed-by: Shunya Shishido <[email protected]> Commit-Queue: Keita Suzuki <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362229}
Configuration menu - View commit details
-
Copy full SHA for 47ff969 - Browse repository at this point
Copy the full SHA 47ff969View commit details -
compute pressure: Convert remaining web tests to test_driver
The purpose of this change is start using WebDriver and remove mock code. WebDriver commands for Compute Pressure are defined in https://www.w3.org/TR/compute-pressure/#automation In general, this involves renaming `*.any.js` tests to `*.window.js` ones to continue being able to test windows and dedicated workers from the same file (see README.md for a longer explanation of how this works around test_driver limitations) as well as replacing the mock PressureService calls with test_driver ones. While here, a few other changes had to be made: - compute_pressure_basic.https.window.js: Stop passing async functions to Promise constructors. async functions do not make much sense in this context, and we can just call reject() when some function calls fail and avoid having to explicitly wait for them because by the time we reach the PressureObserver callbacks they will by definition have finished running. - compute_pressure_rate_obfuscation_mitigation_not_triggered.https.window.js: The promise wrapping the majority of the test has been removed because it is not necessary. - compute_pressure_rate_obfuscation_mitigation_triggered.https.window.js: The wrapping promise has been removed for the same reason. The wait the code was structured also made the entire test exit early when resolve() was called, and we never got to test the loop conditions and the final assertion in this case. Now that we do, fix the checks in the loop (we need an AND, not an OR) and adjust the description of the final assert_true() call. Co-authored with [email protected] Bug: 347031400 Change-Id: I289292bd4d35f7f26d4531252e64c0aba571124e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5898734 Reviewed-by: Reilly Grant <[email protected]> Commit-Queue: Raphael Kubo Da Costa <[email protected]> Auto-Submit: Raphael Kubo Da Costa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362281}
Configuration menu - View commit details
-
Copy full SHA for 3b5b938 - Browse repository at this point
Copy the full SHA 3b5b938View commit details -
Reland "Reland "Reland "Service worker web platform tests."""
This change does not change the tests themselves but how we register service workers. Previously a page reload was needed in order to make get the service worker activated. This worked fine and passed all the chrome wpts, but not on firefox see here: https://github.com/web-platform-tests/wpt/runs/24793731783. This new change uses a different technique that is used by some tests in the wpt/service-workers/ directory. Specifically, changes to the registration include: - unregister all service workers before the tests start. - service workers, once activated, will use 'clients.claim()' so that clients loaded in the same scope do not need to be reloaded before their fetches will go through this service worker. (https://developer.mozilla.org/en-US/docs/Web/API/Clients/claim) - wait for the service worker to be activated AND wait for the service worker to be controlling the page (which seems to be a common problem: w3c/ServiceWorker#799 ) This reverts commit eba96feb09f5ed94a093d012956bae1dc72cb486. Reason for revert: Changed the way we register SW, see above. Original change's description: > Revert "Reland "Reland "Service worker web platform tests.""" > > This reverts commit 9bd67ed90e90d6a2c2134d26bb8bcc4cd9436b19. > > Reason for revert: Failing in some cases. > > Original change's description: > > Reland "Reland "Service worker web platform tests."" > > > > This reverts commit 93a580699ecf6d102a5853455b5faeceea4cd31e. > > > > Reason for revert: Removed the test case that times out, > > (the one that waits for the update url). > > > > Original change's description: > > > Revert "Reland "Service worker web platform tests."" > > > > > > This reverts commit 436f1b9f6153002fd41599d5d4ec8343cf930a43. > > > > > > Reason for revert: There are still timeouts in some tests > > > > > > Original change's description: > > > > Reland "Service worker web platform tests." > > > > > > > > This reverts commit 36a1c457dac0ecaa54c0553b28f67c0c61752494. > > > > > > > > Reason for revert: The test that looks for 'update-url.py' takes too long and therefore will require this test file to be part of slowTests > > > > > > > > Original change's description: > > > > > Revert "Service worker web platform tests." > > > > > > > > > > This reverts commit 63858f1b1ed058d07e73cebb0a98214aa2cfc715. > > > > > > > > > > Reason for revert: New test added; fails immediately on some bots. > > > > > > > > > > See > > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/38089/overview > > > > > for the first failures. (And consistently in subsequent builds) > > > > > > > > > > Original change's description: > > > > > > Service worker web platform tests. > > > > > > > > > > > > This tests that when an auction is ran, service workers do not intercept requests with URLs that are meant to be private. > > > > > > > > > > > > > > > > > > Bug: 293383734 > > > > > > Change-Id: I06858f7cae4794a35c045fb8dad30d6316a26ead > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5459094 > > > > > > Commit-Queue: Youssef Bourouphael <[email protected]> > > > > > > Reviewed-by: mmenke <[email protected]> > > > > > > Reviewed-by: Orr Bernstein <[email protected]> > > > > > > Cr-Commit-Position: refs/heads/main@{#1294960} > > > > > > > > > > Bug: 293383734 > > > > > Change-Id: I3431f0e45e65767ff1529002d8a2d14657d0cb5a > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5506634 > > > > > Auto-Submit: Ian Clelland <[email protected]> > > > > > Owners-Override: Ian Clelland <[email protected]> > > > > > Commit-Queue: Rubber Stamper <[email protected]> > > > > > Bot-Commit: Rubber Stamper <[email protected]> > > > > > Cr-Commit-Position: refs/heads/main@{#1295015} > > > > > > > > Bug: 293383734 > > > > Change-Id: I762dd50282f99617796df64d73a27d149cac0a86 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5512083 > > > > Commit-Queue: Youssef Bourouphael <[email protected]> > > > > Bot-Commit: Rubber Stamper <[email protected]> > > > > Reviewed-by: Orr Bernstein <[email protected]> > > > > Reviewed-by: mmenke <[email protected]> > > > > Cr-Commit-Position: refs/heads/main@{#1296948} > > > > > > Bug: 293383734 > > > Change-Id: I9b06c0453656aaa448d0030960a48fc264bcf867 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5515623 > > > Auto-Submit: Youssef Bourouphael <[email protected]> > > > Commit-Queue: Rubber Stamper <[email protected]> > > > Commit-Queue: mmenke <[email protected]> > > > Reviewed-by: mmenke <[email protected]> > > > Bot-Commit: Rubber Stamper <[email protected]> > > > Cr-Commit-Position: refs/heads/main@{#1297048} > > > > Bug: 293383734 > > Change-Id: I7ae169c2750432bb1cb9c1c340585dc27d8cd419 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5521778 > > Commit-Queue: Youssef Bourouphael <[email protected]> > > Bot-Commit: Rubber Stamper <[email protected]> > > Reviewed-by: mmenke <[email protected]> > > Reviewed-by: Orr Bernstein <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1298807} > > Bug: 293383734 > Change-Id: I182736b58e83dbe7fc2c5fc7e20a3e3f909772a2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526425 > Bot-Commit: Rubber Stamper <[email protected]> > Commit-Queue: Youssef Bourouphael <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1298902} Bug: 293383734 Change-Id: Ia501a6d9d06e72038b14b656c95f465cef373ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5886697 Commit-Queue: Youssef Bourouphael <[email protected]> Reviewed-by: mmenke <[email protected]> Reviewed-by: Orr Bernstein <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362382}
Configuration menu - View commit details
-
Copy full SHA for 840c572 - Browse repository at this point
Copy the full SHA 840c572View commit details -
DOM: Ensure form owner is reset during atomic move
Atomically moving an unassociated form whose ID matches a listed form element, closer to the listed form element (i.e., closer than its currently-associated form), resets the listed form element's form owner. [email protected] Bug: 40150299 Change-Id: I847aa75081f813c73506fc0789c19a22296cbf6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900117 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362388}
Configuration menu - View commit details
-
Copy full SHA for e9b8cd1 - Browse repository at this point
Copy the full SHA e9b8cd1View commit details -
Sync interfaces/ with @webref/idl 3.55.1 (#48404)
Co-authored-by: wpt-pr-bot <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2d7cf3 - Browse repository at this point
Copy the full SHA f2d7cf3View commit details -
Fix external/wpt/preload/prefetch-headers.https.html
prefetch-info.py takes the basename of the file parameter[1] to construct the path of the resource to use. Adding green.png to the same directory and removed the extra and unnecessary part of the file parameter. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/preload/resources/prefetch-info.py;l=34 Bug: None Change-Id: I62f3ab6d4e90c1ac0dbdbcd544625e7e3d443418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5898200 Auto-Submit: Weizhong Xia <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362439}
Configuration menu - View commit details
-
Copy full SHA for 442c1d5 - Browse repository at this point
Copy the full SHA 442c1d5View commit details -
Make the style setter public methods of
HTMLEditor
stop handling th……eir jobs if the editing host is `plaintext-only Unfortunately, (even tough we're the last implementor of this feature`,) there are not editing behavior tests in web-platform tests. Therefore, this patch creates new `plaintext-only` directory into `editing` and make the feature enabled in its `__dir__.ini` to check the implementing behavior with new tests. This patch also changes how to compute the editing host (whether using `<body>` or not when selection is outside it), but the new behavior (not limited in the `<body>`) should work fine in the most cases and I believe that it's better than current implementation in some methods. Note that Chrome considers whether the style should be updated or not with the closest inclusive ancestor of the **focus node** of `Selection`. However, it's odd and aligning to the behavior requires bigger change. Therefore, I'd like to implement this feature only with checking the focused editing host. Differential Revision: https://phabricator.services.mozilla.com/D223277 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920622 gecko-commit: e22a2bcef3024b1d2e78db9bba0a5db0387ba07f gecko-reviewers: m_kato
Configuration menu - View commit details
-
Copy full SHA for fc29986 - Browse repository at this point
Copy the full SHA fc29986View commit details -
Use typed promises in the generated bindings
Bug: 329702363 Change-Id: I584b2aea7755e8992a23e6d4675667e2dfbfc1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5381805 Reviewed-by: Maks Orlovich <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Commit-Queue: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362473}
Configuration menu - View commit details
-
Copy full SHA for 899f4ff - Browse repository at this point
Copy the full SHA 899f4ffView commit details -
Text Fragments: Fixed test to open link in new tab to work on MacOS a…
…nd moved it into mozilla-specific tests. Apparently, synthesizing a CTRL/CMD-Click does not work reliably in Chrome/Safari, therefore the test is moved to mozilla-only web-platform tests. Differential Revision: https://phabricator.services.mozilla.com/D219724 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1913935 gecko-commit: aaaf48d51fe5fd56e8e05ed25ffa46fb306352cb gecko-reviewers: dom-core, masayuki
Configuration menu - View commit details
-
Copy full SHA for 4b793b8 - Browse repository at this point
Copy the full SHA 4b793b8View commit details -
Fix WPT FileAPI/blob/Blob-slice.any.js
Differential Revision: https://phabricator.services.mozilla.com/D224067 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921684 gecko-commit: 2048e83afdf003fb0b9786c9ed1f9f6a82bd7473 gecko-reviewers: smaug
Configuration menu - View commit details
-
Copy full SHA for 04d2e6c - Browse repository at this point
Copy the full SHA 04d2e6cView commit details -
[wdspec] Add WebDriver BiDi tests to check queuing of actions.
Differential Revision: https://phabricator.services.mozilla.com/D220899 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1915798 gecko-commit: 2c80eec70b9b2151b287eaa3de93c85b9d2ef5a7 gecko-reviewers: webdriver-reviewers, jdescottes
Configuration menu - View commit details
-
Copy full SHA for 22623a0 - Browse repository at this point
Copy the full SHA 22623a0View commit details -
[FedCM] Remove call to delete_all_cookies
I added delete_all_cookies to delete state between tests. However, it does not work for that purpose because: - delete_all_cookies only clears cookie state, not other state - it only affects cookies for the currently loaded page, i.e. the RP. But we only set cookies for the IDP hosts. Delete it to avoid doing unnecessary work. This should also make it possible to manually run tests on wpt.fyi [email protected] Bug: 333599184 Change-Id: I02a0f40ff27bbfb605739d940b579e4677454622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900797 Commit-Queue: Christian Biesinger <[email protected]> Auto-Submit: Christian Biesinger <[email protected]> Commit-Queue: Yi Gu <[email protected]> Reviewed-by: Yi Gu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362480}
Configuration menu - View commit details
-
Copy full SHA for 819c975 - Browse repository at this point
Copy the full SHA 819c975View commit details -
createImageBitmap: Fuse all operations
Consider the function CropImageAndApplyColorSpaceConversion. This function has separate steps for: - Crops - Down-scale - Flip - Color-convert (ish) - Re-orient (maybe) - Multiply or un-multiply alpha - Up-scale These are all separate steps that take an input image and produce an output image. These operations can (almost) all be fused into a single blit. Add the function ApplyImageBitmapOptionsTransformsWithBlit to do this single blit. Move only one createImageBitmap path to this. Once all paths move to this, we will remove the functions FlipImageVertically, ScaleImage, ApplyColorSpaceConversion, BakeOrientation, MakeBlankImage, CropImageAndApplyColorSpaceConversion, and the guts of a handful of ImageBitmap::ImageBitmap instances (ImageData I'm looking at you). This happens to fix one WPT test. Add a bunch more sub-tests for that test (all other browsers pass that test, along with the new sub-tests). This does not handle the case of unpremultiplied alpha, and falls back to the old path. A similar unpremultiplied alpha path will be added. Bug: 40773069, 362431889 Change-Id: Id39ec3aaa5e9b373397b5932ffd31984bcc8c4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5890810 Commit-Queue: ccameron chromium <[email protected]> Reviewed-by: Fernando Serboncini <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362628}
Configuration menu - View commit details
-
Copy full SHA for 2bf79d5 - Browse repository at this point
Copy the full SHA 2bf79d5View commit details -
Add ::search-text getComputedStyle subtests
Add various ::search-text getComputedStyle subtests to match similar tests for other highlight pseudos. Change-Id: I5c8fbc6742167e5832d69208dddd9746f75365ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5899323 Reviewed-by: Stephen Chenney <[email protected]> Commit-Queue: Rob Buis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362666}
Configuration menu - View commit details
-
Copy full SHA for 260920b - Browse repository at this point
Copy the full SHA 260920bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86fb9e8 - Browse repository at this point
Copy the full SHA 86fb9e8View commit details -
[initial-letter] Fix positioning for raised/sunken initial letters
When the the `initial-letter` property[1] has its `size` larger than `sink`, the top of the initial letter glyph overhangs the top of the first line. Before this patch, the block-direction position of such initial letters were computed based on the actual size of the fragment. This patch changes it to the specified `size`, making it consistent across different font metrics. Note, the change to the positioning made two tests to hit existing issues in exclusion space in vertical flow. They are tracked at crbug.com/370423031. [1] https://drafts.csswg.org/css-inline-3/#sizing-drop-initials Bug: 370217727, 370423031 Change-Id: I24b8de13d1a76a27c30850297ca380f98f5021b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5896658 Commit-Queue: Kent Tamura <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362700}
Configuration menu - View commit details
-
Copy full SHA for a1f4bbf - Browse repository at this point
Copy the full SHA a1f4bbfView commit details
Commits on Oct 2, 2024
-
Support `:host:has()` case to check whether a shadow host element has a relationship between its shadow root node and shadow tree element: - w3c/csswg-drafts#10693 Normally, `:has()` checks relationship between its anchor element and the other elements in the same tree. But in `:host:has()` case, `:has()` checks relationship in the shadow tree of the anchor element. For example, `:host(.a):has(> div)` matches a shadow host element if the host has `a` class value and the shadow root of the host has a child div element. To cross tree boundary for testing selector and invalidating styles, this CL adds 'HasArgumentMatchInShadowTree' flag to the CSSSelector and sets the flag while parsing selectors. SelectorChecker and CheckPseudoHasArgumentTraversalIterator cross tree boundary for `:has()` argument test traversal if the flag is set. RuleInvalidationDataVisitor sets 'TreeBoundaryCrossing` invalidation-set flag for non-subject `:has()` if the flag is set. If StyleEngine reaches to a shadow host element while performing `:has()` invalidation, it invalidates the host element if the host is affected by `:has()` state change. Bug: 359758910 Change-Id: I69f0813deca4caefcff1f0b5ff8181ba67967a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839398 Commit-Queue: Byungwoo Lee <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362877}
Configuration menu - View commit details
-
Copy full SHA for b40c843 - Browse repository at this point
Copy the full SHA b40c843View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6ca36f - Browse repository at this point
Copy the full SHA a6ca36fView commit details -
[wdspec] Add tests for network events for cached javascript files.
Differential Revision: https://phabricator.services.mozilla.com/D224196 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1916977 gecko-commit: e90edd140de4427070c89c454e872f1a1034ea12 gecko-reviewers: webdriver-reviewers, jdescottes
Configuration menu - View commit details
-
Copy full SHA for 14d2ba6 - Browse repository at this point
Copy the full SHA 14d2ba6View commit details -
Avoid transaction complete event race condition.
Differential Revision: https://phabricator.services.mozilla.com/D223304 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920989 gecko-commit: 9b788d14998dee0c7ff23801251bc081eb0d0a96 gecko-reviewers: smaug, dom-storage-reviewers, janv, asuth
Configuration menu - View commit details
-
Copy full SHA for ad4ddb1 - Browse repository at this point
Copy the full SHA ad4ddb1View commit details -
[wdspec] Extend navigation tests for document.write in sandboxes.
Differential Revision: https://phabricator.services.mozilla.com/D222656 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1918288 gecko-commit: ae9c76aad44aadbc41f3711e61c146c92defb381 gecko-reviewers: webdriver-reviewers, jdescottes
Configuration menu - View commit details
-
Copy full SHA for cb10299 - Browse repository at this point
Copy the full SHA cb10299View commit details -
[wdspec] Update test network/add_intercept/contexts.py to use new tab…
… for each test Using a new_tab context for each and every test in the file should avoid side effects between tests. Differential Revision: https://phabricator.services.mozilla.com/D224118 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921767 gecko-commit: 0d6041f18ea1205cc0dbd9cb2fc54bb35ef66f44 gecko-reviewers: webdriver-reviewers, whimboo
Configuration menu - View commit details
-
Copy full SHA for f3219a5 - Browse repository at this point
Copy the full SHA f3219a5View commit details -
FLEDGE: always include testdriver-vendor along with testdriver
...since on some configurations that's what actually provides the implementation. Most of the places where we included testdriver we don't actually use it [1] (so we could get away with missing -vendor), but it's likely we will need it everywhere, so I think I would rather fix it than remove it. [1] It's only used for deleteAllCookies for now. Change-Id: Icf8f8e9f18cd08ce06b775412ccb08aa9153fe58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905378 Reviewed-by: mmenke <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363024}
Configuration menu - View commit details
-
Copy full SHA for 4fc96fb - Browse repository at this point
Copy the full SHA 4fc96fbView commit details -
CSS view transitions: non-normal implies containment
See w3c/csswg-drafts#10780 (comment) Bug: 369895168 Change-Id: I4c06f4c3fbf99f83f06390244a3d7d732c7ce287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901995 Reviewed-by: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363033}
Configuration menu - View commit details
-
Copy full SHA for 37b6a4d - Browse repository at this point
Copy the full SHA 37b6a4dView commit details -
Implement TextMetrics::getTextClusters()
This change creates a new API method for TextMetrics objects in Canvas, that returns the specific ranged split into its minimal grapheme clusters, i.e. the smallest units that make sense to render separately from the perspective of the user. The returned object, named TextCluster, contains all the information needed for it to be rendered and shaped in the same way as in the input given to `ctx.measureText()`. This includes the begin and end indices on the input string, x and y positions relative to the anchor point of the Canvas context when the text is measured, and the complete text to preserve the context needed to reshape the text exactly the same. The final optional parameter for `getTextClustersForRange()` is dictionary to specify the desired anchor point position for each cluster. This enables the API to adjust the returned x and y positions to a different align/baseline that the ones used when the text was measured. The new API was enabled under the `ExtendedTextMetrics` flag. The next CL in the stack creates a new method for the Canvas rendering context that enables the rending of TextCluster objects. Bug: 341213359 Change-Id: Ie668ec4a266d4b5a99443125c7099e6f72714f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839992 Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Andres Ricardo Perez <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363086}
Configuration menu - View commit details
-
Copy full SHA for 59b9b08 - Browse repository at this point
Copy the full SHA 59b9b08View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0b6a56 - Browse repository at this point
Copy the full SHA e0b6a56View commit details -
Make SVGImage::CurrentFrameHasSingleSecurityOrigin() less strict
The call to CheckLoaded() applies the restriction that the image must have completed loading before the overall check can be performed. This in turn means that callers ImageResourceContent::IsAccessAllowed() can only be safely do after the resource has finished loading. This clashes with all forms of progressive rendering of images. Drop the CheckLoaded() call since we've locked down the loading of subresources for SVGImage in a more thorough way since the check was added. This allows answering the security-origin query in a progressive way and avoids the crash in the referenced bug. Fixed: 366547215 Change-Id: I2adfe7b3406572f0e1b1a956ac6aa4bf50b19c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5892795 Reviewed-by: Philip Rogers <[email protected]> Commit-Queue: Fredrik Söderquist <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363100}
Configuration menu - View commit details
-
Copy full SHA for 0868167 - Browse repository at this point
Copy the full SHA 0868167View commit details -
Stylable select picker typeahead should focus
When the stylable select picker is open, type to search should focus but not select an option until the selection is confirmed. Fixed: 362922565 Change-Id: Ib351c57266fd7bedb98ff5b1f2c72bea455b3778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5902298 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Traian Captan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363185}
Configuration menu - View commit details
-
Copy full SHA for 31bb067 - Browse repository at this point
Copy the full SHA 31bb067View commit details -
Make BlobEvent::timecode as a difference from the first chunk of the …
…BlobEvent. spec, https://w3c.github.io/mediacapture-record/#dom-blobevent-timecode, said that the timecode is time delta from the first BlobEvent of this recorder. Here are issues and its discussion. w3c/mediacapture-record#222 w3c/mediacapture-record#223 Bug: 40247788 Change-Id: Ic9c74299230b9839578ca317fff056e7a1b26dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5631009 Commit-Queue: Sunggook Chue <[email protected]> Reviewed-by: Markus Handell <[email protected]> Reviewed-by: Gabriel Brito <[email protected]> Cr-Commit-Position: refs/heads/main@{#1362716}
Configuration menu - View commit details
-
Copy full SHA for 832a0a5 - Browse repository at this point
Copy the full SHA 832a0a5View commit details -
Implement :has-slotted pseudo class
This pseudo class matches the presence of assigned nodes in the slot element. https://drafts.csswg.org/css-scoping-1/#the-has-slotted-pseudo Bug: 369883705 Change-Id: I7c848204d7c39860f39fab19290ef366e94d0a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5899636 Reviewed-by: Joey Arhar <[email protected]> Reviewed-by: Luke <[email protected]> Auto-Submit: Keith Cirkel <[email protected]> Commit-Queue: Keith Cirkel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363222}
Configuration menu - View commit details
-
Copy full SHA for 9cfac91 - Browse repository at this point
Copy the full SHA 9cfac91View commit details -
[FedCM] Update wpt test to always show account chooser
With mediation optional, some tests may not show the account chooser which might affect certain functions in the tests. Bug: None Change-Id: Iaf53657f8b5a43c41157c721774ef828a1b7987f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905460 Commit-Queue: Yi Gu <[email protected]> Reviewed-by: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363235}
Configuration menu - View commit details
-
Copy full SHA for 1039c1a - Browse repository at this point
Copy the full SHA 1039c1aView commit details -
FLEDGE WPT: teach subordinate-frame to integrate with testdriver
Previously https://chromium-review.googlesource.com/c/chromium/src/+/5895659 fixed a few tests to do it by hand, but I want to do use testdriver in a lot more tests (e.g. to do attestation), so it makes more sense to have subordinate-frame set things up for it correctly just like it does for our own messages. Change-Id: I48604d1c99678fcfedf41e446ef7e16546a4c3b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905379 Reviewed-by: mmenke <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363240}
Configuration menu - View commit details
-
Copy full SHA for 6498db2 - Browse repository at this point
Copy the full SHA 6498db2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f15e421 - Browse repository at this point
Copy the full SHA f15e421View commit details -
[ExtendedTextMetrics] Fix mixed bidi caretPositionFromPoint
Mixed bidi text runs are always challenging when it comes to PositionFromOffset and related methods, because a particular location where the direction changes is the start of two runs or the end of two runs. The choice of which index to return depends on what the offset is going to be used for. This CL changes caretPositionFromPoint to adjust the position returned when at the end of a text run that does not match the overall text direction. The position is moved to a neighboring run to match the behavior of the DOM method, which in this case is also probably better for building selection and insert behavior. Fixed: 364332944 Change-Id: I742f567cdf0e9a116d5d430d47d952a0f7c04301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5889819 Reviewed-by: Andres Ricardo Perez <[email protected]> Commit-Queue: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363262}
Configuration menu - View commit details
-
Copy full SHA for f458a7d - Browse repository at this point
Copy the full SHA f458a7dView commit details -
[flex] Avoid layout when determining the intrinsic block-size.
https://chromium-review.googlesource.com/c/chromium/src/+/5749947 Did some changes to correctly call kContent & kIntrinsic within flex for the purposes of determining flex-basis. This uncovered a bug where we'd layout a flex-item (with an aspect-ratio, and a container-query container), and not correctly relayout when the size changed. This is the first part of the mitigation. E.g. when we have size containment we don't need to run layout to determine the intrinsic block-size. There is a set of other issues in this area. But this mitigates the regression for the moment. Bug: 370480725 Change-Id: I8301a424fca86392c2ec1a7cfcf867142e413b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901118 Commit-Queue: Ian Kilpatrick <[email protected]> Reviewed-by: David Grogan <[email protected]> Reviewed-by: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363322}
Configuration menu - View commit details
-
Copy full SHA for 5e053f0 - Browse repository at this point
Copy the full SHA 5e053f0View commit details -
[document pip] Use the same compatibility mode as the opener
Currently, document picture-in-picture windows use quirks mode by default, since they're just about:blank windows. This CL makes the pip document match the opener document's compatibility mode instead. WICG/document-picture-in-picture#128 https://groups.google.com/a/chromium.org/g/blink-dev/c/IR7qdNj4Zyw Bug: 370423046 Change-Id: Ib1a84947b2408ae0be236afc2173fbcb0f77b598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5900737 Reviewed-by: Frank Liberato <[email protected]> Commit-Queue: Tommy Steimel <[email protected]> Reviewed-by: Nate Chapin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363338}
Configuration menu - View commit details
-
Copy full SHA for 6a80672 - Browse repository at this point
Copy the full SHA 6a80672View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1796ea2 - Browse repository at this point
Copy the full SHA 1796ea2View commit details
Commits on Oct 3, 2024
-
Two tests were using await in a non-async function. And a test helper was using newAnonymousIframe which was updated at some point to newIframeCredentialless. Bug: 346991169 Change-Id: I4333b6abee03ed48cf0d10d3417a2c15fba06d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906718 Commit-Queue: Nathan Memmott <[email protected]> Reviewed-by: Ayu Ishii <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363384}
Configuration menu - View commit details
-
Copy full SHA for d22edce - Browse repository at this point
Copy the full SHA d22edceView commit details -
Revert "FSA: Fix more manual WPTs"
This reverts commit fe27a7828eb3902d1b12c05fd97d4e7e13c8554b. Reason for revert: Suspect of causing test failures: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/148853/ Original change's description: > FSA: Fix more manual WPTs > > Two tests were using await in a non-async function. And a test helper > was using newAnonymousIframe which was updated at some point to > newIframeCredentialless. > > Bug: 346991169 > Change-Id: I4333b6abee03ed48cf0d10d3417a2c15fba06d30 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906718 > Commit-Queue: Nathan Memmott <[email protected]> > Reviewed-by: Ayu Ishii <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1363384} Bug: 346991169 Change-Id: Ie3a3b3fea9a3a2f3a735e082c30e74e3be59c3f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906899 Auto-Submit: Luciano Pacheco <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Owners-Override: Luciano Pacheco <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363433}
Configuration menu - View commit details
-
Copy full SHA for 1da52c0 - Browse repository at this point
Copy the full SHA 1da52c0View commit details -
Revise the behavior of wpt-tests when the object element is not displ…
…ayed According to the spec[1], the `<object>` element that is not rendered will not fetch request. > if the element is not being rendered, then jump to the step below > labeled fallback. > Fallback: The object element represents the element's children. In the `object-in-object-fallback-2.html` test case, all `<object>` elements are not being displayed, so no elements should be loaded. Remove `display: none` in this test case to test the `<object>` element nesting inside the `<object>` element. Revise the `object-in-display-none-load-event.html` test case to ensure that the `object` element is not loaded. Bug: 40781343 Change-Id: I190c937dbe643f5d1502529f8a530687ed8fcb9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5904314 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Traian Captan <[email protected]> Commit-Queue: Peng Zhou <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363461}
Configuration menu - View commit details
-
Copy full SHA for 014117c - Browse repository at this point
Copy the full SHA 014117cView commit details -
Use longer animation durations in animation-display-lock.html to avoi…
…d intermittent failures on slow configurations. Before this change, some pieces of this test intermittently timed out or failed to run, in the more-heavyweight Firefox configurations (e.g. TSAN/ASAN, particularly with debugging enabled). These failures seem to be because the animation/transition durations in this test were too short, such that the animation/transition occasionally complete on their own before the test is ready for them to complete (i.e. before the test explicitly advances to the end of an animation by programmatically setting 'currentTime'). I can reproduce similar failures in release Firefox and Chrome builds if I simply reduce the animation/transition durations (from 1s to 0.1s), so I think these failures are an indication of a race condition in the test logic (a fragile dependency on the animation taking "long enough" that it won't complete on its own), rather than a browser bug. This patch attempts to avoid these intermittent failures by increasing the animation durations by 10x, so that they're much less likely to complete on their own. Note that the standard WPT test-timeout is 10s, so it's reasonable to expect that the test shouldn't take longer than that (and hence we won't accidentally let these animations play to completion before the test logic has a chance to advance them). This patch also updates the logic/expectations to account for the new duration. e.g. we now set currentTime to 19999 (19.999s) rather than 1.999 (1.99s), to advance to just before the end of the second repetition of our animation. And this means we'll be slightly further through the animation, so the test's assertions now expect an opacity of 0.9999 rather than just 0.999. Differential Revision: https://phabricator.services.mozilla.com/D224371 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1922353 gecko-commit: 438cafb138808a2b8f7921cd4abd89718a6c4c23 gecko-reviewers: boris
Configuration menu - View commit details
-
Copy full SHA for 38a49a2 - Browse repository at this point
Copy the full SHA 38a49a2View commit details -
Make
nsIFrame::PeekOffsetForCharacter
treat non-editable frames as ……non-selectable When `PeekOffsetForCharacter` find a non-editable content, it should never return the frame because user must want to move caret only in editable content when the previous position is editable. Additionally, when a non-selectable frame is skipped, caret will be moved enough, so it should not skip any editable content. Finally, the found frame may cause a line break. Therefore, this patch overwrites the result of `SelectablePeekReport::PeekOffsetForCharacter` from `FOUND` to `CONTINUE_UNSELECTABLE` when non-editable content is found. The remaining failures of the new WPT should be handled in bug 449685 because they are caused by no frame for invisible preceding/trailing white spaces around the block element boundary. Depends on D223909 Differential Revision: https://phabricator.services.mozilla.com/D224183 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921705 gecko-commit: 755750429ced683c63011ab7eee8672d52c45e5d gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 61bd3c8 - Browse repository at this point
Copy the full SHA 61bd3c8View commit details -
part 1: Make
HTMLEditor
paste/drop things as plaintext when `conten……teditable=plaintext-only Chrome sets `beforeinput.data` instead of `beforeinput.dataTransfer`, but Input Events Level 2 spec defines that browsers should set `dataTransfer` when **contenteditable** [1]. Therefore, the new WPT expects `dataTransfer`. However, it's unclear that the `dataTransfer` should have `text/html` or only `text/plain`. From web apps point of view, `text/html` data may make them serialize the rich text format to plaintext without any dependencies of browsers and OS. On the other hand, they cannot distinguish whether the user tries to paste with or without formatting when `contenteditable=true`. Therefore, I filed a spec issue for this. We need to be back later about this issue. 1. https://w3c.github.io/input-events/#overview 2. w3c/input-events#162 Differential Revision: https://phabricator.services.mozilla.com/D223908 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920646 gecko-commit: 2e3f866560e2c750fe1e4469b81d89f10bffc6a1 gecko-reviewers: m_kato
Configuration menu - View commit details
-
Copy full SHA for e0e8311 - Browse repository at this point
Copy the full SHA e0e8311View commit details -
part 2: Make
HTMLEditor
handleinsertHTML
as inserting plaintext ……converted from given source Differential Revision: https://phabricator.services.mozilla.com/D223909 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1920646 gecko-commit: 39f1a092f31fc2950ea974b4df5e8710f9bf500d gecko-reviewers: m_kato
Configuration menu - View commit details
-
Copy full SHA for 947f66f - Browse repository at this point
Copy the full SHA 947f66fView commit details -
Ugh Differential Revision: https://phabricator.services.mozilla.com/D224302 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1919031 gecko-commit: d8b7f10eb81d003d51523bbaea87ccc6b0b36abf gecko-reviewers: smaug
Configuration menu - View commit details
-
Copy full SHA for db4fbbb - Browse repository at this point
Copy the full SHA db4fbbbView commit details -
Fix bugs: closedPath doesn't work for open circle
We're currently drawing a full-sweep open arc (sweep angle = 360 or -360) and full-sweep closed arc with the same function SkCanvas::drawArc(), which only draws open arcs. So it incorrectly draws open arc for closed path. This cl fixes the issue by converting the full sweep open arc to skpath. Bug: 370690269 Change-Id: I7aee5f953d7d04b1ea73730a41c64cd86911746e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5889468 Reviewed-by: Florin Malita <[email protected]> Commit-Queue: Yi Xu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363662}
Configuration menu - View commit details
-
Copy full SHA for b45d67e - Browse repository at this point
Copy the full SHA b45d67eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b16716 - Browse repository at this point
Copy the full SHA 1b16716View commit details -
[Digital Credentials WPT Tests] Fix tests some more
This CL: - Changes the exception thrown when the digital credentials API is invoked when the page does not have transient user activation to NotAllowedError in order to match spec. - Reorders check for number of providers to after transient user activation check in order to match spec. - Makes allow-attribute.https.html test pass if the <iframe> does not have user activation. BUG=368070320 Change-Id: Iaa194da8d0a2a96d1fd40592dbe74e7bd7391bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5883276 Reviewed-by: Ken Buchanan <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Commit-Queue: Peter Kotwicz <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363719}
Configuration menu - View commit details
-
Copy full SHA for b43d0fb - Browse repository at this point
Copy the full SHA b43d0fbView commit details -
WebKit export: [WPT] video-rvfc/* tests are flakey due to unmuted aut…
…oplay policies in Safari (#48451) https://bugs.webkit.org/show_bug.cgi?id=280829
Configuration menu - View commit details
-
Copy full SHA for 0fbfc14 - Browse repository at this point
Copy the full SHA 0fbfc14View commit details -
[flex] Don't apply transferred min/max sizes.
https://chromium.googlesource.com/chromium/src/+/f357fe9f912bd1723fb73fdb693c6825dae23390 ... introduced a change where we applied the transferred min/max sizes to the inline min/max sizes. This was unintentional. The spec is unclear on this situation (after checking with the spec author), so filed an issue here: w3c/csswg-drafts#10997 We may change back again, but at least this brings us in-line with other browsers for the moment. Fixed: 368562235 Change-Id: I6f353e7d2e1ef0e1077af2b3b76c5f42632cc6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907910 Reviewed-by: David Grogan <[email protected]> Commit-Queue: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363796}
Configuration menu - View commit details
-
Copy full SHA for 2ef4a5b - Browse repository at this point
Copy the full SHA 2ef4a5bView commit details -
[flex] Fix line cross-size calculation with extreme baselines.
As pointed out in: WebKit/WebKit#31376 (comment) Blink/WebKit were doing something incorrect when a baseline was outside the border-box of a flex-item. This was because we were initializing max_major_descent and max_minor_descent to zero, instead of LayoutUnit::Min(), (similar to FlexLine::max_major_ascent_ FlexLine::max_minor_ascent_). This only occurs with a single item in a flex-line. Change-Id: I4f32eb912a07247d16231451ba63e7c7a75a8b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901280 Commit-Queue: Ian Kilpatrick <[email protected]> Reviewed-by: David Grogan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363827}
Configuration menu - View commit details
-
Copy full SHA for a860f3b - Browse repository at this point
Copy the full SHA a860f3bView commit details -
moveBefore: retain render-blocking state for styles and scripts
When an element is atomically moved, we don't need to reset its render-blocking state. This means that if it was blocking before and not yet loaded, it would continue to block rendering despite being re-added after the body is already seen by the parser. This currently does not include <link rel=expect>. Bug: 40150299 Change-Id: Id24cdb1df13760f02aea36193995f6480f4ed1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5903961 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363878}
Configuration menu - View commit details
-
Copy full SHA for 34ba8a3 - Browse repository at this point
Copy the full SHA 34ba8a3View commit details -
[WebVTT] Cues should use white-space:pre-line [WPT][WebVTT] Move some WebVTT rendering tests into the correct location https://bugs.webkit.org/show_bug.cgi?id=275616 https://bugs.webkit.org/show_bug.cgi?id=280436
Configuration menu - View commit details
-
Copy full SHA for a18606c - Browse repository at this point
Copy the full SHA a18606cView commit details
Commits on Oct 4, 2024
-
[css-scroll-snap-2] Resolve scroll-start-targets with reverse DOM order
Per CSSWG resolution[1], user agents should handle competing scroll-start-targets by scrolling to each target in reverse-DOM-order. This patch implements this and re-enables scroll-start-target tests. Note that, for now, we only need to store the scroll-start-target which is first-in-tree/DOM order and not the whole list. This is because when we scroll to the scroll-start-targets (in reverse DOM order) we're effectively only scrolling to the first-in-tree/DOM order scroll-start-target. Scrolling to each target will only have an effect when a "nearest" value is accepted by scroll-snap-align which will have the same effect as "nearest" in scrollIntoView. So for now we can keep track of just one element, the first in tree/DOM order. [1] w3c/csswg-drafts#10774 (comment) Bug: 40909052, 368038561 Change-Id: I029920bdb053ae258932e3e7579f28d8256baf70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5881923 Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1363980}
Configuration menu - View commit details
-
Copy full SHA for e87b420 - Browse repository at this point
Copy the full SHA e87b420View commit details -
Add cache-storage as a value of deliveryType in resource timing
This CL adds a new value |cache-storage| to the deliveryType field in resource timing. It is specified when the response comes from CacheStorage either via Fetch handler in the ServiceWorker or from the static routing API when the cache rule is specified and used. Explainer: https://github.com/WICG/service-worker-static-routing-api/blob/main/resource-timing-api.md Bug: 41496865 Change-Id: Iff62aa9394244f28d88cbc73a94ff87c6c3e56a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901298 Commit-Queue: Keita Suzuki <[email protected]> Reviewed-by: Takashi Toyoshima <[email protected]> Reviewed-by: Shunya Shishido <[email protected]> Reviewed-by: Yoshisato Yanagisawa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364026}
Configuration menu - View commit details
-
Copy full SHA for 72b510a - Browse repository at this point
Copy the full SHA 72b510aView commit details -
Add external wpt covering same-site subresources redirected to x-site
Bug: 370995015 Change-Id: I802c294b4e80501465b7f263fc055cb594290f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905045 Reviewed-by: Steven Bingler <[email protected]> Auto-Submit: Aaron Selya <[email protected]> Commit-Queue: Steven Bingler <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364062}
Configuration menu - View commit details
-
Copy full SHA for bac7c69 - Browse repository at this point
Copy the full SHA bac7c69View commit details -
Differential Revision: https://phabricator.services.mozilla.com/D224454 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917742 gecko-commit: 3cfe3a3a5f77dd80c63fab25d3cbc4123b18976a gecko-reviewers: gfx-reviewers, aosmond
Configuration menu - View commit details
-
Copy full SHA for 38d6fa7 - Browse repository at this point
Copy the full SHA 38d6fa7View commit details -
Add WPT testing AAC AudioDecoderConfig w/o description
Add a AAC-without-AudioDecoderConfig-description WPT for bug 1891082. Differential Revision: https://phabricator.services.mozilla.com/D221279 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917721 gecko-commit: c6f1b0c070ef8e32491c92dbec1f3a8ba4f96a24 gecko-reviewers: media-playback-reviewers, padenot
Configuration menu - View commit details
-
Copy full SHA for 230b6f5 - Browse repository at this point
Copy the full SHA 230b6f5View commit details -
Make AAC-w/o-description WPT a mozilla-specific WPT
Due to the ongoing discussion in issue 832 [1], which has not yet reached a consensus among all parties, the AAC-without-description WPT introduced in the previous patch should be relocated to the *mozilla* folder under WPT. This ensures that the test remains specific to Mozilla and avoids unintentionally causing failures in other browers' test suites. [1] w3c/webcodecs#832 Differential Revision: https://phabricator.services.mozilla.com/D222712 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917721 gecko-commit: c81481c06eac3165b72e7bb2c3040a48b3994a0a gecko-reviewers: media-playback-reviewers, padenot
Configuration menu - View commit details
-
Copy full SHA for 799f501 - Browse repository at this point
Copy the full SHA 799f501View commit details -
part 1: Make
HTMLEditor
handleEnter
key press as `insertLineBrea……k` if it's in `contenteditable=plaintext-only Chrome treats `Enter` key press as `insertLineBreak` instead of `insertParagraph`. Additionally, Chrome handles `insertParagraph` command work as same as when `contenteditable=true`. Therefore, `HTMLEditor` needs to change the behavior at handling `eKeyPress` event. Depends on D224184 Differential Revision: https://phabricator.services.mozilla.com/D224185 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921162 gecko-commit: f38500099558322407170a7ce2fcc025594ad368 gecko-reviewers: m_kato
Configuration menu - View commit details
-
Copy full SHA for 4a7057f - Browse repository at this point
Copy the full SHA 4a7057fView commit details -
part 2: Add basic tests for
insertParagraph
in `contenteditable=pla……intext-only The behavior should be same as when `contenteditable=true`. Therefore, this test checks only the basic behavior. Differential Revision: https://phabricator.services.mozilla.com/D224186 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921162 gecko-commit: 3856ef423b913fce226ff04059fb818036ab9d36 gecko-reviewers: m_kato
Configuration menu - View commit details
-
Copy full SHA for 4c768ef - Browse repository at this point
Copy the full SHA 4c768efView commit details -
Consider a clip-path url() reference an empty clip while it's loading
While an external clip path is loading, we'll currently render as if no clip path is applied. Not applying a clip is what the spec prescribes for invalid references. While the resource is loading though, we shouldn't consider it invalid. Instead let an empty Path represent the external reference while it is loading. Fixed: 371112520 Change-Id: Icbdf1d6bf6f981f53c139df22d320b36afa1aab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905324 Reviewed-by: Philip Rogers <[email protected]> Commit-Queue: Fredrik Söderquist <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364171}
Configuration menu - View commit details
-
Copy full SHA for 7270b19 - Browse repository at this point
Copy the full SHA 7270b19View commit details -
Implement view-transition-name: auto
This allows generating view-transition-names automatically, reducing the burden of inventing unique names from the user, in cases where the element is the same (or has the same ID) between the two states. See spec PR: w3c/csswg-drafts#10922 Change-Id: I1b6c6752acc7106929b08ac6fcdda9578d6402d3 Bug: 365997248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5878355 Commit-Queue: Noam Rosenthal <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364180}
Configuration menu - View commit details
-
Copy full SHA for 1a1d4ed - Browse repository at this point
Copy the full SHA 1a1d4edView commit details -
DOM: Ensure atomic moves trigger relevant mutations
See https://docs.google.com/document/d/1qfYyvdK4zhzloABKeh0K1lHPm-SpnEcsWEE9UdDuoMk/edit and the discussion around <picture>, <source>, and <img> relevant mutations during atomic moves. [email protected] Bug: 40150299 Change-Id: I7c7de31da763efd9a17cf5258e1c4be9e54c907b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906482 Reviewed-by: Noam Rosenthal <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364197}
Configuration menu - View commit details
-
Copy full SHA for 9c629ec - Browse repository at this point
Copy the full SHA 9c629ecView commit details -
FLEDGE: Restore backwards compat on null on our Promise params
...after Chrome's WebIDL impl tightened up checking on those[1] (and pointed out that our spec is wrong on these, will work to update it after this CL). I am unsure as to what to do with resolvedToConfig, though; the behavior of it is very non-JS-like. [1] See https://chromium-review.googlesource.com/c/chromium/src/+/5381805 Change-Id: I92abd0bf34601333064b9e1c5b4a21ea4068754f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907125 Reviewed-by: Qingxin Wu <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364237}
Configuration menu - View commit details
-
Copy full SHA for 2ecd329 - Browse repository at this point
Copy the full SHA 2ecd329View commit details -
Style support for the CSS caret-animation property
Add the CSS caret-animation property, behind the CSSCaretAnimation runtime feature. The property does not have any effect yet. See https://chromestatus.com/feature/5082469066604544 Bug: 329301988 Change-Id: I1a9e33ad0f8f7b0e576157c6945227c6d14de86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905981 Commit-Queue: Stephen Chenney <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364320}
Configuration menu - View commit details
-
Copy full SHA for 4e74229 - Browse repository at this point
Copy the full SHA 4e74229View commit details -
compute pressure: Rewrite rate obfuscation web tests as unit tests
These tests have been flaky since they have been rewritten to use WebDriver (bug 347031400). https://crrev.com/c/5898989 added them to SlowTests, but that did not work: contrary to what I expected, marking a test as long in WPT's metadata and adding it to SlowTests are idempotent, not cumulative operations (i.e. I thought adding a test to SlowTests would increase the timeout even more, but it's just a no-op if the test is already marked as long). However, after investigating it further I believe this is not just a timeout problem: these tests cannot work anymore by definition. The idea of these tests is to send a number of updates and verify that: * Sending a number of updates smaller than the spec-defined threshold to trigger the mitigations causes the difference between PressureRecord.time in subsequent updates to be smaller than the penalty time. * Sending a number of updates greater than the spec-defined threshold does trigger the mitigation and cause update N within a spec-defined range to be sent with an implementation-defined delay. In all cases, we need to send an update to WebDriver and verify that PressureObserver has received it before sending the next one. Consequently, the time it takes between sending and receiving updates is actually outside the test's control: busy bots (such as the mac-rel and win-rel ones) can simply cause the web test to WebDriver or the WebDriver to browser process communication to take arbitrarily long, leading to: * Measured time between updates that should not trigger a penalty still taking longer than allowed because the system took too long to deliver the update_virtual_pressure_source() call. This causes the "not triggered" test to fail and leads to false positives in the "triggered" test. * Calls to update_virtual_pressure_source() taking too long to be on the browser side so that and/or too few updates being sent from the browser side while waiting under penalty so that the difference between the pre-penalty update's timestamp and the update-under-penalty's timestamp ends up being less than the minimum penalty time. This makes the "triggered" test never flip the |gotPenalty| flag to true. This was not a problem in the past because the MojoJS-based tests were restricted to Blink. The only way to have full control over the timing is to use unit tests where we can have a mock time source that we move forward as we see fit. Bug: 370726578, 347031400 Change-Id: I9b21513c7b8e83177e7d7b091607100d0cd21c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5909373 Reviewed-by: Reilly Grant <[email protected]> Auto-Submit: Raphael Kubo Da Costa <[email protected]> Commit-Queue: Reilly Grant <[email protected]> Commit-Queue: Raphael Kubo Da Costa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364368}
Configuration menu - View commit details
-
Copy full SHA for 5861fcc - Browse repository at this point
Copy the full SHA 5861fccView commit details -
Make WPT tests validating BeginLayerOptions filters tentative
The beginLayer's BeginLayerOption parameter was removed from the canvas layer PR at whatwg/html#9537. We might pursue this as a followup. In the meantime, the tests validating filters specified via BeginLayerOptions should be marked as tentative. Bug: 40249439 Change-Id: I3d9a009abc04658395b403a8752cf065644fc7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5903952 Reviewed-by: Andres Ricardo Perez <[email protected]> Commit-Queue: Jean-Philippe Gravel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364414}
Configuration menu - View commit details
-
Copy full SHA for 13948ad - Browse repository at this point
Copy the full SHA 13948adView commit details -
[Gap Decorations] Introduce CSS Value Repeat class
This CL introduces a data structure for parsing gap decoration properties such as color, style and width. It begins by introducing a new CSSValue (`CSSRepeatValue`) that will be used to represent the repeater notations for these properties and any future properties that use the same grammar. This CL also adds a VirtualTestSuite, css-gap-decoration, to exercise code added for the feature. Draft spec: https://kbabbitt.github.io/css-gap-decorations/#column-row-rule-color Bug: 357648037 Change-Id: I814bec63e289d2e670dea56248a0e8b734efcad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5856542 Reviewed-by: Kevin Babbitt <[email protected]> Commit-Queue: Sam Davis Omekara <[email protected]> Reviewed-by: Alison Maher <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364469}
Configuration menu - View commit details
-
Copy full SHA for 284ee60 - Browse repository at this point
Copy the full SHA 284ee60View commit details -
Remove obsolete checks for testdriver-internal messages (#48455)
No longer necessary after fixing #48326.
Configuration menu - View commit details
-
Copy full SHA for 6d6c302 - Browse repository at this point
Copy the full SHA 6d6c302View commit details -
Group WPT canvas layer clip tests together in the YAML file
The tests 2d.layer.clip-inside and 2d.layer.clip-inside-and-outside got separated from 2d.layer.clip-outside by a previous CL. This CL groups them together. The code is unchanged. Bug: 40249439 Change-Id: I369ddf194e2fadb2d2ee658ae86ffb5ddc0c9648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5910129 Reviewed-by: Andres Ricardo Perez <[email protected]> Commit-Queue: Jean-Philippe Gravel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364480}
Configuration menu - View commit details
-
Copy full SHA for 2bbd336 - Browse repository at this point
Copy the full SHA 2bbd336View commit details -
[line-clamp] Always clamp immediately after a line box
In our initial implementation of `line-clamp: auto`, we allowed clamping after lineless boxes, in order to better match the behavior of `line-clamp` as it follows from the spec's `continue: discard` model, even though our implementation uses a different model which is not yet in the specification (see w3c/csswg-drafts#7708). However, in hallway conversations in TPAC 2024, we agreed that it would be better for this model to instead only allow clamping immediately after a line. If the first line does not fit, we calmp at the first line even if that overflows the clamp height. If there are no lines, we do not clamp. This patch implements this. Additionally, a previous patch (https://crrev.com/c/5868971) had increased the memory size of `LineClampData` from 8 to 20 bytes, causing a memory regression. This patch shrinks it to 12 bytes, since `LineClampData` no longer needs to keep track of how many block boxes there are between the last line and the clmap point, and now OOFs after the clamped line behave the same when clamping by a number of lines or by a height, so there is no need for a flag to distinguish these behaviors. This patch also adds a size assertion for `LineClampData`. This patch also changes or removes some WPT tests that were written assuming the previous behavior. Bug: 40336192, 368114054 Change-Id: I8c8afebb5dc566de92112cee2fcf24a2e60b42c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5904459 Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Andreu Botella <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364495}
Configuration menu - View commit details
-
Copy full SHA for 1563c1e - Browse repository at this point
Copy the full SHA 1563c1eView commit details -
[A11y] Remove Accessibility Object Model (AOM)
Follow-ups will completely remove AccessibleNode, which is still used for its static methods for ARIA property retrieval in ordinary <div aria-foo> situations. Bug: 369945541 Change-Id: If4201088b86de9a88e1b611fae2e88a8ba3439ac Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5896593 Reviewed-by: Tzarial <[email protected]> Reviewed-by: Demetrios Papadopoulos <[email protected]> Reviewed-by: Richard (Torne) Coles <[email protected]> Reviewed-by: Nico Weber <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Alex Moshchuk <[email protected]> Reviewed-by: Mason Freed <[email protected]> Auto-Submit: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364497}
Configuration menu - View commit details
-
Copy full SHA for f368433 - Browse repository at this point
Copy the full SHA f368433View commit details
Commits on Oct 5, 2024
-
Ignore transform-origin and such shenanigans in SVGGeometryElement::L…
…ocalTransform. We don't want the offsetted matrix, just the actual transform matrix specified on the element. Differential Revision: https://phabricator.services.mozilla.com/D224217 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921662 gecko-commit: dd364824053b80e505688cfb4bf8a2f17b70019a gecko-reviewers: longsonr
Configuration menu - View commit details
-
Copy full SHA for e662078 - Browse repository at this point
Copy the full SHA e662078View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9448ab3 - Browse repository at this point
Copy the full SHA 9448ab3View commit details
Commits on Oct 6, 2024
-
Make
SelectionMovementUtils::GetFrameForNodeOffset
use last frame w……hen the loop ended with invisible content The editor in ChatGPT has only invisible `<br>` (`display: none`) and text content as `::after`. `SelectionMovementUtils::GetFrameForNodeOffset` assumes that at least one child has a primary frame. Therefore, it may return `nullptr` and `nsCaret` fails to paint the caret due to no frame. So, it should use a parent frame in such case. However, doing it may cause an assertion failure [1] when `IMEContentObserver::UpdateSelectionCache()` is called while an editor gets focus and the editor does not have visible children. Therefore, this patch makes it allow to flush pending notifications when it gets current selection range in the flattened text. Fortunately, this change does not make damage to the performance. I guess the reason is, sending focus notification synchronously will calling `ContentCacheInChild::CacheAll` soon. Then, it collects all information which should be cached in the parent process with flushing the pending layout. Therefore, this change should just do that a little bit faster than before. 1. https://searchfox.org/mozilla-central/rev/7e0ae4372c52b8183d1178132dd6493edb576738/layout/generic/nsIFrame.cpp#2039 Differential Revision: https://phabricator.services.mozilla.com/D224561 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921146 gecko-commit: 02bd95b16de9ef621d6b04626d655e3a346da296 gecko-reviewers: emilio
Configuration menu - View commit details
-
Copy full SHA for 11c6978 - Browse repository at this point
Copy the full SHA 11c6978View commit details
Commits on Oct 7, 2024
-
[text-box-trim] Disable if intervening padding or borders
This patch implements the spec[1]: > If there is no such line, or if there is intervening non-zero padding > or borders, there is no effect. The wpt tests: * text-box-trim-half-leading-block-box-004.html * text-box-trim-half-leading-block-box-005.html test this part, but there's an `outline` on the outer box, which is affected by the padding/border with negative margin. This patch fixes the test by adding a new reference file. [1] https://drafts.csswg.org/css-inline-3/#valdef-text-box-trim-trim-start Bug: 40254880, 359926563 Change-Id: Ic0f5317947155dd81d6afdc1d4505fe30c75cd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905670 Auto-Submit: Koji Ishii <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364798}
Configuration menu - View commit details
-
Copy full SHA for 3c28f7d - Browse repository at this point
Copy the full SHA 3c28f7dView commit details -
[bfcache]Add new AILanguageDetector* classes and functions
This CL adds new AILanguageDetector/AILanguageDetectorFactory/ AILanguageDetectorCapabilities classes to match the new version of API proposal[1]. Functions are mostly copied and pasted from the old version of the code. [1] https://github.com/WICG/translation-api?tab=readme-ov-file#full-api-surface-in-web-idl Bug: 349927087 Change-Id: I1eed4cb0d54e8388398aef642943c0d6a76857f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5892958 Reviewed-by: Fergal Daly <[email protected]> Commit-Queue: Yuzu Saijo <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364800}
Configuration menu - View commit details
-
Copy full SHA for f0df204 - Browse repository at this point
Copy the full SHA f0df204View commit details -
[initial-letter] Merge RTL tests into variants
Following up crrev.com/c/5896658, this patch merges RTL tests into wpt variants, so that the differences in the tests are more visible. Also removed a left over in `initial-letter-raise-initial-ref.html` that ran the script twice. This patch has no behavior changes. Change-Id: I0920c29f7f22aa25c487262be3232c95a28ef2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907026 Commit-Queue: Kent Tamura <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364811}
Configuration menu - View commit details
-
Copy full SHA for bac0059 - Browse repository at this point
Copy the full SHA bac0059View commit details -
[line-clamp] Fix bug when reusing line fragments with
line-clamp: auto
The patch at https://crrev.com/c/5868971 refactored `line-clamp: auto` to always do a first pass of layout to determine the number of lines before clamp, and then a second pass that behaves the same as clamping with a set number of lines. However, this patch introduced a bug where, if line fragments were reused from cache, the number of lines would decrease to match the number of reused lines in the second layout pass, but it would not increase by a corresponding amount in the first pass. This meant that the clamp point would happen at an unexpected place. This patch fixes this by adding a condition that checks whether we're in the first layout pass and incrasing the number of lines in that case. Bug: 40336192 Change-Id: I7dd339cd37cec3dde79d989b5b49d373387b99eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907101 Reviewed-by: Koji Ishii <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Andreu Botella <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364824}
Configuration menu - View commit details
-
Copy full SHA for a5cd1b0 - Browse repository at this point
Copy the full SHA a5cd1b0View commit details -
Add test cases covering 'position-anchor' corner cases. (#48496)
This change adds 2 reftests covering problems found during testing of recent WebKit. See https://bugs.webkit.org/show_bug.cgi?id=279588.
Configuration menu - View commit details
-
Copy full SHA for b3d2e16 - Browse repository at this point
Copy the full SHA b3d2e16View commit details -
Don't immediately type-check when converting a v8::Value into a Scrip…
…tPromise<> Typed promises in the generated bindings were introduced in https://chromium-review.googlesource.com/c/chromium/src/+/5381805. That CL converted to a rejected promise when the input value wasn't a promise and was the wrong type. This reverts to the old behavior of unconditionally wrapping the value in a resolved promise, and handling type checking in the reaction. Change-Id: I6c875be415bf62f2e7fdb9d1150f8deae5be0032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5908893 Reviewed-by: Maks Orlovich <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Auto-Submit: Nate Chapin <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364916}
Configuration menu - View commit details
-
Copy full SHA for 290c27a - Browse repository at this point
Copy the full SHA 290c27aView commit details -
Align COOP noopener-allow-popups to spec changes (#48465)
This CL aligns the feature with the latest PR changes [1], ensuring that noopener-allow-popups=>same-origin-allow-popups are BCG swapping, and regular navigations from noopener-allow-popups to itself are not. [1] whatwg/html@0e6a6ba Change-Id: I0a91b2f00793ee074ef73d5a45c332bd917cca95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905066 Reviewed-by: Camille Lamy <[email protected]> Commit-Queue: Yoav Weiss (@Shopify) <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364118} Co-authored-by: Yoav Weiss <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c207a14 - Browse repository at this point
Copy the full SHA c207a14View commit details -
Update PublicKeyCredential.signalCurrentUserDetails() WPTs now that we can use `userName` and `userDisplayName` to verify changes. Bug: 361751877 Change-Id: Id34c9fac83298e03f2b28cebbd8ba9e557616744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5903836 Commit-Queue: Ken Buchanan <[email protected]> Auto-Submit: Nina Satragno <[email protected]> Reviewed-by: Ken Buchanan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365060}
Configuration menu - View commit details
-
Copy full SHA for 07001d0 - Browse repository at this point
Copy the full SHA 07001d0View commit details -
compute pressure: Increase timeouts and drop uses of t.step_wait()
- When we need to wait to verify that an update was _not_ sent, update the timeout from 1 second to 3 seconds (and mark tests with timeout=long). 1 second is sometimes too little for busy bots such as the mac-rel and win-rel ones, which can lead to flakiness or, in this case, updates not being delivered for the wrong reason (i.e. the browser process just has not had time to process the update_virtual_pressure_source() call). - Introduce a new SyncPressureObserver wrapper class that stores multiple pressure updates and allows users to synchronously wait for the next one using Promises. This is useful for tests that need to send and wait for multiple updates: instead of polling using t.step_wait(), these tests can just use this class to wait for a Promise to resolve when an update is delivered. Bug: 347031400 Change-Id: I7880577757d71678e612d912716f4f12020a5fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912856 Reviewed-by: Reilly Grant <[email protected]> Commit-Queue: Reilly Grant <[email protected]> Auto-Submit: Raphael Kubo Da Costa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365092}
Configuration menu - View commit details
-
Copy full SHA for 5f9ff49 - Browse repository at this point
Copy the full SHA 5f9ff49View commit details -
Fix effect tree for custom scroll corners
We override the effect node when painting scrollbars for a view transition but erroneously missed doing it for custom scrollbars. Fix that. Fixed: 363544341 Change-Id: I13d2ad8b96df107e015c1e8caec1d081e77b65b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5913839 Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365167}
Configuration menu - View commit details
-
Copy full SHA for 5d14fa9 - Browse repository at this point
Copy the full SHA 5d14fa9View commit details -
Check for correct Sec-Fetch-Dest in Speculation Rules header tests
Bug: 40263108 Change-Id: I75d71ccdb3baaceb915b8c522660a7faf2619fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5913365 Reviewed-by: Liviu Tinta <[email protected]> Auto-Submit: Kevin McNee <[email protected]> Commit-Queue: Liviu Tinta <[email protected]> Commit-Queue: Kevin McNee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365178}
Configuration menu - View commit details
-
Copy full SHA for 03f9fe8 - Browse repository at this point
Copy the full SHA 03f9fe8View commit details -
This aligns with our behavior and Chrome's. Colors generally serialize to their resolved form in getComputedStyle(), and we only preserve keyword colors during parsing for legacy reasons (but this is not the case, because the transparent color comes from the engine). Differential Revision: https://phabricator.services.mozilla.com/D224760 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917052 gecko-commit: f84e7920a7cda35d340b4be1446b28674a6518de gecko-reviewers: dholbert
Configuration menu - View commit details
-
Copy full SHA for f27723c - Browse repository at this point
Copy the full SHA f27723cView commit details
Commits on Oct 8, 2024
-
[WebAudio]Re-Enable test of processing-after-resume test
The test often failed with different currentTime on audioContext and worklet. It is due to currentTime is captured for the worklet is made during its startup where it is always 0, meanwhile audioContext's is captured after its startup with running state. This fix consists in executing the test asserts after the AudioContext has been suspended for the first time. This ensures that the worklet's reported currentTime during its own initialization will also match the AudioContext's currentTime. Bug:40246707 Change-Id: I33403bdcd78918e61a462c2a0b1ec4d99f6b9562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906880 Reviewed-by: Michael Wilson <[email protected]> Commit-Queue: Sunggook Chue <[email protected]> Reviewed-by: Gabriel Brito <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365266}
Configuration menu - View commit details
-
Copy full SHA for 577cf22 - Browse repository at this point
Copy the full SHA 577cf22View commit details -
[CompositeClipPathAnimation] Patch value filter for custom property
This is a followup to a previous change that removed compositor keyframe snapshots for composited paint worklet animations. That changed allowed for changes in custom properties to result in the necessary paint invalidations for composited animations. Thus, the property filter for clip path animations can be amended to allow for custom property animations. Change-Id: I24941b2e6f705cb4342fdfdd8f9c62ef28a25519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5856667 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: Claire Chambers <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365289}
Configuration menu - View commit details
-
Copy full SHA for 98a100d - Browse repository at this point
Copy the full SHA 98a100dView commit details -
COOP noopener-allow-popups - Remove test line leftover (#48502)
[1] added tests, but in the process also added a spurious commented out line that ended up being tested as a browser test. This deletes it. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5905066 Bug: 344963946 Change-Id: Idb25ded0af9af81510c47d38d04ff98d1c658307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5913435 Reviewed-by: Fr <[email protected]> Commit-Queue: Yoav Weiss (@Shopify) <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364928} Co-authored-by: Yoav Weiss <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9596e6b - Browse repository at this point
Copy the full SHA 9596e6bView commit details -
Prerender: Add WPT for prerendering with sendBeacon()
This CL adds a new WPT to test sendBeacon() can be called during prerendering and onprerenderingchange, and after activation. Bug: 371971702 Change-Id: Icbc634ab58083e577a41fad4a473498a1f1271c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5914032 Reviewed-by: Lingqi Chi <[email protected]> Commit-Queue: Hiroki Nakagawa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365320}
Configuration menu - View commit details
-
Copy full SHA for 29458bf - Browse repository at this point
Copy the full SHA 29458bfView commit details -
webnn: add int4 and uint4 support for quantizeLinear and dequantizeLi…
…near This CL also adds some WPT conformance tests to verify the implementation. Bug: 40206287 Change-Id: Ieb8ce3ae2182388ae7cc98cd1fc8e3d2dcd9c7d2 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861613 Commit-Queue: Lisha Guo <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Reviewed-by: Rafael Cintron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365343}
Configuration menu - View commit details
-
Copy full SHA for 541cc2b - Browse repository at this point
Copy the full SHA 541cc2bView commit details -
Make letter-spacing accept <length-percentage>, not just <length>.
As per https://drafts.csswg.org/css-text-4/#letter-spacing-property. Differential Revision: https://phabricator.services.mozilla.com/D224747 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1884118 gecko-commit: 94d220f04c1c6cfb9a0c000c796e3ae6e26953fc gecko-reviewers: dshin
Configuration menu - View commit details
-
Copy full SHA for 310307d - Browse repository at this point
Copy the full SHA 310307dView commit details -
Add the error handling if the effective zoom is close to zero.
The zoom factor is stored as a fixed point number, and the effective zoom may be close to 0 (because we have to mulitply the zoom values of ancestors). So we have to make sure we don't divide by zero because the effective zoom could be zero. Differential Revision: https://phabricator.services.mozilla.com/D224551 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1922339 gecko-commit: 7ad44be1dfac1c831a3ed62658bb6dfc2851a70b gecko-reviewers: layout-reviewers, firefox-style-system-reviewers, emilio
Configuration menu - View commit details
-
Copy full SHA for 5ab6953 - Browse repository at this point
Copy the full SHA 5ab6953View commit details -
Make
HTMLEditor::ComputeEditingHostInternal
use common ancestor of ……all selection ranges Selection ranges can cross editing host boundaries if no editing host has focus. Therefore, `Selection.focusNode` may be in an editing host but there may be no active/focused editing host. The computation may be expensive if there are a lot of ranges and selecting in slotted shadow tree. However, it's rare case, so, I think it's okay for now. Differential Revision: https://phabricator.services.mozilla.com/D224282 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1922149 gecko-commit: 356daac9fcd1d2ded218db99afc3ae81ed8711ba gecko-reviewers: m_kato
Configuration menu - View commit details
-
Copy full SHA for 61e8b31 - Browse repository at this point
Copy the full SHA 61e8b31View commit details -
[css-typed-om] Avoid infinite recursion when serializing CSSUnparsedV…
…alue It's possible to create cyclic CSSUnparsedValues. This causes infinite recursion when serializing the value. The spec needs to say how this should be handled, but meanwhile, we handle the problem by serializing an empty string for cycles. Fixed: 371292572 Change-Id: I15ff38ff2b87eecec1f175d6aab7736dcf8091ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905363 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365367}
Configuration menu - View commit details
-
Copy full SHA for d09fd9e - Browse repository at this point
Copy the full SHA d09fd9eView commit details -
Bump docker/build-push-action from 6.3.0 to 6.9.0
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.3.0 to 6.9.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@1a16264...4f58ea7) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 638567e - Browse repository at this point
Copy the full SHA 638567eView commit details -
[nesting] Empty CSSNestedDeclarations should not affect outer cssText
It's possible to get empty CSSNestedDeclarations rules using CSSOM, and such rules serialize as the empty string. This causes "junk whitespace" in the serialization of outer rules, which is unattractive. The CSSOM spec was therefore recently changed to ignore child rules which serialize to empty strings. Bug: 343463516 Change-Id: I71738906b3b7979654bd0b723a57e048d6ce2195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901835 Reviewed-by: Steinar H Gunderson <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365466}
Configuration menu - View commit details
-
Copy full SHA for e1df2bd - Browse repository at this point
Copy the full SHA e1df2bdView commit details -
Implement keyword sizes on floats
Adds support for min-content, max-content, fit-content and stretch, for floated elements. Signed-off-by: Oriol Brufau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ec97938 - Browse repository at this point
Copy the full SHA ec97938View commit details -
Add a WPT test validating a canvas filter with a globalAlpha
The specification currently says that the globalAlpha should be applied on the result of the context's filter. This however leads to an unexpected behavior because if the filter is a drop-shadow, we can't see the shadow through the foreground even though the foreground is made transparent by the globalAlpha. This is not what Chrome and Firefox do. These browsers instead apply the globalAlpha on the source of the filter, therefore making the foreground transparent. The specification issue is addressed in: whatwg/html#10674 Change-Id: I3832c3cf6390933770a08669f62e9b1b29caccf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5904448 Reviewed-by: Aaron Krajeski <[email protected]> Commit-Queue: Jean-Philippe Gravel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365599}
Configuration menu - View commit details
-
Copy full SHA for ac35e3f - Browse repository at this point
Copy the full SHA ac35e3fView commit details -
Revert "webnn: add int4 and uint4 support for quantizeLinear and dequ…
…antizeLinear" This reverts commit 3a1707bcd20fa2fc4b1036755259ed01dc6632d5. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/4859941559992320 Sample build with failed test: https://ci.chromium.org/b/8734669715481467905 Affected test(s): [ninja://services:services_unittests/WebNNGraphImplTest.Resample2dTest](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fservices:services_unittests%2FWebNNGraphImplTest.Resample2dTest?q=VHash%3A447d241cfa07cbd2) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F4859941559992320&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5861613&type=BUG Original change's description: > webnn: add int4 and uint4 support for quantizeLinear and dequantizeLinear > > This CL also adds some WPT conformance tests to verify the > implementation. > > Bug: 40206287 > Change-Id: Ieb8ce3ae2182388ae7cc98cd1fc8e3d2dcd9c7d2 > Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861613 > Commit-Queue: Lisha Guo <[email protected]> > Reviewed-by: ningxin hu <[email protected]> > Reviewed-by: Alex Gough <[email protected]> > Reviewed-by: Rafael Cintron <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1365343} > Bug: 40206287 Change-Id: I32137439982a505b61de0a245a547067babcacb5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5915042 Reviewed-by: Mateusz Zbikowski <[email protected]> Commit-Queue: Mateusz Zbikowski <[email protected]> Owners-Override: Mateusz Zbikowski <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365509}
Configuration menu - View commit details
-
Copy full SHA for 12a8606 - Browse repository at this point
Copy the full SHA 12a8606View commit details