[pull] master from web-platform-tests:master #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…-001-ref.html Make the reference match the description in the reference file and the expected rendering described in the test.
Incorrect reference file when test was committed. Fixed: 366323411 Change-Id: Ie8b78494372cbcef376cebb225456be47481f5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5870457 Commit-Queue: Ian Kilpatrick <[email protected]> Reviewed-by: David Grogan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1356729}
Renaming MLOperandDescriptor.dimensions to MLOperandDescriptor.shape is proposed in this spec PR: webmachinelearning/webnn#676 To avoid breaking all uses of WebNN, this CL adds support for specifying 'shape' without removing support for 'dimensions'. Callers which pass 'dimensions' will see a console warning suggesting they update their code to use 'shape'. This CL was created primarily using targeted find-and-replaces, followed by running git cl format. This CL has no behavioral changes, other than the aforementioned logging. Bug: 365813262 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel Change-Id: I6b37ebc505a37686709f006b3ecafcefd3e2016d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502631 Reviewed-by: Reilly Grant <[email protected]> Commit-Queue: Austin Sullivan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1356886}
Functions were duplicated across test files. Change-Id: I61d7d03fb57547e8f0b52bc4d27e1efc4504280d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5869120 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Commit-Queue: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1356983}
Test that if the frame is 120x60 and restrictions are max 60x60 then the result is 60x30 as to maintain the original aspect ratio. Bug: chromium:363544347, webrtc:366067962 Change-Id: Ic6665871d6d9efde4726dd8a41631eca5ed8a7b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5853944 Commit-Queue: Henrik Boström <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1356990}
The Curve448 algorithms are not implemented in any of the major browsers, so it's better to define its import/export tests in separate files to avoid unnecessary noise on the tests for the Curve25519 algorithms.
This CL exposes the WebHID API to dedicated workers behind the blink runtime feature WebHIDOnDedicatedWorkers. Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/y__BOYfZWzI Spec PR: WICG/webhid#121 Spec issue: WICG/webhid#120 Demo: https://webhid-worker.glitch.me/ Change-Id: If145f34faf9211a54c8b4a15fbe7e903411b8d1d Bug: 365932453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5841991 Reviewed-by: Arthur Sonzogni <[email protected]> Reviewed-by: Yoav Weiss (@Shopify) <[email protected]> Reviewed-by: Matt Reynolds <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357046}
The Ed448 algorithm is not implemented in any of the major browsers, so it's better to define its sign / verify tests in a separate file to avoid unnecessary noise on the tests for the Ed25519 algorithm.
When `window.open` is performed with 'noopener' a null handle is returned regardless of whether the navigation succeeded. Bug: 359245744 Change-Id: I027e218b42936bdad5c0f4272f6a613978dc79de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5871987 Reviewed-by: Andrew Williams <[email protected]> Commit-Queue: Kyra Seevers <[email protected]> Reviewed-by: Kyra Seevers <[email protected]> Auto-Submit: Janice Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357219}
These two cases expect relative colors to be resolved at parse time when it's possible to do so. However, the rest of the cases in this test have been updated per w3c/csswg-drafts#10328 to expect declared values of relative colors to preserve their original forms. The cases tested that both rgb and color(srgb both result in color(srgb, but this is not valid any more for specified colors. We already have coverage of the same scenario for computed colors in color-computed-relative-color.html, so these subtests can be removed.
This CL updates the explanation for the edge case in FederatedAuthRequestImpl::CancelTokenRequest() and adds test which executes the edge case. BUG=40940748 Change-Id: I800959c721f13364801110eb20b1e1dff0b45059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5871992 Commit-Queue: Peter Kotwicz <[email protected]> Reviewed-by: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357306}
This CL also adds WPT and fixes a mojo comment format issue for scatterND. Bug: 363761938 Change-Id: Icaa6ba11943f7e89796f13b70e637c7ec496dd75 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5862351 Reviewed-by: Alex Gough <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Commit-Queue: ningxin hu <[email protected]> Reviewed-by: Rafael Cintron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357392}
This option was deprecated and has now been removed from recent versions of webkitgtk_minibrowser (which will cause the browser to not start if the option is given.)
Correct a mistake in 62fb506. The leading 0x00 bytes are wrong.
Bug: 367764865 Change-Id: I6bb49467bd273aa25fd9332a9e5e5d868bd86bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872842 Commit-Queue: Rune Lillesveen <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357517}
… navigables (#48260) Align with spec changes introduced in w3c/webdriver-bidi#770
This change adds support for `position: relative` to table `<caption>`. In addition to adjusting their position according to inset values, table captions must also establish containing blocks for descendants that are absolutely positioned. Co-authored-by: Oriol Brufau <[email protected]> Signed-off-by: Martin Robinson <[email protected]>
#47707) preparing for w3c/webrtc-extensions#214 ServiceWorker tests remain in webrtc-extensions for now
BUG=368070320 Change-Id: I4372915e9d661cd4c9905c020acc96d9f4cab975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873851 Reviewed-by: Nina Satragno <[email protected]> Commit-Queue: Peter Kotwicz <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357604}
The X448 algorithm is not implemented in any of the major browsers, so it's better to define its deriveBits / deriveKey tests in a separate file to avoid unnecessary noise on the tests for the X25519 algorithm.
Co-authored-by: wpt-pr-bot <[email protected]>
... with focus on single-party auctions. Change-Id: Ifb65d0b67ebf4293224bd8a12e9fa724b2320de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5866311 Reviewed-by: Russ Hamilton <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357738}
This CL also implements validation tests in WPT and corresponding `opSupportLimits`. webmachinelearning/webnn#375 (comment) Bug: 40206287 Change-Id: Ic184f2f45a9e201f12fd072675077511bfaec797 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5823074 Commit-Queue: Koji Ishii <[email protected]> Reviewed-by: Alex Gough <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Auto-Submit: Shiyi Zou <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357776}
…nnels. Differential Revision: https://phabricator.services.mozilla.com/D220431 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1915143 gecko-commit: 5e3767e9fcca6448d4c1161db2623405369f7f7f gecko-reviewers: chunmin
… & groupId of initial gUM call. Differential Revision: https://phabricator.services.mozilla.com/D220945 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1876636 gecko-commit: e85bbde80dd818783d861032877d45b5c59333a4 gecko-reviewers: karlt
No longer necessary after fixing #48326.
The tests 2d.layer.clip-inside and 2d.layer.clip-inside-and-outside got separated from 2d.layer.clip-outside by a previous CL. This CL groups them together. The code is unchanged. Bug: 40249439 Change-Id: I369ddf194e2fadb2d2ee658ae86ffb5ddc0c9648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5910129 Reviewed-by: Andres Ricardo Perez <[email protected]> Commit-Queue: Jean-Philippe Gravel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364480}
In our initial implementation of `line-clamp: auto`, we allowed clamping after lineless boxes, in order to better match the behavior of `line-clamp` as it follows from the spec's `continue: discard` model, even though our implementation uses a different model which is not yet in the specification (see w3c/csswg-drafts#7708). However, in hallway conversations in TPAC 2024, we agreed that it would be better for this model to instead only allow clamping immediately after a line. If the first line does not fit, we calmp at the first line even if that overflows the clamp height. If there are no lines, we do not clamp. This patch implements this. Additionally, a previous patch (https://crrev.com/c/5868971) had increased the memory size of `LineClampData` from 8 to 20 bytes, causing a memory regression. This patch shrinks it to 12 bytes, since `LineClampData` no longer needs to keep track of how many block boxes there are between the last line and the clmap point, and now OOFs after the clamped line behave the same when clamping by a number of lines or by a height, so there is no need for a flag to distinguish these behaviors. This patch also adds a size assertion for `LineClampData`. This patch also changes or removes some WPT tests that were written assuming the previous behavior. Bug: 40336192, 368114054 Change-Id: I8c8afebb5dc566de92112cee2fcf24a2e60b42c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5904459 Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Andreu Botella <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364495}
Follow-ups will completely remove AccessibleNode, which is still used for its static methods for ARIA property retrieval in ordinary <div aria-foo> situations. Bug: 369945541 Change-Id: If4201088b86de9a88e1b611fae2e88a8ba3439ac Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5896593 Reviewed-by: Tzarial <[email protected]> Reviewed-by: Demetrios Papadopoulos <[email protected]> Reviewed-by: Richard (Torne) Coles <[email protected]> Reviewed-by: Nico Weber <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Alex Moshchuk <[email protected]> Reviewed-by: Mason Freed <[email protected]> Auto-Submit: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364497}
…ocalTransform. We don't want the offsetted matrix, just the actual transform matrix specified on the element. Differential Revision: https://phabricator.services.mozilla.com/D224217 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921662 gecko-commit: dd364824053b80e505688cfb4bf8a2f17b70019a gecko-reviewers: longsonr
…hen the loop ended with invisible content The editor in ChatGPT has only invisible `<br>` (`display: none`) and text content as `::after`. `SelectionMovementUtils::GetFrameForNodeOffset` assumes that at least one child has a primary frame. Therefore, it may return `nullptr` and `nsCaret` fails to paint the caret due to no frame. So, it should use a parent frame in such case. However, doing it may cause an assertion failure [1] when `IMEContentObserver::UpdateSelectionCache()` is called while an editor gets focus and the editor does not have visible children. Therefore, this patch makes it allow to flush pending notifications when it gets current selection range in the flattened text. Fortunately, this change does not make damage to the performance. I guess the reason is, sending focus notification synchronously will calling `ContentCacheInChild::CacheAll` soon. Then, it collects all information which should be cached in the parent process with flushing the pending layout. Therefore, this change should just do that a little bit faster than before. 1. https://searchfox.org/mozilla-central/rev/7e0ae4372c52b8183d1178132dd6493edb576738/layout/generic/nsIFrame.cpp#2039 Differential Revision: https://phabricator.services.mozilla.com/D224561 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1921146 gecko-commit: 02bd95b16de9ef621d6b04626d655e3a346da296 gecko-reviewers: emilio
This patch implements the spec[1]: > If there is no such line, or if there is intervening non-zero padding > or borders, there is no effect. The wpt tests: * text-box-trim-half-leading-block-box-004.html * text-box-trim-half-leading-block-box-005.html test this part, but there's an `outline` on the outer box, which is affected by the padding/border with negative margin. This patch fixes the test by adding a new reference file. [1] https://drafts.csswg.org/css-inline-3/#valdef-text-box-trim-trim-start Bug: 40254880, 359926563 Change-Id: Ic0f5317947155dd81d6afdc1d4505fe30c75cd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905670 Auto-Submit: Koji Ishii <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364798}
This CL adds new AILanguageDetector/AILanguageDetectorFactory/ AILanguageDetectorCapabilities classes to match the new version of API proposal[1]. Functions are mostly copied and pasted from the old version of the code. [1] https://github.com/WICG/translation-api?tab=readme-ov-file#full-api-surface-in-web-idl Bug: 349927087 Change-Id: I1eed4cb0d54e8388398aef642943c0d6a76857f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5892958 Reviewed-by: Fergal Daly <[email protected]> Commit-Queue: Yuzu Saijo <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364800}
Following up crrev.com/c/5896658, this patch merges RTL tests into wpt variants, so that the differences in the tests are more visible. Also removed a left over in `initial-letter-raise-initial-ref.html` that ran the script twice. This patch has no behavior changes. Change-Id: I0920c29f7f22aa25c487262be3232c95a28ef2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907026 Commit-Queue: Kent Tamura <[email protected]> Auto-Submit: Koji Ishii <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364811}
The patch at https://crrev.com/c/5868971 refactored `line-clamp: auto` to always do a first pass of layout to determine the number of lines before clamp, and then a second pass that behaves the same as clamping with a set number of lines. However, this patch introduced a bug where, if line fragments were reused from cache, the number of lines would decrease to match the number of reused lines in the second layout pass, but it would not increase by a corresponding amount in the first pass. This meant that the clamp point would happen at an unexpected place. This patch fixes this by adding a condition that checks whether we're in the first layout pass and incrasing the number of lines in that case. Bug: 40336192 Change-Id: I7dd339cd37cec3dde79d989b5b49d373387b99eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907101 Reviewed-by: Koji Ishii <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Andreu Botella <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364824}
This change adds 2 reftests covering problems found during testing of recent WebKit. See https://bugs.webkit.org/show_bug.cgi?id=279588.
…tPromise<> Typed promises in the generated bindings were introduced in https://chromium-review.googlesource.com/c/chromium/src/+/5381805. That CL converted to a rejected promise when the input value wasn't a promise and was the wrong type. This reverts to the old behavior of unconditionally wrapping the value in a resolved promise, and handling type checking in the reaction. Change-Id: I6c875be415bf62f2e7fdb9d1150f8deae5be0032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5908893 Reviewed-by: Maks Orlovich <[email protected]> Reviewed-by: Andrey Kosyakov <[email protected]> Auto-Submit: Nate Chapin <[email protected]> Commit-Queue: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364916}
This CL aligns the feature with the latest PR changes [1], ensuring that noopener-allow-popups=>same-origin-allow-popups are BCG swapping, and regular navigations from noopener-allow-popups to itself are not. [1] whatwg/html@0e6a6ba Change-Id: I0a91b2f00793ee074ef73d5a45c332bd917cca95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905066 Reviewed-by: Camille Lamy <[email protected]> Commit-Queue: Yoav Weiss (@Shopify) <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364118} Co-authored-by: Yoav Weiss <[email protected]>
Update PublicKeyCredential.signalCurrentUserDetails() WPTs now that we can use `userName` and `userDisplayName` to verify changes. Bug: 361751877 Change-Id: Id34c9fac83298e03f2b28cebbd8ba9e557616744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5903836 Commit-Queue: Ken Buchanan <[email protected]> Auto-Submit: Nina Satragno <[email protected]> Reviewed-by: Ken Buchanan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365060}
- When we need to wait to verify that an update was _not_ sent, update the timeout from 1 second to 3 seconds (and mark tests with timeout=long). 1 second is sometimes too little for busy bots such as the mac-rel and win-rel ones, which can lead to flakiness or, in this case, updates not being delivered for the wrong reason (i.e. the browser process just has not had time to process the update_virtual_pressure_source() call). - Introduce a new SyncPressureObserver wrapper class that stores multiple pressure updates and allows users to synchronously wait for the next one using Promises. This is useful for tests that need to send and wait for multiple updates: instead of polling using t.step_wait(), these tests can just use this class to wait for a Promise to resolve when an update is delivered. Bug: 347031400 Change-Id: I7880577757d71678e612d912716f4f12020a5fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5912856 Reviewed-by: Reilly Grant <[email protected]> Commit-Queue: Reilly Grant <[email protected]> Auto-Submit: Raphael Kubo Da Costa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365092}
We override the effect node when painting scrollbars for a view transition but erroneously missed doing it for custom scrollbars. Fix that. Fixed: 363544341 Change-Id: I13d2ad8b96df107e015c1e8caec1d081e77b65b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5913839 Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365167}
Bug: 40263108 Change-Id: I75d71ccdb3baaceb915b8c522660a7faf2619fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5913365 Reviewed-by: Liviu Tinta <[email protected]> Auto-Submit: Kevin McNee <[email protected]> Commit-Queue: Liviu Tinta <[email protected]> Commit-Queue: Kevin McNee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365178}
This aligns with our behavior and Chrome's. Colors generally serialize to their resolved form in getComputedStyle(), and we only preserve keyword colors during parsing for legacy reasons (but this is not the case, because the transparent color comes from the engine). Differential Revision: https://phabricator.services.mozilla.com/D224760 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1917052 gecko-commit: f84e7920a7cda35d340b4be1446b28674a6518de gecko-reviewers: dholbert
The test often failed with different currentTime on audioContext and worklet. It is due to currentTime is captured for the worklet is made during its startup where it is always 0, meanwhile audioContext's is captured after its startup with running state. This fix consists in executing the test asserts after the AudioContext has been suspended for the first time. This ensures that the worklet's reported currentTime during its own initialization will also match the AudioContext's currentTime. Bug:40246707 Change-Id: I33403bdcd78918e61a462c2a0b1ec4d99f6b9562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906880 Reviewed-by: Michael Wilson <[email protected]> Commit-Queue: Sunggook Chue <[email protected]> Reviewed-by: Gabriel Brito <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365266}
This is a followup to a previous change that removed compositor keyframe snapshots for composited paint worklet animations. That changed allowed for changes in custom properties to result in the necessary paint invalidations for composited animations. Thus, the property filter for clip path animations can be amended to allow for custom property animations. Change-Id: I24941b2e6f705cb4342fdfdd8f9c62ef28a25519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5856667 Reviewed-by: Kevin Ellis <[email protected]> Commit-Queue: Claire Chambers <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365289}
[1] added tests, but in the process also added a spurious commented out line that ended up being tested as a browser test. This deletes it. [1] https://chromium-review.googlesource.com/c/chromium/src/+/5905066 Bug: 344963946 Change-Id: Idb25ded0af9af81510c47d38d04ff98d1c658307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5913435 Reviewed-by: Fr <[email protected]> Commit-Queue: Yoav Weiss (@Shopify) <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364928} Co-authored-by: Yoav Weiss <[email protected]>
This CL adds a new WPT to test sendBeacon() can be called during prerendering and onprerenderingchange, and after activation. Bug: 371971702 Change-Id: Icbc634ab58083e577a41fad4a473498a1f1271c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5914032 Reviewed-by: Lingqi Chi <[email protected]> Commit-Queue: Hiroki Nakagawa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365320}
…near This CL also adds some WPT conformance tests to verify the implementation. Bug: 40206287 Change-Id: Ieb8ce3ae2182388ae7cc98cd1fc8e3d2dcd9c7d2 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861613 Commit-Queue: Lisha Guo <[email protected]> Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Reviewed-by: Rafael Cintron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365343}
As per https://drafts.csswg.org/css-text-4/#letter-spacing-property. Differential Revision: https://phabricator.services.mozilla.com/D224747 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1884118 gecko-commit: 94d220f04c1c6cfb9a0c000c796e3ae6e26953fc gecko-reviewers: dshin
The zoom factor is stored as a fixed point number, and the effective zoom may be close to 0 (because we have to mulitply the zoom values of ancestors). So we have to make sure we don't divide by zero because the effective zoom could be zero. Differential Revision: https://phabricator.services.mozilla.com/D224551 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1922339 gecko-commit: 7ad44be1dfac1c831a3ed62658bb6dfc2851a70b gecko-reviewers: layout-reviewers, firefox-style-system-reviewers, emilio
…all selection ranges Selection ranges can cross editing host boundaries if no editing host has focus. Therefore, `Selection.focusNode` may be in an editing host but there may be no active/focused editing host. The computation may be expensive if there are a lot of ranges and selecting in slotted shadow tree. However, it's rare case, so, I think it's okay for now. Differential Revision: https://phabricator.services.mozilla.com/D224282 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1922149 gecko-commit: 356daac9fcd1d2ded218db99afc3ae81ed8711ba gecko-reviewers: m_kato
…alue It's possible to create cyclic CSSUnparsedValues. This causes infinite recursion when serializing the value. The spec needs to say how this should be handled, but meanwhile, we handle the problem by serializing an empty string for cycles. Fixed: 371292572 Change-Id: I15ff38ff2b87eecec1f175d6aab7736dcf8091ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5905363 Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365367}
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.3.0 to 6.9.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@1a16264...4f58ea7) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
It's possible to get empty CSSNestedDeclarations rules using CSSOM, and such rules serialize as the empty string. This causes "junk whitespace" in the serialization of outer rules, which is unattractive. The CSSOM spec was therefore recently changed to ignore child rules which serialize to empty strings. Bug: 343463516 Change-Id: I71738906b3b7979654bd0b723a57e048d6ce2195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901835 Reviewed-by: Steinar H Gunderson <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1365466}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )