Adding a dynamic stress (wave model) to wall_models #1233
Conversation
|
@ayalamanuel do you have any updates on this? |
|
@marchdf Old files have been updated. Unit test, regression test and documentation have been added. Thanks! |
|
I've made the modifications to all the comments made @marchdf |
|
A meta comment here: to get past the CI check, the first thing you need to do is format your code. You can do that automatically with clang-format: https://exawind.github.io/amr-wind/developer/coding_guidelines.html#style-guide-recommendations |
ayalamanuel
force-pushed
the
manuel/wall_model
branch
from
cda5933
to
55ed3c3
Compare
ayalamanuel
force-pushed
the
manuel/wall_model
branch
from
7489570
to
38bdbe7
Compare
| bx.contains(amrex::IntVect(i, j, k_lo))); | ||
| AMREX_ALWAYS_ASSERT( | ||
| bx.contains(amrex::IntVect(i, j, k_hi))); | ||
| const amrex::Real z_diff = dx[0] - (k_lo + 0.5) * dx[2]; |
There was a problem hiding this comment.
There is still the negative z_diff issue that I mentioned previously. This logic for interpolation needs to be more nuanced to handle several edge cases.
There was a problem hiding this comment.
The issue stems from the fact that you're using floor a ratio of dx[0]/dx[2] and subsequently adding a 0.5 to this floor, I think the actual k_lo calculation should be floor(dx[0]/dx[2] - 0.5).
Please double check to ensure that this inequality is always true: (k_lo + 0.5) * dx[2] < dx[0] < (k_lo + 1 + 0.5)*dx[2], otherwise your interpolation will not work.
You're still operating under the assumption that dx[0] > dx[2] too, might want to check for that as well.
There was a problem hiding this comment.
I agree. I just did some modifications to the interpolation to try to make it more general. I think it's a little bit convoluted but i understand why we need to do this.
| (z_interp - z_lo) / (z_hi - z_lo); | ||
| const amrex::Real u_low = | ||
| vold_arr(i, j, k_lo, 0); | ||
| const amrex::Real u_up = |
There was a problem hiding this comment.
Minor comment, can we change these to u_lo and u_hi to be consistent with k_lo and k_hi? (Or k_low and k_hi).
|
|
||
| // Check if the interpolation condition is | ||
| // satisfied | ||
| if (z_lo < z_interp && z_interp < z_hi) { |
There was a problem hiding this comment.
Should this be z_lo <= z_interp? Example dx[0] = 1.5 * dx[2]
| tau.get_shear( | ||
| vv, wspd, u_dx, v_dx, xc, 1) / | ||
| mu * den(i, j, k); | ||
| } else { |
There was a problem hiding this comment.
I'm curious, when do we expect this branch to occur?
|
Can I do anything to help push this through? We are super close I think. |
Summary
We have introduced a dynamic stress as a wall model. the dynamic stress calculates the stress due to waves. a new struct was implemented in ShearStressSimple.H where the wave stress is calculated. a new header (MOSD.H) was created with the calculations of the stress. the WallFunction.cpp has been modified accordingly.
Unit testing (test_mosd.cpp) and regression testing (channel_mosd.inp) using CPU has been done and added. The documentation of the model has also been added in the inputs_Boundary_conditions.rst file.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: