-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove memory spike in Sampling #1235
base: main
Are you sure you want to change the base?
Conversation
This is great except that it now all ranks need to know about the probe locations. So it ends up needing more memory in total though there is no spike. The next step that I want to do before this PR is merged is to have the ranks only need to know about probe locations that are relevant to it. Basically I want to pass |
ac8f6e4
to
fc43780
Compare
Status update before I leave this aside for a bit:
|
fc43780
to
1f1a69a
Compare
5f5c8ff
to
fd05e86
Compare
5a54ba1
to
c99cba2
Compare
Progress is being made... I need to fix the m_fill_val in radar sampler to be the min of the domain (checking to see if that's allowed). And then netcdf builds need to be fixed with the realvect change. And then finally I can call |
0ce7375
to
d781798
Compare
c989db1
to
7a8436e
Compare
We are close. I added the box check which is the thing that should help the memory pressure. I need to check it on a large case and see if it actually works/causes no diffs. The only other thing I am "worried" about is the radar sampler since I don't have an input file for that. |
Summary
This removes the memory spike on the ioproc when doing sampling by initializing the sampling particles in parallel.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: #1186