Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed mode numbers for pong and surround #397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benblack769
Copy link
Contributor

This fixes the surround and pong game modes to align with the manual, as per discussion here #366.

@JesseFarebro
Copy link
Collaborator

@weepingwillowben do you have any sense of how aligned other modes are with their manual, i.e., 1-indexed with the proper indices?

@benblack769
Copy link
Contributor Author

@JesseFarebro
My understanding is that most of the environments are currently 0 indexed, even though the manual is 1 indexed. Pong is an example of this. Pong is important to us because there are so many interesting multi-player modes in it.

A few were indexed in more bizarre manners, for example Surround's modes currently start at -1. Some of those were fixed by #365.

Then there are a few environments that do have modes in ALE, but not in the game manual, such as double dunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants