Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore functionality of Imaginate #1760

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Restore functionality of Imaginate #1760

wants to merge 6 commits into from

Conversation

Keavon
Copy link
Member

@Keavon Keavon commented May 26, 2024

Closes #1511

@TrueDoctor
Copy link
Member

I think this can probably be closed, most of the relevant parts of the code have been merged in other prs, the only thing worth extracting would be the cloudflare api interaction, Thoughts @Keavon ?

@Keavon
Copy link
Member Author

Keavon commented Aug 7, 2024

I plan to extract the API parts once the deadlock is fixed, then I'll either close or reuse this PR for the API stuff.

Copy link

Found Clippy warnings

Clippy Warnings/Errors

error[E0308]: mismatched types
   --> node-graph/gcore/src/raster/image.rs:167:86
    |
167 |             .write_image(bytemuck::cast_slice(self.data.as_slice()), self.width, self.height, ::image::ColorType::Rgba8)
    |              ----------- arguments to this method are incorrect                               ^^^^^^^^^^^^^^^^^^^^^^^^^ expected `ExtendedColorType`, found `ColorType`
    |
note: method defined here
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/image-0.25.2/src/image.rs:772:8
    |
772 |     fn write_image(
    |        ^^^^^^^^^^^
help: call `Into::into` on this expression to convert `image::ColorType` into `image::ExtendedColorType`
    |
167 |             .write_image(bytemuck::cast_slice(self.data.as_slice()), self.width, self.height, ::image::ColorType::Rgba8.into())
    |                                                                                                                        +++++++

error[E0308]: mismatched types
   --> node-graph/gcore/src/raster/image.rs:235:45
    |
235 |         encoder.write_image(&data, width, height, ::image::ColorType::Rgba8).expect("failed to encode image as png");
    |                 -----------                       ^^^^^^^^^^^^^^^^^^^^^^^^^ expected `ExtendedColorType`, found `ColorType`
    |                 |
    |                 arguments to this method are incorrect
    |
note: method defined here
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/image-0.25.2/src/image.rs:772:8
    |
772 |     fn write_image(
    |        ^^^^^^^^^^^
help: call `Into::into` on this expression to convert `image::ColorType` into `image::ExtendedColorType`
    |
235 |         encoder.write_image(&data, width, height, ::image::ColorType::Rgba8.into()).expect("failed to encode image as png");
    |                                                                            +++++++

For more information about this error, try `rustc --explain E0308`.
error: could not compile `graphene-core` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

@Keavon Keavon force-pushed the master branch 3 times, most recently from e5215a5 to f2493d5 Compare August 27, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement the Imaginate node and viewport tool
2 participants