Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store network metadata information in the Node Network #1957

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

adamgerhant
Copy link
Collaborator

@adamgerhant adamgerhant commented Sep 4, 2024

Stores all network metadata as value inputs to cloned nodes. This will allow the new node graph rendering process to have access to the metadata.

TODO:
Toggle to layer is broken

Copy link

github-actions bot commented Sep 4, 2024

Found Clippy warnings

Clippy Warnings/Errors

warning: this expression creates a reference which is immediately dereferenced by the compiler
    --> editor/src/messages/portfolio/document/utility_types/network_interface.rs:1037:74
     |
1037 |         let Some(tagged_value) = self.metadata_value(MetadataType::Previewing, &network_path) else {
     |                                                                                ^^^^^^^^^^^^^ help: change this to: `network_path`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
     = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
     = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: this expression creates a reference which is immediately dereferenced by the compiler
    --> editor/src/messages/portfolio/document/utility_types/network_interface.rs:1049:111
     |
1049 |         let Some(tagged_value) = self.metadata_value(MetadataType::NavigationMetadata(NavigationMetadataType::PTZ), &network_path) else {
     |                                                                                                                     ^^^^^^^^^^^^^ help: change this to: `network_path`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> editor/src/messages/portfolio/document/utility_types/nodes.rs:154:3
    |
154 |         &self
    |         ^^^^^ help: change this to: `self`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: `graphite-editor` (lib) generated 3 warnings (run `cargo clippy --fix --lib -p graphite-editor` to apply 3 suggestions)
warning: `graphite-editor` (lib test) generated 3 warnings (3 duplicates)
warning: `graphite-editor` (lib) generated 3 warnings (3 duplicates)
    Finished `dev` profile [optimized + debuginfo] target(s) in 4m 55s

@adamgerhant adamgerhant marked this pull request as draft September 5, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant