Support correct settings of vlen float arrays #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
reviewed
May 6, 2024
|
|
||
| data = np.array([e0, e1], dtype=dtvlen) | ||
| try: | ||
| # This will fail on HSDS because data is a ndarray of shape (2,3) of floats |
There was a problem hiding this comment.
Is this something that should fail due to how the API is defined, or just a bug?
There was a problem hiding this comment.
I feel like this is a bug in h5py. I'll submit an issue, but I expect they'll tell me the answer is to just set the dataset element by element in this case.
There was a problem hiding this comment.
See this example: https://gist.github.com/jreadey/884b59a30090b0f8122c3ab51291aa6c.
dset[...] = arr
Attempts to write to a shape (2,) dataset with a shape (2,) numpy array, but fails with a broadcast error.
Seems like a bug in h5py, so the test case has a special handler for the test running in h5py for now.
mattjala
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With vlen datatypes, writing to the dataset would raise an error if the vlen types were uniform. i.e., an array like:
[ndarray[1, 2], ndarray[3,4], ndarray[5,6]] would be processed as [[1,2],[3,4],[5,6]] (a shape of (3,2) during the arrayToBytes conversion rather than (3), causing a broadcast error. This PR fixes that so the data can be written to the expected shape.