Use replace_call!() to replace Expr(:call, ...) values

[staticfloat]

This is necessary to prevent the callinfo field from falling out of sync with the call itself, causing future optimization passes (such as inlining) to compute incorrect results.

[staticfloat]

@oxinabox Can I give you the task of finding other places within Diffractor where we replace Expr(:call, ..) values, and use replace_call!() there as well? We don't have to do this for IR statements we're inserting, only ones we're overwriting.

[codecov]

Codecov Report

Patch coverage: 62.50% and project coverage change: +0.01 🎉

Comparison is base (dc3c60e) 52.42% compared to head (077de69) 52.44%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   52.42%   52.44%   +0.01%     
==========================================
  Files          27       27              
  Lines        2722     2723       +1     
==========================================
+ Hits         1427     1428       +1     
  Misses       1295     1295              

Impacted Files	Coverage Δ
src/codegen/forward_demand.jl	44.74% <25.00%> (+0.15%)	⬆️
src/stage1/compiler_utils.jl	95.65% <100.00%> (+0.41%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[oxinabox]

sure, will do

[oxinabox]

Having looked at every instance of Expr(:call and :inst] and stmt I can't find any others
there is one that replaces it in a IncrementalCompact but i think that is fine.
the rest are inserts.