Add support for StaticArrays >= 1.7 #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
approved these changes
May 29, 2024
devmotion
added a commit
that referenced
this pull request
Sep 30, 2024
devmotion
added a commit
that referenced
this pull request
Sep 30, 2024
devmotion
added a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In StaticArrays 1.7 broadcasting with static arrays was improved: JuliaArrays/StaticArrays.jl#1220 This fix implies that in some cases in newer versions now a static array is returned where in older versions incorrectly an
Arraywas returned.In ForwardDiff this breaks the
eigendefinition which uses an in-place method_lyap_div!to computeA ./ (l' .- l)(with diagonal entriesA[i, i]). This PR fixes the problem by replacing it with a_lyap_div!!method that, following the bang-bang notation, falls back to an out-of-place implementation and only uses an in-place method for arrays that are known to be mutable such asMatrixorStaticArrays.MMatrix.Fixes #690.
Fixes #702.