-
Notifications
You must be signed in to change notification settings - Fork 38
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
consistent band indexing for structured matrices (#376)
* consistent band indexing for structured matrices * Add test for Eye * bump FillArrays compat bound
- Loading branch information
Showing
3 changed files
with
26 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
529be5d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jishnub I need to revert this as its breaking the infinite dimensional case. I don't really understand the motivation for this change.
529be5d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also seems to be a regression in terms of behaviour.
529be5d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I think this was originally meant to be only for matrices with Fill bands, for which
FillArrays
already implements the requisitediag
methods. You are welcome to revert this, and we may handle that case later.529be5d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then again, I would expect
diag
to work if indexing withBand
works, so this is really guarding against incomplete implementations. This comes at the expense of type-stability, which was the main motivation behind the change. I would urge considering this change for the next breaking release ofBandedMatrices
, and implementdiag
appropriately downstream.529be5d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regression was that you were no longer checking that they were
≡ Fill