-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reserveCells
crashes mint
mesh inside Umpire
#1271
Draft
gunney1
wants to merge
6
commits into
develop
Choose a base branch
from
bugfix/gunney/ug-immediate-reserve
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunney1
added
Sidre
Issues related to Axom's 'sidre' component
Quest
Issues related to Axom's 'quest' component
Mint
Issues related to Axom's 'mint' component
labels
Feb 6, 2024
gunney1
force-pushed
the
bugfix/gunney/ug-immediate-reserve
branch
from
February 7, 2024 00:36
643c441
to
f25bdc4
Compare
Some new observations:
|
After merging in the latest develop branch, the failed test ( |
I don't know the true cause of the crash or why it only exhibits on our docker environments. An ideal fix based on an understanding of the bug should be pursued. This commit also backs out work-arounds for avoiding trigging the crash.
gunney1
force-pushed
the
bugfix/gunney/ug-immediate-reserve
branch
from
October 6, 2024 13:49
0c089b5
to
c96baed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crash reserving space for
UnstructuredMesh
This crash has been plaguing PR #1263. The
MarchingCubes
test crashes while askingmint::UnstructuredMesh
to reserve space. This PR aims to provide a reproducer and correct the crash.Two identical tests were added:
src/axom/quest/tests/quest_initialize.cpp
src/axom/mint/tests/mint_mesh.cpp
Interesting behaviors:
quest
reproduces the crash, but the one added tomint
does not.