-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BVH improvements #1429
base: develop
Are you sure you want to change the base?
BVH improvements #1429
Conversation
My only concern is that initialize returns a bool indicating whether construction succeeds. But it looks like it always returns true, so it's probably not worth worrying about. |
"Avoids unnecessary copy of each bounding box" @adayton1 have you ever thought that maybe we want to do extra work?!?! Why do you have to make everything so efficient and better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment nit and CI check compilation issues to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adayton1 !
/style |
Summary
Current pattern
New pattern