Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Construct shapes in memory and support more shapes #1436

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from
Draft

Construct shapes in memory and support more shapes #1436

wants to merge 29 commits into from

Conversation

gunney1
Copy link
Contributor

@gunney1 gunney1 commented Oct 2, 2024

Summary

This is one of several steps toward extending support for shaping on GPUs and exending the menu of shapes supported.

  • This PR is a extension of the support for intersection shaping
  • It does the following (modify list as needed):
    • Adds a number of shapes to intersection shaping, such as analytical spheres, cones, cylinders.
    • Adds interfaces for specifying the shapes in memory (instead of reading them from files)
    • Re-factors some code to reduce dependence on the MEM mesh interface, as an initial step toward supporting Blueprint meshes. (Blueprint mesh support will be in separate PR.)

@gunney1
Add const to input arguments to assure they are not changed.
04c3971
@gunney1
Preliminary ability to generate shape in memory.
7bd74e5 
This commit adds test code for testing in-memory shape construction
and shaping with those objects.
@gunney1
Add 2 more checks and exit with number of failures found.
88e8222
@gunney1
Fix bug that fails to apply GeometryOperators that are not composites.
126934b
@gunney1
Add optional scaling to test the use of geometry operator.
03b3f07
@gunney1
Add analytical sphere test and factor out code to generate discrete s…
2cbfb3c 
…hape.
@gunney1
Remove obsolete code from Shaper.
758b7ab
@gunney1
Some name changes to fit accepted terminology.
711b29a
@gunney1
Add SOR, cylinder and cone to in-memory shaping.
63358e9
@gunney1
Small changes to comments.
cf58388
@gunney1
Implement arbitrary locations for VOR (not always on x-axis).
e3e8974
@gunney1
Add hexahedron shaping (in-memory only for now, not through klee).
381a75a
@gunney1
Set DiscreteShape default behavior for adaptive refinement of SOR.
931d1ba
@gunney1
Fix mesh pointers that get passed into classes then deleted.
4bee170 
Fix by changing the pointer references to shared_ptr references.
This bug was recently created when factoring out the generation
of the mesh so it can be saved outside the scope it was generated
in.
@gunney1
Get in-memory shaping working on rzansel host execution.
b409d47
@gunney1
Enable multi-policy testing for in-memory shaping.
e5ac6bd
@gunney1
Merge remote-tracking branch 'gh/develop' into feature/gunney/constru…
df21a07 
…ct-shapes-in-memory
@gunney1
Support single tet shape in in-memory shaping.
6815047
@gunney1
Support plane shape.
ae8bfb2
@gunney1
Merge remote-tracking branch 'gh/develop' into feature/gunney/constru…
d51a85f 
…ct-shapes-in-memory
@gunney1
Make some groups and views const where they are not modified.
382313e
@gunney1
More robust way to get temporary unique Group name.
d73df72
@gunney1
Change parameter ordering.
933e4e3
@gunney1
Rename memory-blueprint format to blueprint-tet and add checks
42bf676 
to ensure the user provided a blueprint mesh.
@gunney1
Factor out code to shorten a method for readability.
6585fa2
@gunney1
Reformat.
408b427
@gunney1 gunney1 self-assigned this Oct 2, 2024
@gunney1 gunney1 added Quest Issues related to Axom's 'quest' component Klee Related to the Klee component labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gunney1 gunney1

Labels
Klee Related to the Klee component Quest Issues related to Axom's 'quest' component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gunney1