-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
borrow dependencies from MFEM [simplify-cmake] #54
base: master
Are you sure you want to change the base?
Conversation
that MFEM is using and just copies them. This means we don't have to separately configure Hypre, Metis, Suitesparse, etc.
Really I am trying to debug the Travis build, which is kind of a pain.
The automation in this PR is very nice. Having said that, and I know we have stopped working on "removing dependency on mfem" for a while, but I still think it's reasonable future work. If not too complicated, can we make this automation optional? E.g., set some flag to determine whether to get other dependencies (hypre, metis, etc) from mfem config file? Then there is still other option even if the python script fails to find other dependencies or later on we dont have mfem. By the way, I was testing it on my tux box, I got the following message, do you know what is the issue? I think
|
Having this be optional is a good idea, I will do that. Regarding your error, can you email me a copy of the MFEM config.mk file that it is trying to read? |
The automation should be optional now. In particular, if you have |
The new option When I turn it
But when I try to run some examples, it has an error
This path is different from the one in
|
Instead of specifying our own locations/libraries for HYPRE, Suitesparse, etc., this PR would just look up what dependencies MFEM uses and follow that.
This PR may not be a good idea - let me know what you think.
Advantages:
Disadvantages:
parsemk.py
) may be less flexible, might break in unexpected ways