generated from Leafwing-Studios/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deadzone shapes #370
Merged
Merged
Deadzone shapes #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
enhancement
New feature or request
breaking-change
A breaking change that requires a new major version
labels
Jul 30, 2023
WRT question 3, I'm increasingly convinced that we probably don't even want to store a |
Never used this API, so I don't have an opinion on it :( |
100-TomatoJuice
commented
Jul 30, 2023
100-TomatoJuice
commented
Aug 1, 2023
100-TomatoJuice
commented
Aug 1, 2023
alice-i-cecile
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
A breaking change that requires a new major version
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only type of deadzone for a
DualAxis
is a cross shape. This shape is preferred for some instances, like in Rocket League, as the cross-shape deadzone makes directional flipping easier. However, there are instances where a circular or rectangular deadzone is preferred, like a twin-stick shooter.Adds
DeadzoneShape
toDualAxis
, which allows the user to choose between a circle, rectangle, and a cross for the deadzone shape.From manual tests, the shapes appear to be correct and all work. This pr also passed
cargo test
.Things to do:
Hash
forDeadZoneShape
Cross
snappingDeadzoneShape
(feels a little convoluted)RELEASES.md
Questions
extract_dual_axis_data()
the correct method to test the different shapes?include_deadzone: bool
toinput_value()
feels a little gross, but I didn't find a better way to get the input_value of aSingleAxis
without it running its deadzone. Is there a better, perhaps overlooked, way of doing this?SingleAxis
. This keeps inverting of the input easy, but might create confusion?with_deadzone()
has been changed to hopefully make this easy, but there might be a better way.