-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lavamoat/webpack setup #2241
base: main
Are you sure you want to change the base?
lavamoat/webpack setup #2241
Conversation
1332cc8
to
855e986
Compare
855e986
to
2526ecf
Compare
2526ecf
to
6d95880
Compare
6d95880
to
eeac2f1
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
eeac2f1
to
3205648
Compare
3205648
to
4f94f3f
Compare
@SocketSecurity ignore npm/[email protected] - uses http for local server |
Policy generation works with no quirks to pave over with overrides.
Project successfully builds.
lockdown inlining solved with html-webpack-plugin itself. There's room for improvement, but it's pretty simple as is.
I did not remove the pre-existing browserify build.
Using typescript for weback config is not ideal, because it's a common problem that depending on how your dependencies arrange/dedupe you may get type mismatches between your webpack version and plugins. This problem will start manifesting itself once we publish types for the plugin. As soon as the version of webpack we take types from differs from the version used in the repo, we're risking a mismatch of the webpack plugin type (even for minor changes)