Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE count swaptotal in total ram (linux) #4599

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

minishd
Copy link

@minishd minishd commented Mar 23, 2022

Factors in swaptotal on top of memtotal when getting total ram amount on linux. Sorry if there is any issues, this is my first contribution

@minishd minishd changed the title count swaptotal in total ram (linux) NOISSUE count swaptotal in total ram (linux) Mar 23, 2022
@peterix
Copy link
Member

peterix commented Mar 23, 2022

Hmm. Are you sure this is a good idea?
The game would run really badly if you system is swapping. Practically, you want to use less memory than available RAM. The upper limit is not usable because of all the other things taking up memory.

@peterix
Copy link
Member

peterix commented Mar 23, 2022

I mean, I guess this is fine, but maybe this could be exposed in the UI in some way. Like having a checkbox 'allow swap' that expands the range.

@minishd
Copy link
Author

minishd commented Mar 24, 2022

You're right, I'll try to make a UI option for it.

@minishd minishd closed this Apr 3, 2022
@peterix peterix reopened this Apr 3, 2022
@peterix
Copy link
Member

peterix commented Apr 3, 2022

Please do not close pull requests like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants