Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-5166 Adding user account state to be refreshed during Instance Launch #5284

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

SithumDissanayake
Copy link

In the login function of LaunchController, added requestRefresh on the current m_accountToUse. This allows the accountState of accountToUse to be updated before running through what login is meant to depending on the accountState. This is to allow for the cases where a device might be back online after launching the Launcher. Putting this in the tryagain while loop also allows to check if a users account is expired during the login process.

Adds a force account refresh during the login process, updating the account state before the program performs an action depending on the account state.
This allows for users to start an instance with no internet connection, realise and update their internet connection and start an instance again with no issue.
Putting this in the tryagain while loop also allows to check if a users account is expired during the login process.
This also resolves issue GH-4356.
Tested as much as I could on Ubuntu Linux 22.04.3 LTS. No noticeable lag or crashes noticed with multiple launches rapidly in a row and was able to confirm that the account status does change in this case.

In the login function of LaunchController, added requestRefresh on the current m_accountToUse.
This allows the accountState of accountToUse to be updated before running through what login is meant to depending on the accountState. This is to allow for the cases where a device might be back online after launching the Launcher. Putting this in the tryagain while loop also allows to check if a users account is expired during the login process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant