ZK circuits for OpenID Authenticator #583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benr-ml
reviewed
May 7, 2023
benr-ml
reviewed
May 7, 2023
mskd12
force-pushed
the
deepak/openid-circuits
branch
from
c003164
to
4eb1009
Compare
benr-ml
reviewed
May 12, 2023
|
|
||
| // Checks on last char | ||
| var lastchar = actual_extended_nonce[extNonceLength - 1]; | ||
| (lastchar - 44) * (lastchar - 125) === 0; // lastchar = ',' or '}' |
There was a problem hiding this comment.
let's make this test a template and use it everywhere? AssertEndOfValue
benr-ml
reviewed
May 12, 2023
benr-ml
approved these changes
May 17, 2023
mskd12
force-pushed
the
deepak/openid-circuits
branch
from
93f69ea
to
23404d1
Compare
mskd12
force-pushed
the
deepak/openid-circuits
branch
from
4aaff0c
to
ed0f813
Compare
mskd12
force-pushed
the
deepak/openid-circuits
branch
from
5184dac
to
bbd602e
Compare
2. Refactor circuit input generation code in circuitutils.ts 3. Introduce CircuitConstants as a place to store all the circuit-related constants and simplify function signatures
1. Introduce ExtendedClaimParser to parse claim name and value for an arbitrary extended claim (with some JSON whitespaces) 2. Turned off NonceChecker temporarily 3. ExtendedClaimParser for sub implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an NPM library within fastcrypto containing the circom circuits