functions are hidden if DONUT_WITH_TASKFLOW is not defined #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
Merged, thank you - and sorry it took so long, I missed this PR when it came in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two functions
LoadTextureFromMemoryandLoadTextureFromMemoryDeferredare not related toTaskflow, but they are wrongly declared insideDONUT_WITH_TASKFLOWmacro scope.That means, if
DONUT_WITH_TASKFLOWis not defined and an program actually used these functions, linker complains for undefined symbols.In this PR, I move the two functions outside the scope(although git diff gives weired diff preview).
Besides, I put the declarations of the
LoadTextureFromFileAsyncandLoadTextureFromMemoryAsyncfunctions in the header file together because they both are related to taskflow.