Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCFramework support #64

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mateuszszklarek
Copy link

@mateuszszklarek mateuszszklarek commented Mar 31, 2021

Hi @kzaher! First for all thanks for your amazing works - I'm big fan of reactive approach in general 👍

I've added support for XCFramework - there was an issue to integrate RxFeedback via Carthage using --use-xcframeworks flag - I'm attaching logs that I've encountered during migration to xcframework.

/MyProject/Carthage/Checkouts/RxFeedback/Sources/RxFeedback/Feedbacks.swift:9:8: error: no such module 'RxCocoa'
import RxCocoa
       ^
** ARCHIVE FAILED **
The following build commands failed:
	CompileSwift normal armv7
	CompileSwiftSources normal armv7 com.apple.xcode.tools.swift.compiler
	CompileSwift normal arm64
	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
(4 failures)
  • fix the issue with integrating via Carthage and using --use-xcframeworks flag
  • use all dependencies as *.xcframework instead of *.framework
  • fix CI for Carthage integration

This PR solves this issue - let me know if there is anything that should be updated and I forgot about it 👍 🚀

@mateuszszklarek mateuszszklarek changed the title [WIP] XCFramwork support [WIP] XCFramework support Mar 31, 2021
@mateuszszklarek mateuszszklarek changed the title [WIP] XCFramework support XCFramework support Apr 1, 2021
ERROR ITMS-90685: CFBundleIdentifier Collision. There is more than one
bundle with the CFBundleIdentifier value 'io.rx.RxSwift' under the
iOS application 'MyApp.app'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant