Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All Hosts] (security) updating permissions articles for unified mani… #4719

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Rick-Kirkham
Copy link
Contributor

@Rick-Kirkham Rick-Kirkham commented Aug 9, 2024

…fest

DO NOT MERGE UNTIL PUBLIC PREVIEW OF UNIFIED MANIFEST FOR WXP.

Copy link
Contributor

Learn Build status updates of commit d44cf2f:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/privacy-and-security.md ✅Succeeded View
docs/develop/requesting-permissions-for-api-use-in-content-and-task-pane-add-ins.md ✅Succeeded View
docs/develop/support-for-task-pane-and-content-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit ce5ffbf:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/privacy-and-security.md ✅Succeeded View
docs/develop/requesting-permissions-for-api-use-in-content-and-task-pane-add-ins.md ✅Succeeded View
docs/develop/support-for-task-pane-and-content-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@samantharamon samantharamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some formatting suggestions and a question.

The following example shows how a task pane add-in specifies the **ReadDocument** permission in its manifest. To keep permissions as the focus, other elements in the manifest aren't displayed.
To see an example of how to request permissions in the manifest, open the tab for the type of manifest your add-in uses.

# [Unified manifest for Microsoft 365](#tab/jsonmanifest)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this now be "unified app manifest for Microsoft 365"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this now be "unified app manifest for Microsoft 365"?

I don't think so. Did I miss a memo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked it up from Office Add-ins with the unified app manifest for Microsoft 365.

I see. That's an acceptable variant that's consistent with Marketing's directive to use a description instead of a brand name, but normally we leave the "app" out. There's no place where we include the "app" in a section or tab title.

docs/concepts/privacy-and-security.md Outdated Show resolved Hide resolved
docs/develop/support-for-task-pane-and-content-add-ins.md Outdated Show resolved Hide resolved
Copy link
Contributor

Learn Build status updates of commit b1ee636:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/privacy-and-security.md ✅Succeeded View
docs/develop/requesting-permissions-for-api-use-in-content-and-task-pane-add-ins.md ✅Succeeded View
docs/develop/support-for-task-pane-and-content-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 1e3a9c4:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/privacy-and-security.md ✅Succeeded View
docs/develop/requesting-permissions-for-api-use-in-content-and-task-pane-add-ins.md ✅Succeeded View
docs/develop/support-for-task-pane-and-content-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit b855e36:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/privacy-and-security.md ✅Succeeded View
docs/develop/requesting-permissions-for-api-use-in-content-and-task-pane-add-ins.md ✅Succeeded View
docs/develop/support-for-task-pane-and-content-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit b2193a5:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/privacy-and-security.md ✅Succeeded View
docs/develop/requesting-permissions-for-api-use-in-content-and-task-pane-add-ins.md ✅Succeeded View
docs/develop/support-for-task-pane-and-content-add-ins.md ✅Succeeded View
docs/includes/unified-manifest-support-note.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 31c1d65:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 31c1d653e71e05024629b0bf527b298d91b14b37 in branch unified-manifest-permissions of repository https://github.com/OfficeDev/office-js-docs-pr into branch main (commit 10cbd9943421cc40f90bc9748fc9aae480e08848). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 9ee025c:

✅ Validation status: passed

File Status Preview URL Details
docs/concepts/privacy-and-security.md ✅Succeeded View
docs/develop/requesting-permissions-for-api-use-in-content-and-task-pane-add-ins.md ✅Succeeded View
docs/develop/support-for-task-pane-and-content-add-ins.md ✅Succeeded View
docs/includes/unified-manifest-support-note.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants