Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid second call to ippFindAttribute #1047

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Avoid second call to ippFindAttribute #1047

merged 1 commit into from
Sep 13, 2024

Conversation

AreaZR
Copy link
Contributor

@AreaZR AreaZR commented Sep 12, 2024

We already have the attr value.

michaelrsweet
michaelrsweet requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, if we are going to do this let's move the assignment of job->creation_time right after we get the pointer.

@michaelrsweet michaelrsweet self-assigned this Sep 13, 2024
@michaelrsweet michaelrsweet added enhancement New feature or request priority-low labels Sep 13, 2024
@michaelrsweet michaelrsweet added this to the v2.5 milestone Sep 13, 2024
@AreaZR
Avoid second call to ippFindAttribute
6a21f1d 
We already have the attr value.
@michaelrsweet michaelrsweet merged commit 7e1a313 into OpenPrinting:master Sep 13, 2024
3 of 6 checks passed
@AreaZR AreaZR deleted the f branch September 13, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelrsweet michaelrsweet michaelrsweet approved these changes

Assignees

@michaelrsweet michaelrsweet

Labels
enhancement New feature or request priority-low
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@AreaZR @michaelrsweet