refactor holograms out of flags #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KingOfSquares <[email protected]>
Signed-off-by: KingOfSquares <[email protected]>
Electroid
requested changes
Apr 25, 2023
Signed-off-by: KingOfSquares <[email protected]>
Signed-off-by: KingOfSquares <[email protected]>
Pablete1234
reviewed
Apr 26, 2023
Pablete1234
requested changes
May 12, 2023
Signed-off-by: KingOfSquares <[email protected]>
Pablete1234
previously approved these changes
Jul 10, 2023
Signed-off-by: Pablo Herrera <[email protected]>
|
@Electroid could you take a look at it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards #1042
Moves the hologram stuff for flags out into its own API, should create no behaviour changes