Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[complex] No.31 add complex support for softplus #57540

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

xiaoyewww
Copy link
Contributor

@xiaoyewww xiaoyewww commented Sep 20, 2023

PR types

Others

PR changes

APIs

Description

add complex support for softplus
#56145

@paddle-bot
Copy link

paddle-bot bot commented Sep 20, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 20, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 20, 2023
@luotao1 luotao1 changed the title [complex] add complex support for softplus [complex] No.31 add complex support for softplus Sep 20, 2023
@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Sep 22, 2023
@luotao1
Copy link
Contributor

luotao1 commented Sep 22, 2023

@ScottWong98 可以review一下

@@ -0,0 +1 @@
Defaulting to user installation because normal site-packages is not writeable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件的作用是?

self.dtype = np.complex128

def test_check_grad(self):
self.check_grad(['X'], 'Out', max_relative_error=0.06)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

complex64 和complex128的误差都是这样吗

@xiaoyewww xiaoyewww force-pushed the feat/complex-softplus branch 2 times, most recently from 1a4aacd to 8bcc691 Compare September 25, 2023 11:50
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 3, 2023

Sorry to inform you that 8bcc691's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@xiaoyewww
Copy link
Contributor Author

@GGBond8488 @ScottWong98 上述意见已修改,麻烦再review一下,谢谢

Copy link
Contributor

@GGBond8488 GGBond8488 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Oct 12, 2023

@xiaoyewww 请补充下对应的中文文档

@xiaoyewww
Copy link
Contributor Author

@xiaoyewww 请补充下对应的中文文档

@luotao1 请问一下中文文档是指哪部分?我看其他pr里面都没有补充

@luotao1
Copy link
Contributor

luotao1 commented Oct 13, 2023

可以参考下这个

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CI-OP-Benchmark

@luotao1 luotao1 merged commit 75fe655 into PaddlePaddle:develop Oct 13, 2023
28 checks passed
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@xiaoyewww xiaoyewww deleted the feat/complex-softplus branch May 10, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants