Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 7th No.35】为 Paddle 代码转换工具新增 API 转换规则(第 2 组)-part #6880

Merged
merged 4 commits into from
Sep 29, 2024

Conversation

ccsuzzh
Copy link
Contributor

@ccsuzzh ccsuzzh commented Sep 18, 2024

Copy link

paddle-bot bot commented Sep 18, 2024

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6880.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大量映射不正确

建议对Paddle API充分调研下,直接下一份源码在代码里搜索,或者import 下paddle动手尝试后再写。

@zhwesky2010
Copy link
Collaborator

@ccsuzzh 这个还未修改,需要针对每个API,找到最合适的映射

@ccsuzzh
Copy link
Contributor Author

ccsuzzh commented Sep 24, 2024

@ccsuzzh 这个还未修改,需要针对每个API,找到最合适的映射

目前还剩下几个API没有用inplace api组合实现,因为无法满足需要广播的情况,而PyTorch是支持的,需要全部改成inplace api组合实现吗?

Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全部需要用inplace来组合。

提交文档时,你同时提交paconvert的matcher和单测吧,实际运行测一下

### [paddle.tensor.create_tensor](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/api/paddle/Tensor_cn.html#create-tensor-dtype-name-none-persistable-false)

```python
paddle.tensor.create_tensor(dtype, name=None, persistable=False)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个API如何对上,self传给谁,写下转写实例看看

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前没有发现能够对的上的API。

@zhwesky2010
Copy link
Collaborator

@ccsuzzh Matcher和单测看起来基本都是正确的了,把文档也同步下吧,文档和Matcher需要对齐一致

Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit cbbc029 into PaddlePaddle:develop Sep 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor PaddlePaddle Hackathon 飞桨黑客松活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants