Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DOM manipuation and style #186

Merged
merged 14 commits into from
Feb 14, 2024
Merged

Refactor DOM manipuation and style #186

merged 14 commits into from
Feb 14, 2024

Conversation

Pistonight
Copy link
Contributor

@Pistonight Pistonight commented Feb 11, 2024 •
edited
Loading

  • Use griffel for styling as much as possible
  • Use DOMClass and DOMId to single source stable identifiers

Closes #169

The settings stuff need to be re-looked when fixing the react-refresh, so leaving that for now

@Pistonight Pistonight added the refactor That works better label Feb 11, 2024
@Pistonight Pistonight self-assigned this Feb 11, 2024
@Pistonight Pistonight added this to the Alpha 2 milestone Feb 11, 2024
Pistonight
Pistonight commented Feb 14, 2024
View reviewed changes
Copy link
Contributor Author

@Pistonight Pistonight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked

@Pistonight Pistonight marked this pull request as ready for review February 14, 2024 01:07
@Pistonight Pistonight merged commit 6ef1fd3 into main Feb 14, 2024
7 checks passed
@Pistonight Pistonight deleted the refactor/style branch February 14, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Pistonight Pistonight

Labels
refactor That works better
Projects
None yet
Milestone
Alpha 2
Development

Successfully merging this pull request may close these issues.

Finish DOM Refactoring
1 participant
@Pistonight